Skip to content

[module-cleanup] Cleanup results for finagle-http-23.11:javaagent #392

Description

@github-actions

Applied cleanup commit f5a5591b for instrumentation/finagle-http-23.11/javaagent.

Applied fixes:

  • build.gradle.kts: moved shared test JVM arguments and constrained-worker system properties into withType<Test>().configureEach, matching Gradle conventions for modules with custom Test tasks and removing duplicate per-task configuration.
  • FutureInstrumentation.java, FuturePoolInstrumentation.java, PromiseKInstrumentation.java, and BijectionsNettyInstrumentation.java: removed redundant isMethod() from named non-empty method matchers, following the javaagent matcher cleanup rule.
  • FinagleClientExtension.java: reduced the test helper class, constructor, and service accessors to package-private visibility per minimal visibility and JUnit test-code style guidance.

Validation observed:

  • ./gradlew --console=plain :instrumentation:finagle-http-23.11:javaagent:check passed after manual formatting.
  • ./gradlew --console=plain :instrumentation:finagle-http-23.11:javaagent:check -PtestLatestDeps=true passed.
  • ./gradlew --console=plain :instrumentation:finagle-http-23.11:javaagent:muzzle passed after reverting the attempted inverse assertions.
  • ./gradlew --console=plain spotlessApply passed.

Needs Manual Fix:

  • build.gradle.kts muzzle pass blocks still omit assertInverse.set(true). Adding it was attempted because the Gradle convention recommends inverse checks for bounded ranges, but muzzle failed because older Finagle versions still pass validation (for example finagle-http_2.12 versions before 23.11.0 and finagle-http_2.13 versions before 23.11.0). A correct fix requires a version-boundary decision, such as additional classloader gating or an explicit reason to keep inverse assertions disabled.

Generated by Module Cleanup — Single Module ·

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions