Skip to content

Commit 7d591f7

Browse files
committed
Test icon tweaks
1 parent 77c8a26 commit 7d591f7

6 files changed

Lines changed: 19 additions & 11 deletions

File tree

  • apps/webapp/app/routes
    • _app.orgs.$organizationSlug.projects.$projectParam.env.$envParam._index
    • _app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.agents.$agentParam
    • _app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.agents._index
    • _app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.tasks.standard.$taskParam
    • _app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.test.tasks.$taskParam
    • _app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.test

apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam._index/route.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -314,13 +314,13 @@ export default function Page() {
314314
icon={RunsIcon}
315315
to={runsPath}
316316
title="View runs"
317-
leadingIconClassName="text-runs"
317+
leadingIconClassName="-mx-1 text-runs"
318318
/>
319319
<PopoverMenuItem
320320
icon={BeakerIcon}
321321
to={testPath}
322322
title="Test task"
323-
leadingIconClassName="text-tests"
323+
leadingIconClassName="-mx-1 text-tests"
324324
/>
325325
</>
326326
}

apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.agents.$agentParam/route.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -311,7 +311,7 @@ function AgentDetailSidebar({
311311
to={playgroundPath}
312312
LeadingIcon={BeakerIcon}
313313
iconSpacing="gap-x-2"
314-
leadingIconClassName="-mx-2 text-tests"
314+
leadingIconClassName="-mx-2"
315315
>
316316
Test
317317
</LinkButton>

apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.agents._index/route.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -343,7 +343,7 @@ export default function AgentsPage() {
343343
icon={RunsIcon}
344344
to={runsPath}
345345
title="View runs"
346-
leadingIconClassName="text-runs"
346+
leadingIconClassName="-mx-1 text-runs"
347347
/>
348348
<PopoverMenuItem
349349
icon={BeakerIcon}
@@ -354,7 +354,7 @@ export default function AgentsPage() {
354354
agent.slug
355355
)}
356356
title="Test"
357-
leadingIconClassName="text-tests"
357+
leadingIconClassName="-mx-1 text-tests"
358358
/>
359359
</>
360360
}

apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.tasks.standard.$taskParam/route.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -224,10 +224,10 @@ function TaskDetailSidebar({ task, testPath }: { task: TaskDetail; testPath: str
224224
variant="primary/small"
225225
to={testPath}
226226
LeadingIcon={BeakerIcon}
227-
iconSpacing="gap-x-1"
228-
leadingIconClassName="-mx-1.5 text-tests"
227+
iconSpacing="gap-x-2"
228+
leadingIconClassName="-mx-2"
229229
>
230-
Test task
230+
Test
231231
</LinkButton>
232232
</Property.Value>
233233
</Property.Item>

apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.test.tasks.$taskParam/route.tsx

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import { conform, useForm } from "@conform-to/react";
22
import { parse } from "@conform-to/zod";
33
import {
4-
BeakerIcon,
54
StarIcon,
65
RectangleStackIcon,
76
TrashIcon,
@@ -79,6 +78,7 @@ import { RegionsPresenter, type Region } from "~/presenters/v3/RegionsPresenter.
7978
import { TestSidebarTabs } from "./TestSidebarTabs";
8079
import { AIPayloadTabContent } from "./AIPayloadTabContent";
8180
import { SchemaTabContent } from "./SchemaTabContent";
81+
import { BeakerIcon } from "~/assets/icons/BeakerIcon";
8282

8383
type FormAction = "create-template" | "delete-template" | "run-scheduled" | "run-standard";
8484

@@ -880,7 +880,8 @@ function StandardTaskForm({
880880
type="submit"
881881
variant="primary/medium"
882882
LeadingIcon={BeakerIcon}
883-
leadingIconClassName="text-tests"
883+
iconSpacing="gap-x-2.5"
884+
leadingIconClassName="-mx-2"
884885
shortcut={{ key: "enter", modifiers: ["mod"], enabledOnInputElements: true }}
885886
name="formAction"
886887
value={"run-standard" satisfies FormAction}
@@ -1458,7 +1459,8 @@ function ScheduledTaskForm({
14581459
type="submit"
14591460
variant="primary/medium"
14601461
LeadingIcon={BeakerIcon}
1461-
leadingIconClassName="text-tests"
1462+
iconSpacing="gap-x-2.5"
1463+
leadingIconClassName="-mx-2"
14621464
shortcut={{ key: "enter", modifiers: ["mod"], enabledOnInputElements: true }}
14631465
name="formAction"
14641466
value={"run-scheduled" satisfies FormAction}

apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.test/route.tsx

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,13 @@ export default function Page() {
9595
<MainCenteredContainer className="max-w-md">
9696
<TestHasNoTasks />
9797
</MainCenteredContainer>
98+
) : taskParam ? (
99+
// Task selected via URL → skip the picker; the child route owns the page.
100+
<Outlet key={taskParam} />
98101
) : (
102+
// No task in URL: show the picker as a fallback so users landing on
103+
// /test (e.g. from the runs blank state with multiple task filters)
104+
// can still choose one.
99105
<div className={cn("grid h-full max-h-full grid-cols-1")}>
100106
<ResizablePanelGroup orientation="horizontal" className="h-full max-h-full">
101107
<ResizablePanel id="test-selector" min="200px" default="20%">

0 commit comments

Comments
 (0)