Skip to content

Commit 706deee

Browse files
italobusiitalobusi
authored
Addressing RFC8776-bis WG LC comments (#291)
Addressing additional WG LC comments: - Addressing minor comments from Med not implemented in PR #280 : fix #290 - Added an appendix with YANG tree to RFC8776-bis: fix #290 - Reordered the acronyms and abbreviations in RFC8776-bis: fix #290 - Updated bandwidth profile definitions: fix #285 - Removed te-gen-node-id and moved union within the te-generic-node-id: fix #288 - Fixed normative references: fix #287 - Clarify why path-computation-error-reason has not been defined in an IANA-maintained model: fix #281 - Added formats for the MPLS-TE path bandwidth: fix #284
1 parent 5299bd4 commit 706deee

17 files changed

Lines changed: 7725 additions & 5167 deletions

‎.gitignore‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,3 +9,4 @@ rsvp_te_model.tree.save
99
drafts/te-topo-profile/.refcache/*.*
1010
drafts/mpls-te-topology/.refcache/*.*
1111
drafts/te-types-update/.refcache/*.*
12+
drafts/te-types-update/diffs/*.*

‎drafts/te-types-update/diffs/te-pkt-types/model-diff-spaces.txt‎

Lines changed: 122 additions & 50 deletions
Original file line numberDiff line numberDiff line change
@@ -41,14 +41,14 @@
4141
< the license terms contained in, the Simplified BSD License set
4242
---
4343
> the license terms contained in, the Revised BSD License set
44-
51,52c65,86
44+
51,52c65,87
4545
< This version of this YANG module is part of RFC 8776; see the
4646
< RFC itself for full legal notices.";
4747
---
4848
> This version of this YANG module is part of RFC XXXX
4949
> (https://www.rfc-editor.org/info/rfcXXXX); see the RFC itself
5050
> for full legal notices.";
51-
> revision 2024-07-23 {
51+
> revision 2024-09-27 {
5252
> description
5353
> "This revision adds the following new identities:
5454
> - bandwidth-profile-type;
@@ -58,6 +58,7 @@
5858
> - path-metric-loss.
5959
>
6060
> This revision adds the following new groupings:
61+
> - bandwidth-profile-parameters;
6162
> - te-packet-path-bandwidth;
6263
> - te-packet-link-bandwidth.
6364
>
@@ -67,7 +68,7 @@
6768
> }
6869
> // RFC Editor: replace XXXX with actual RFC number, update date
6970
> // information and remove this note
70-
61c95,201
71+
61c96,202
7172
< /**
7273
---
7374
> /*
@@ -177,112 +178,124 @@
177178
> }
178179
>
179180
> /*
180-
91c231
181+
67c208,212
182+
< enum specified {
183+
---
184+
> enum specified-value {
185+
> description
186+
> "Bandwidth value is explicitly specified.";
187+
> }
188+
> enum specified-profile {
189+
69c214
190+
< "Bandwidth is explicitly specified.";
191+
---
192+
> "Bandwidth profile is explicitly specified.";
193+
91c236
181194
< MPLS Traffic Engineering";
182195
---
183196
> MPLS Traffic Engineering";
184-
102c242
197+
102c247
185198
< MPLS Traffic Engineering";
186199
---
187200
> MPLS Traffic Engineering";
188-
149c289
201+
149c294
189202
< MPLS Traffic Engineering";
190203
---
191204
> MPLS Traffic Engineering";
192-
177,178c317,318
205+
177,178c322,323
193206
< Constraints Model for Diffserv-aware MPLS Traffic Engineering
194207
< & Performance Comparisons";
195208
---
196209
> Constraints Model for Diffserv-aware MPLS Traffic
197210
> Engineering & Performance Comparisons";
198-
180a321,324
211+
180a326,329
199212
> /*
200213
> * Groupings
201214
> */
202215
>
203-
220c364
216+
220c369
204217
< Statement, Section 4.2";
205218
---
206219
> Statement, Section 4.2";
207-
229c373
220+
229c378
208221
< Extensions
209222
---
210223
> Extensions
211-
231,232c375,376
224+
231,232c380,381
212225
< Explicitly Routed Label Switched Paths (LSPs) Using
213226
< TE Metric Extensions
214227
---
215228
> Explicitly Routed Label Switched Paths (LSPs)
216229
> Using TE Metric Extensions
217-
234c378
230+
234c383
218231
< Extensions";
219232
---
220233
> Extensions";
221-
247c391
234+
247c396
222235
< Extensions, Section 4.4";
223236
---
224237
> Extensions, Section 4.4";
225-
256c400
238+
256c405
226239
< Extensions
227240
---
228241
> Extensions
229-
258,259c402,403
242+
258,259c407,408
230243
< Explicitly Routed Label Switched Paths (LSPs) Using
231244
< TE Metric Extensions
232245
---
233246
> Explicitly Routed Label Switched Paths (LSPs)
234247
> Using TE Metric Extensions
235-
261c405
248+
261c410
236249
< Extensions";
237250
---
238251
> Extensions";
239-
283c427
252+
283c432
240253
< Extensions
241254
---
242255
> Extensions
243-
285,286c429,430
256+
285,286c434,435
244257
< Explicitly Routed Label Switched Paths (LSPs) Using
245258
< TE Metric Extensions
246259
---
247260
> Explicitly Routed Label Switched Paths (LSPs)
248261
> Using TE Metric Extensions
249-
288c432
262+
288c437
250263
< Extensions";
251264
---
252265
> Extensions";
253-
305c449
266+
305c454
254267
< Extensions
255268
---
256269
> Extensions
257-
307,308c451,452
270+
307,308c456,457
258271
< Explicitly Routed Label Switched Paths (LSPs) Using
259272
< TE Metric Extensions
260273
---
261274
> Explicitly Routed Label Switched Paths (LSPs)
262275
> Using TE Metric Extensions
263-
310c454
276+
310c459
264277
< Extensions";
265278
---
266279
> Extensions";
267-
321c465
280+
321c470
268281
< Statement, Section 4.2";
269282
---
270283
> Statement, Section 4.2";
271-
330c474
284+
330c479
272285
< Extensions
273286
---
274287
> Extensions
275-
332,333c476,477
288+
332,333c481,482
276289
< Explicitly Routed Label Switched Paths (LSPs) Using
277290
< TE Metric Extensions
278291
---
279292
> Explicitly Routed Label Switched Paths (LSPs)
280293
> Using TE Metric Extensions
281-
335c479
294+
335c484
282295
< Extensions";
283296
---
284297
> Extensions";
285-
358,363c502,508
298+
358,363c507,513
286299
< "RFC 7471: OSPF Traffic Engineering (TE) Metric Extensions
287300
< RFC 7823: Performance-Based Path Selection for
288301
< Explicitly Routed Label Switched Paths (LSPs) Using
@@ -297,7 +310,7 @@
297310
> Using TE Metric Extensions
298311
> RFC 8570: IS-IS Traffic Engineering (TE) Metric
299312
> Extensions";
300-
407a553,599
313+
407a558,604
301314
> // CHANGE NOTE: The grouping
302315
> // one-way-performance-metrics-gauge-packet has been added in
303316
> // this module revision
@@ -345,7 +358,7 @@
345358
> }
346359
> }
347360
>
348-
447a640,683
361+
447a645,688
349362
> // CHANGE NOTE: The grouping
350363
> // two-way-performance-metrics-gauge-packet has been added in
351364
> // this module revision
@@ -390,39 +403,26 @@
390403
> }
391404
> }
392405
>
393-
472a709,780
406+
472a714,844
394407
> }
395408
> }
396409
>
397-
> // CHANGE NOTE: The te-packet-path-bandwidth below has been
410+
> // CHANGE NOTE: The bandwidth-profile-parameters below has been
398411
> // added in this module revision
399412
> // RFC Editor: remove the note above and this note
400-
> grouping te-packet-path-bandwidth {
413+
> grouping bandwidth-profile-parameters {
401414
> description
402-
> "Path bandwidth for Packet. ";
403-
> leaf bandwidth-profile-name {
404-
> type string;
405-
> description
406-
> "Name of Bandwidth Profile.";
407-
> }
408-
> leaf bandwidth-profile-type {
409-
> type identityref {
410-
> base bandwidth-profile-type;
411-
> }
412-
> description
413-
> "Type of Bandwidth Profile.";
414-
> }
415+
> "Common parameters to define bandwidth profiles in packet
416+
> networks.";
415417
> leaf cir {
416418
> type uint64;
417419
> units "bits/second";
418-
> mandatory true;
419420
> description
420421
> "Committed Information Rate (CIR).";
421422
> }
422423
> leaf cbs {
423424
> type uint64;
424-
> units "bits/second";
425-
> mandatory true;
425+
> units "bytes";
426426
> description
427427
> "Committed Burst Size (CBS).";
428428
> }
@@ -455,11 +455,83 @@
455455
> // CHANGE NOTE: The te-packet-path-bandwidth below has been
456456
> // added in this module revision
457457
> // RFC Editor: remove the note above and this note
458+
> grouping te-packet-path-bandwidth {
459+
> description
460+
> "Bandwidth attributes for TE Packet paths.";
461+
> container packet-bandwidth {
462+
> description
463+
> "Bandwidth attributes for TE Packet paths.";
464+
> leaf specification-type {
465+
> type te-bandwidth-requested-type;
466+
> description
467+
> "The bandwidth specification type, either explicitly
468+
> specified or automatically computed.";
469+
> }
470+
> leaf set-bandwidth {
471+
> when "../specification-type = 'specified-value'" {
472+
> description
473+
> "When the bandwidth value is explicitly specified.";
474+
> }
475+
> type bandwidth-kbps;
476+
> description
477+
> "Set the bandwidth value explicitly, e.g., using offline
478+
> calculation.";
479+
> }
480+
> container bandwidth-profile {
481+
> when "../specification-type = 'specified-profile'" {
482+
> description
483+
> "When the bandwidth profile is explicitly specified.";
484+
> }
485+
> description
486+
> "Set the bandwidth profile attributes explicitly.";
487+
> leaf bandwidth-profile-name {
488+
> type string;
489+
> description
490+
> "Name of Bandwidth Profile.";
491+
> }
492+
> leaf bandwidth-profile-type {
493+
> type identityref {
494+
> base bandwidth-profile-type;
495+
> }
496+
> description
497+
> "Type of Bandwidth Profile.";
498+
> }
499+
> uses bandwidth-profile-parameters;
500+
> }
501+
> leaf class-type {
502+
> type te-types:te-ds-class;
503+
> description
504+
> "The Class-Type of traffic transported by the LSP.";
505+
> reference
506+
> "RFC 4124: Protocol Extensions for Support of
507+
> Diffserv-aware MPLS Traffic Engineering,
508+
> Section 4.3.1";
509+
> }
510+
> leaf signaled-bandwidth {
511+
> type te-packet-types:bandwidth-kbps;
512+
> config false;
513+
> description
514+
> "The currently signaled bandwidth of the LSP.
515+
>
516+
> In the case where the bandwidth is specified
517+
> explicitly, then this will match the value of the
518+
> set-bandwidth leaf.
519+
>
520+
> In the cases where the bandwidth is dynamically
521+
> computed by the system, the current value of the
522+
> bandwidth should be reflected.";
523+
> }
524+
> }
525+
> }
526+
>
527+
> // CHANGE NOTE: The te-packet-path-bandwidth below has been
528+
> // added in this module revision
529+
> // RFC Editor: remove the note above and this note
458530
> grouping te-packet-link-bandwidth {
459531
> description
460-
> "Link Bandwidth for Packet. ";
532+
> "Bandwidth attributes for Packet TE links.";
461533
> leaf packet-bandwidth {
462534
> type uint64;
463535
> units "bits/second";
464536
> description
465-
> "Available bandwith value.";
537+
> "Bandwidth value for Packet TE links.";

0 commit comments

Comments
 (0)