refactor: migrate to xcodeproj 9 (#147)

* Remove unused `toAny` method

* First draft of using Strogly Typed build settings in XcodeProj 9

* Fix an issue that stripped all attributes

* Update for strongly typed build settings mapping

* Update Tests for strongly typed build settings

* Finish removal of tuist specific information from build settings

* Linting

* Remove leftover test

* Update to XcodeProj 9.0

Author: waltflanagan

Package.resolved

@@ -80,7 +80,7 @@ let package = Package(
     dependencies: [
         .package(url: "https://github.com/Flight-School/AnyCodable", .upToNextMajor(from: "0.6.7")),
         .package(url: "https://github.com/tuist/Path.git", .upToNextMajor(from: "0.3.8")),
-        .package(url: "https://github.com/tuist/XcodeProj", .upToNextMajor(from: "8.27.7")),
+        .package(url: "https://github.com/tuist/XcodeProj", .upToNextMajor(from: "9.0.0")),
         .package(url: "https://github.com/tuist/Command.git", from: "0.13.0"),
         .package(url: "https://github.com/tuist/FileSystem.git", .upToNextMajor(from: "0.7.7")),
         .package(url: "https://github.com/apple/swift-service-context", .upToNextMajor(from: "1.2.0")),

Package.swift

@@ -145,19 +145,6 @@ extension [BuildConfiguration: Configuration?] {
     }
 }
 
-extension [String: SettingValue] {
-    public func toAny() -> [String: Any] {
-        mapValues { value in
-            switch value {
-            case let .array(array):
-                return array
-            case let .string(string):
-                return string
-            }
-        }
-    }
-}
-
 #if DEBUG
     extension Configuration {
         public static func test(

Sources/XcodeGraph/Models/Settings.swift

@@ -5,7 +5,7 @@ extension PBXProject {
     ///
     /// - Parameter attr: The attribute key to look up.
     /// - Returns: The value of the attribute if it exists, or `nil` if not found.
-    func attribute(for attr: ProjectAttribute) -> String? {
-        attributes[attr.rawValue] as? String
+    func attribute(for attr: ProjectAttributeKey) -> String? {
+        attributes[attr.rawValue]?.stringValue
     }
 }

Sources/XcodeGraphMapper/Extensions/PBXProject+Extensions.swift

@@ -59,7 +59,7 @@ struct PBXCopyFilesBuildPhaseMapper: PBXCopyFilesBuildPhaseMapping {
                 }
 
                 let absolutePath = try AbsolutePath(validating: pathString)
-                let attributes = buildFile.settings?.stringArray(for: .attributes)
+                let attributes = buildFile.attributes
                 let codeSignOnCopy = attributes?.contains(BuildFileAttribute.codeSignOnCopy.rawValue) ?? false
 
                 return .file(path: absolutePath, condition: nil, codeSignOnCopy: codeSignOnCopy)

Sources/XcodeGraphMapper/Mappers/Phases/PBXCopyFilesBuildPhaseMapper.swift

@@ -65,7 +65,7 @@ struct PBXFrameworksBuildPhaseMapper: PBXFrameworksBuildPhaseMapping {
         )
         if let path = fileRef.path {
             let name = path.replacingOccurrences(of: ".framework", with: "")
-            let linkingStatus: LinkingStatus = (buildFile.settings?["ATTRIBUTES"] as? [String])?
+            let linkingStatus: LinkingStatus = buildFile.attributes?
                 .contains("Weak") == true ? .optional : .required
             switch fileRef.sourceTree {
             case .buildProductsDir:

Sources/XcodeGraphMapper/Mappers/Phases/PBXFrameworksBuildPhaseMapper.swift

@@ -54,7 +54,7 @@ struct PBXHeadersBuildPhaseMapper: PBXHeadersBuildPhaseMapping {
         }
 
         let absolutePath = try AbsolutePath(validating: pathString)
-        let attributes = buildFile.settings?.stringArray(for: .attributes)
+        let attributes = buildFile.attributes
 
         let visibility: HeaderInfo.HeaderVisibility
         if attributes?.contains(HeaderAttribute.public.rawValue) == true {

Sources/XcodeGraphMapper/Mappers/Phases/PBXHeadersBuildPhaseMapper.swift

@@ -40,9 +40,8 @@ struct PBXSourcesBuildPhaseMapper: PBXSourcesBuildPhaseMapping {
         }
 
         let path = try AbsolutePath(validating: pathString)
-        let settings = buildFile.settings ?? [:]
-        let compilerFlags: String? = settings.string(for: .compilerFlags)
-        let attributes: [String]? = settings.stringArray(for: .attributes)
+        let compilerFlags: String? = buildFile.compilerFlags
+        let attributes: [String]? = buildFile.attributes
 
         return SourceFile(
             path: path,

Sources/XcodeGraphMapper/Mappers/Phases/PBXSourcesBuildPhaseMapper.swift

@@ -1,7 +1,7 @@
 import Foundation
 
 /// Attributes for project settings that can be retrieved from a `PBXProject`.
-enum ProjectAttribute: String {
+enum ProjectAttributeKey: String {
     case classPrefix = "CLASSPREFIX"
     case organization = "ORGANIZATIONNAME"
     case lastUpgradeCheck = "LastUpgradeCheck"

Sources/XcodeGraphMapper/Mappers/Project/ProjectAttribute.swift

@@ -1,22 +1,11 @@
 import Foundation
+import XcodeProj
 
 /// Keys representing various build settings that may appear in an Xcode project or workspace configuration.
 enum BuildSettingKey: String {
     case sdkroot = "SDKROOT"
-    case compilerFlags = "COMPILER_FLAGS"
-    case attributes = "ATTRIBUTES"
-    case environmentVariables = "ENVIRONMENT_VARIABLES"
     case codeSignOnCopy = "CODE_SIGN_ON_COPY"
-    case dependencyFile = "DEPENDENCY_FILE"
-    case inputPaths = "INPUT_PATHS"
-    case outputPaths = "OUTPUT_PATHS"
-    case showEnvVarsInLog = "SHOW_ENV_VARS_IN_LOG"
-    case shellPath = "SHELL_PATH"
-    case launchArguments = "LAUNCH_ARGUMENTS"
-    case tags = "TAGS"
     case mergedBinaryType = "MERGED_BINARY_TYPE"
-    case prune = "PRUNE"
-    case mergeable = "MERGEABLE"
     case productBundleIdentifier = "PRODUCT_BUNDLE_IDENTIFIER"
     case infoPlistFile = "INFOPLIST_FILE"
     case codeSignEntitlements = "CODE_SIGN_ENTITLEMENTS"
@@ -27,74 +16,8 @@ enum BuildSettingKey: String {
     case visionOSDeploymentTarget = "VISIONOS_DEPLOYMENT_TARGET"
 }
 
-/// A protocol representing a type that can parse a build setting value from a generic `Any`.
-protocol BuildSettingValue {
-    associatedtype Value
-    static func parse(_ any: Any) -> Value?
-}
-
-/// A type that parses build settings as strings.
-enum BuildSettingString: BuildSettingValue {
-    static func parse(_ any: Any) -> String? {
-        any as? String
-    }
-}
-
-/// A type that parses build settings as arrays of strings.
-enum BuildSettingStringArray: BuildSettingValue {
-    static func parse(_ any: Any) -> [String]? {
-        let arr = any as? [Any]
-        return arr?.compactMap { $0 as? String }
-    }
-}
-
-/// A type that parses build settings as booleans.
-enum BuildSettingBool: BuildSettingValue {
-    static func parse(_ any: Any) -> Bool? {
-        any as? Bool
-    }
-}
-
-/// A type that parses build settings as dictionaries of strings to strings.
-enum BuildSettingStringDict: BuildSettingValue {
-    static func parse(_ any: Any) -> [String: String]? {
-        any as? [String: String]
-    }
-}
-
-extension [String: Any] {
-    /// Extracts a build setting value of a specified type from the dictionary.
-    ///
-    /// - Parameters:
-    ///   - key: The `BuildSettingKey` to look up.
-    ///   - type: The type conforming to `BuildSettingValue` indicating the expected value type.
-    /// - Returns: The parsed value if found and valid, or `nil` otherwise.
-    func extractBuildSetting<T: BuildSettingValue>(_ key: BuildSettingKey, as _: T.Type = T.self)
-        -> T.Value?
-    {
-        guard let value = self[key.rawValue] else { return nil }
-        return T.parse(value)
-    }
-}
-
-extension [String: Any] {
-    /// Retrieves a string value for the given build setting key.
-    func string(for key: BuildSettingKey) -> String? {
-        extractBuildSetting(key, as: BuildSettingString.self)
-    }
-
-    /// Retrieves an array of strings for the given build setting key.
-    func stringArray(for key: BuildSettingKey) -> [String]? {
-        extractBuildSetting(key, as: BuildSettingStringArray.self)
-    }
-
-    /// Retrieves a boolean value for the given build setting key.
-    func bool(for key: BuildSettingKey) -> Bool? {
-        extractBuildSetting(key, as: BuildSettingBool.self)
-    }
-
-    /// Retrieves a dictionary of strings for the given build setting key.
-    func stringDict(for key: BuildSettingKey) -> [String: String]? {
-        extractBuildSetting(key, as: BuildSettingStringDict.self)
+extension BuildSettings {
+    subscript(_ key: BuildSettingKey) -> BuildSetting? {
+        self[key.rawValue]
     }
 }