From f4e15090a8b7f234e6441f91febb8ad02bb35987 Mon Sep 17 00:00:00 2001 From: Jeremy Davis Date: Mon, 1 Jun 2026 16:00:44 +1000 Subject: [PATCH 1/2] conf/turnkey.d/postfix-local: port 25 check (causes a silent error that was a PITA to debug) --- conf/turnkey.d/postfix-local | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/conf/turnkey.d/postfix-local b/conf/turnkey.d/postfix-local index 6331848f..7fdcd26e 100755 --- a/conf/turnkey.d/postfix-local +++ b/conf/turnkey.d/postfix-local @@ -1,8 +1,13 @@ #!/bin/bash -e +fatal() { "'$(basename "$0")' Error: $*" >&2; exit 1; } + if [[ ! "$HOSTNAME" ]]; then - echo "'$(basename "$0")' error: hostname not defined" - return 1 + fatal "Hostname not defined" +fi + +if ! grep -q ':25' <(ss -tlnp); then + fatal "Port 25 is already in use - must be available to set up postfix" fi postconf -e inet_interfaces=localhost From 3054a177d42ef2f34182c8b2be04d8f481a92f91 Mon Sep 17 00:00:00 2001 From: Jeremy Davis Date: Wed, 3 Jun 2026 15:08:42 +1000 Subject: [PATCH 2/2] Also fix HOSTNAME test (would work as it was but using -z is better) --- conf/turnkey.d/postfix-local | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/conf/turnkey.d/postfix-local b/conf/turnkey.d/postfix-local index 7fdcd26e..42691472 100755 --- a/conf/turnkey.d/postfix-local +++ b/conf/turnkey.d/postfix-local @@ -2,11 +2,11 @@ fatal() { "'$(basename "$0")' Error: $*" >&2; exit 1; } -if [[ ! "$HOSTNAME" ]]; then +if [[ -z "$HOSTNAME" ]]; then fatal "Hostname not defined" fi -if ! grep -q ':25' <(ss -tlnp); then +if grep -q ':25' <(ss -tlnp); then fatal "Port 25 is already in use - must be available to set up postfix" fi