From fe8898fd812e80b6858c4b2c1854d65e6a17944a Mon Sep 17 00:00:00 2001 From: Mark Otto Date: Mon, 11 Mar 2019 17:40:37 -0700 Subject: [PATCH 1/2] v5: Drop remaining deprecated mixins --- scss/_mixins.scss | 3 --- scss/mixins/_float.scss | 14 -------------- scss/mixins/_text-hide.scss | 11 ----------- scss/mixins/_visibility.scss | 8 -------- scss/utilities/_text.scss | 4 ---- 5 files changed, 40 deletions(-) delete mode 100644 scss/mixins/_float.scss delete mode 100644 scss/mixins/_text-hide.scss delete mode 100644 scss/mixins/_visibility.scss diff --git a/scss/_mixins.scss b/scss/_mixins.scss index 843303d45368..17f3cd9871e7 100644 --- a/scss/_mixins.scss +++ b/scss/_mixins.scss @@ -17,9 +17,7 @@ @import "mixins/screen-reader"; @import "mixins/reset-text"; @import "mixins/text-emphasis"; -@import "mixins/text-hide"; @import "mixins/text-truncate"; -@import "mixins/visibility"; // // Components @import "mixins/alert"; @@ -43,4 +41,3 @@ @import "mixins/clearfix"; @import "mixins/grid-framework"; @import "mixins/grid"; -@import "mixins/float"; diff --git a/scss/mixins/_float.scss b/scss/mixins/_float.scss deleted file mode 100644 index adff88e7909d..000000000000 --- a/scss/mixins/_float.scss +++ /dev/null @@ -1,14 +0,0 @@ -// stylelint-disable declaration-no-important - -@mixin float-left { - float: left !important; - @include deprecate("The `float-left` mixin", "v4.3.0", "v5"); -} -@mixin float-right { - float: right !important; - @include deprecate("The `float-right` mixin", "v4.3.0", "v5"); -} -@mixin float-none { - float: none !important; - @include deprecate("The `float-none` mixin", "v4.3.0", "v5"); -} diff --git a/scss/mixins/_text-hide.scss b/scss/mixins/_text-hide.scss deleted file mode 100644 index 3a923011ec73..000000000000 --- a/scss/mixins/_text-hide.scss +++ /dev/null @@ -1,11 +0,0 @@ -// CSS image replacement -@mixin text-hide($ignore-warning: false) { - // stylelint-disable-next-line font-family-no-missing-generic-family-keyword - font: 0/0 a; - color: transparent; - text-shadow: none; - background-color: transparent; - border: 0; - - @include deprecate("`text-hide()`", "v4.1.0", "v5", $ignore-warning); -} diff --git a/scss/mixins/_visibility.scss b/scss/mixins/_visibility.scss deleted file mode 100644 index f17467311783..000000000000 --- a/scss/mixins/_visibility.scss +++ /dev/null @@ -1,8 +0,0 @@ -// stylelint-disable declaration-no-important - -// Visibility - -@mixin invisible($visibility) { - visibility: $visibility !important; - @include deprecate("`invisible()`", "v4.3.0", "v5"); -} diff --git a/scss/utilities/_text.scss b/scss/utilities/_text.scss index 589e5687a86b..fbf707d01f4a 100644 --- a/scss/utilities/_text.scss +++ b/scss/utilities/_text.scss @@ -56,10 +56,6 @@ // Misc -.text-hide { - @include text-hide($ignore-warning: true); -} - .text-decoration-none { text-decoration: none !important; } .text-break { From 3f31a8351d0ccf61f6ad3095d52ccb6689567fdb Mon Sep 17 00:00:00 2001 From: Mark Otto Date: Wed, 13 Mar 2019 21:28:46 -0700 Subject: [PATCH 2/2] Update docs to match - Deletes mixin mentions from float docs - Deletes mixin mention from visibility docs - Deletes the image-replacement page for text-hide --- site/content/docs/4.3/utilities/float.md | 20 ----------- .../docs/4.3/utilities/image-replacement.md | 35 ------------------- site/content/docs/4.3/utilities/visibility.md | 9 ----- site/data/nav.yml | 1 - 4 files changed, 65 deletions(-) delete mode 100644 site/content/docs/4.3/utilities/image-replacement.md diff --git a/site/content/docs/4.3/utilities/float.md b/site/content/docs/4.3/utilities/float.md index 43464d614a84..bba34582831e 100644 --- a/site/content/docs/4.3/utilities/float.md +++ b/site/content/docs/4.3/utilities/float.md @@ -10,32 +10,12 @@ toc: true These utility classes float an element to the left or right, or disable floating, based on the current viewport size using the [CSS `float` property](https://developer.mozilla.org/en-US/docs/Web/CSS/float). `!important` is included to avoid specificity issues. These use the same viewport breakpoints as our grid system. Please be aware float utilities have no affect on flex items. -## Classes - -Toggle a float with a class: - {{< example >}}
Float left on all viewport sizes

Float right on all viewport sizes

Don't float on all viewport sizes
{{< /example >}} -## Mixins - -Or by Sass mixin: - -{{< highlight scss >}} -.element { - @include float-left; -} -.another-element { - @include float-right; -} -.one-more { - @include float-none; -} -{{< /highlight >}} - ## Responsive Responsive variations also exist for each `float` value. diff --git a/site/content/docs/4.3/utilities/image-replacement.md b/site/content/docs/4.3/utilities/image-replacement.md deleted file mode 100644 index e172872fa10a..000000000000 --- a/site/content/docs/4.3/utilities/image-replacement.md +++ /dev/null @@ -1,35 +0,0 @@ ---- -layout: docs -title: Image replacement -description: Swap text for background images with the image replacement class. -group: utilities ---- - -{{< callout warning >}} -##### Warning - -The `text-hide()` class and mixin has been deprecated as of v4.1. It will be removed entirely in v5. -{{< /callout >}} - -Utilize the `.text-hide` class or mixin to help replace an element's text content with a background image. - -{{< highlight html >}} -

Custom heading

-{{< /highlight >}} - -{{< highlight scss >}} -// Usage as a mixin -.heading { - @include text-hide; -} -{{< /highlight >}} - -Use the `.text-hide` class to maintain the accessibility and SEO benefits of heading tags, but want to utilize a `background-image` instead of text. - -
-

Bootstrap

-
- -{{< highlight html >}} -

Bootstrap

-{{< /highlight >}} diff --git a/site/content/docs/4.3/utilities/visibility.md b/site/content/docs/4.3/utilities/visibility.md index d7d76ecf13e2..870b11145468 100644 --- a/site/content/docs/4.3/utilities/visibility.md +++ b/site/content/docs/4.3/utilities/visibility.md @@ -22,13 +22,4 @@ Apply `.visible` or `.invisible` as needed. .invisible { visibility: hidden !important; } - -// Usage as a mixin -// Warning: The `invisible()` mixin has been deprecated as of v4.3.0. It will be removed entirely in v5. -.element { - @include invisible(visible); -} -.element { - @include invisible(hidden); -} {{< /highlight >}} diff --git a/site/data/nav.yml b/site/data/nav.yml index 664be04dad1e..324304cbd545 100644 --- a/site/data/nav.yml +++ b/site/data/nav.yml @@ -63,7 +63,6 @@ - title: Embed - title: Flex - title: Float - - title: Image replacement - title: Overflow - title: Position - title: Screen readers