fix(gateway): align list sort and window semantics

Author: albertywu

submitqueue/extension/storage/mysql/request_summary_store.go

@@ -133,7 +133,7 @@ func (s *requestSummaryStore) List(ctx context.Context, opts storage.RequestSumm
 	clauses := []string{
 		"queue = ?",
 		"started_at_ms < ?",
-		"completed_at_ms >= ?",
+		"completed_at_ms > ?",
 	}
 
 	if len(opts.Statuses) > 0 {

submitqueue/gateway/controller/list.go

@@ -217,9 +217,9 @@ func canonicalStatuses(raw []string) ([]entity.RequestStatus, error) {
 
 func requestSummarySort(sort pb.ListSort) (storage.RequestSummarySort, error) {
 	switch sort {
-	case pb.ListSort_LIST_SORTED_UNSPECIFIED, pb.ListSort_LIST_SORTED_ADMITTED_ASC:
+	case pb.ListSort_SORT_DEFAULT, pb.ListSort_ADMITTED_ASC:
 		return storage.RequestSummarySortAdmittedAsc, nil
-	case pb.ListSort_LIST_SORTED_ADMITTED_DESC:
+	case pb.ListSort_ADMITTED_DESC:
 		return storage.RequestSummarySortAdmittedDesc, nil
 	default:
 		return "", fmt.Errorf("unknown sort %v: %w", sort, ErrInvalidRequest)

submitqueue/gateway/controller/list_test.go

@@ -108,7 +108,7 @@ func TestList_UsesRequestedSort(t *testing.T) {
 		Queue:       "q",
 		StartTimeMs: 100,
 		EndTimeMs:   200,
-		Sort:        pb.ListSort_LIST_SORTED_ADMITTED_DESC,
+		Sort:        pb.ListSort_ADMITTED_DESC,
 	})
 
 	require.NoError(t, err)
@@ -278,7 +278,7 @@ func TestList_RejectsMismatchedPageTokenSort(t *testing.T) {
 		Queue:       "q",
 		StartTimeMs: 1,
 		EndTimeMs:   2,
-		Sort:        pb.ListSort_LIST_SORTED_ADMITTED_ASC,
+		Sort:        pb.ListSort_ADMITTED_ASC,
 		PageToken:   token,
 	})
 

submitqueue/gateway/proto/gateway.proto

@@ -128,12 +128,12 @@ message StatusResponse {
 
 // ListSort defines supported deterministic orderings for List.
 enum ListSort {
-    // Server default: LIST_SORTED_ADMITTED_ASC.
-    LIST_SORTED_UNSPECIFIED = 0;
+    // Server default: ADMITTED_ASC.
+    SORT_DEFAULT = 0;
     // FIFO/admission order.
-    LIST_SORTED_ADMITTED_ASC = 1;
+    ADMITTED_ASC = 1;
     // Newest admissions first.
-    LIST_SORTED_ADMITTED_DESC = 2;
+    ADMITTED_DESC = 2;
 }
 
 // ListRequest defines a request to list queue requests whose lifecycles overlap a time window.