removed validator

Author: ubettigole

submitqueue/extension/changeprovider/phabricator/BUILD.bazel

@@ -6,7 +6,6 @@ go_library(
         "conduit.go",
         "convert.go",
         "provider.go",
-        "validate.go",
     ],
     importpath = "github.com/uber/submitqueue/submitqueue/extension/changeprovider/phabricator",
     visibility = ["//visibility:public"],
@@ -26,7 +25,6 @@ go_test(
         "conduit_test.go",
         "convert_test.go",
         "provider_test.go",
-        "validate_test.go",
     ],
     embed = [":phabricator"],
     deps = [

submitqueue/extension/changeprovider/phabricator/provider.go

@@ -67,10 +67,6 @@ func (p *provider) Get(ctx context.Context, request entity.Request) (_ []entity.
 		"uris", change.URIs,
 	)
 
-	if err := validateChangeConsistency(changeIDs); err != nil {
-		return nil, err
-	}
-
 	diffs, err := p.fetchAllDiffs(ctx, changeIDs)
 	if err != nil {
 		return nil, err
@@ -79,11 +75,6 @@ func (p *provider) Get(ctx context.Context, request entity.Request) (_ []entity.
 	changeInfos := make([]entity.ChangeInfo, 0, len(changeIDs))
 	for _, cid := range changeIDs {
 		diff := diffs[cid.DiffID]
-
-		if err := validateDiffResponse(cid.DiffID, diff); err != nil {
-			return nil, err
-		}
-
 		changeInfo := convertToChangeInfo(cid, diff)
 		changeInfos = append(changeInfos, changeInfo)
 

submitqueue/extension/changeprovider/phabricator/provider_test.go

@@ -67,28 +67,6 @@ func TestProvider_Get(t *testing.T) {
 			uris:    []string{"phab://D200/100"},
 			wantErr: "Conduit API returned status 500",
 		},
-		{
-			name: "diff with no changes returns error",
-			handler: func(w http.ResponseWriter, r *http.Request) {
-				serveConduit(t, w, map[string]*diffResult{
-					"100": {
-						Changes: []fileChange{},
-					},
-				})
-			},
-			uris:    []string{"phab://D200/100"},
-			wantErr: "diff 100 has no file changes",
-		},
-		{
-			name:    "duplicate revision returns error",
-			uris:    []string{"phab://D200/100", "phab://D200/101"},
-			wantErr: "duplicate revision D200",
-		},
-		{
-			name:    "duplicate diff returns error",
-			uris:    []string{"phab://D200/100", "phab://D201/100"},
-			wantErr: "duplicate diff 100",
-		},
 	}
 
 	for _, tc := range testCases {