test: pendingCloudResync flag suppresses upgrade conflict text

tests that toggling local-saves-only off results in generic conflict
text, while an app update results in upgrade-specific text. uses real
Robolectric-backed DataStore instead of mock.

Author: jeremybernstein

app/src/test/java/app/gamenative/service/SteamAutoCloudTest.kt

@@ -3,6 +3,7 @@ package app.gamenative.service
 import android.content.Context
 import androidx.room.Room
 import androidx.test.core.app.ApplicationProvider
+import app.gamenative.PrefManager
 import app.gamenative.data.ConfigInfo
 import app.gamenative.data.FileChangeLists
 import app.gamenative.data.PostSyncInfo
@@ -25,6 +26,7 @@ import `in`.dragonbra.javasteam.steam.handlers.steamcloud.SteamCloud
 import `in`.dragonbra.javasteam.steam.handlers.steamcloud.FileDownloadInfo
 import `in`.dragonbra.javasteam.steam.steamclient.configuration.SteamConfiguration
 import app.gamenative.enums.SyncResult
+import app.gamenative.utils.CURRENT_UFS_PARSE_VERSION
 import `in`.dragonbra.javasteam.util.crypto.CryptoHelper
 import kotlinx.coroutines.runBlocking
 import okhttp3.Call
@@ -69,6 +71,10 @@ class SteamAutoCloudTest {
     @Before
     fun setUp() {
         context = ApplicationProvider.getApplicationContext()
+
+        // PrefManager uses a real Robolectric-backed DataStore so pendingCloudResync persists
+        PrefManager.init(context)
+
         tempDir = File.createTempFile("steam_autocloud_test_", null)
         tempDir.delete()
         tempDir.mkdirs()
@@ -234,6 +240,8 @@ class SteamAutoCloudTest {
 
     @After
     fun tearDown() {
+        PrefManager.pendingCloudResync = emptySet()
+
         // Clean up ImageFs directory first (files created in wineprefix)
         // This is critical because ImageFs uses context.getFilesDir() which is inside Robolectric's temp directory
         try {
@@ -2052,5 +2060,72 @@ class SteamAutoCloudTest {
         assertEquals(SyncResult.Success, result!!.syncResult)
         assertTrue("Should have downloaded files", result.filesDownloaded > 0)
     }
+
+    // ── Scenario 14: pendingCloudResync flag suppresses upgrade conflict text ──
+    // When local-saves-only is toggled off, the cache is cleared and the appId is added
+    // to pendingCloudResync. The conflict should still fire, but conflictUfsVersion
+    // should be null (generic text, not upgrade-specific).
+    @Test
+    fun cacheCleared_pendingResync_conflictWithoutUpgradeText() = runBlocking {
+        db.appChangeNumbersDao().deleteByAppId(steamAppId)
+        db.appFileChangeListsDao().deleteByAppId(steamAppId)
+        assertTrue("Precondition: local save files exist", saveFilesDir.listFiles()!!.isNotEmpty())
+
+        // simulate local-saves toggle-off: appId in pendingCloudResync
+        PrefManager.pendingCloudResync = setOf(steamAppId)
+
+        every { mockSteamCloud.getAppFileListChange(any(), any(), any()) } returns
+            CompletableFuture.completedFuture(makeCloudFileChangeList(cloudChangeNumber = 5))
+
+        val testApp = db.steamAppDao().findApp(steamAppId)!!
+        val result = SteamAutoCloud.syncUserFiles(
+            appInfo = testApp,
+            clientId = clientId,
+            steamInstance = mockSteamService,
+            steamCloud = mockSteamCloud,
+            preferredSave = SaveLocation.None,
+            prefixToPath = makePrefixToPath(),
+        ).await()
+
+        assertNotNull(result)
+        assertEquals("Should still be Conflict", SyncResult.Conflict, result!!.syncResult)
+        assertNull(
+            "conflictUfsVersion should be null — generic text, not upgrade",
+            result.conflictUfsVersion,
+        )
+    }
+
+    // ── Scenario 15: Without pendingCloudResync, conflict sets conflictUfsVersion ──
+    // Same setup as scenario 14 but without the flag — should get upgrade text.
+    @Test
+    fun cacheCleared_noPendingResync_conflictWithUpgradeText() = runBlocking {
+        db.appChangeNumbersDao().deleteByAppId(steamAppId)
+        db.appFileChangeListsDao().deleteByAppId(steamAppId)
+        assertTrue("Precondition: local save files exist", saveFilesDir.listFiles()!!.isNotEmpty())
+
+        // no pendingCloudResync flag
+        PrefManager.pendingCloudResync = emptySet()
+
+        every { mockSteamCloud.getAppFileListChange(any(), any(), any()) } returns
+            CompletableFuture.completedFuture(makeCloudFileChangeList(cloudChangeNumber = 5))
+
+        val testApp = db.steamAppDao().findApp(steamAppId)!!
+        val result = SteamAutoCloud.syncUserFiles(
+            appInfo = testApp,
+            clientId = clientId,
+            steamInstance = mockSteamService,
+            steamCloud = mockSteamCloud,
+            preferredSave = SaveLocation.None,
+            prefixToPath = makePrefixToPath(),
+        ).await()
+
+        assertNotNull(result)
+        assertEquals("Should be Conflict", SyncResult.Conflict, result!!.syncResult)
+        assertEquals(
+            "conflictUfsVersion should be set for upgrade text",
+            CURRENT_UFS_PARSE_VERSION,
+            result.conflictUfsVersion,
+        )
+    }
 }