fix[backend](rules): removed modifications on legacy rule schema as it does not have correlation param

Author: AlexSanchez-bit

backend/modules/eventprocessing/domain/correlation_rule.go

@@ -1,7 +1,6 @@
 package domain
 
 import (
-	"fmt"
 	"time"
 )
 
@@ -31,10 +30,10 @@ type UtmCorrelationRules struct {
 	SystemOwner    bool       `gorm:"column:system_owner;not null"`
 
 	// Nullable JSON TEXT columns for advanced rule configuration.
-	//[deprecated] only keeped for compatibility
+	//[deprecated] only kept for compatibility
 	AfterEventsDef   string `gorm:"column:rule_after_events_def"`
 	//
-	CorrelationDef   string `gorm:"column:rule_correlation_def"`
+
 	RuleGroupByDef   string `gorm:"column:rule_group_by_def"`
 	DeduplicateByDef string `gorm:"column:rule_deduplicate_by_def"`
 
@@ -44,16 +43,5 @@ type UtmCorrelationRules struct {
 	DataTypes []UtmDataTypes `gorm:"many2many:utm_group_rules_data_type;joinForeignKey:rule_id;joinReferences:data_type_id"`
 }
 
-func (self *UtmCorrelationRules) GetCorrelationDef() (string,error){
-	var correlate string
-	if self.AfterEventsDef!="" && self.CorrelationDef !=""{
-		return "",fmt.Errorf("only one afterEvents or correlation allowed")
-	}else if self.AfterEventsDef!="" {
-		correlate = self.AfterEventsDef
-	}else{
-		correlate= self.CorrelationDef
-	}
-	return correlate,nil
-}
 
 func (UtmCorrelationRules) TableName() string { return "utm_correlation_rules" }

backend/modules/eventprocessing/dto/correlation_rule.go

@@ -26,7 +26,7 @@ type RuleDataTypeResponse struct {
 
 
 type CorrelationOwner struct{
-	//[deprecated] only keeped for compatibility
+	//[deprecated] only kept for compatibility
 	AfterEventsDef    json.RawMessage `json:"afterEvents"`
 	//
 	CorrelationDef    json.RawMessage `json:"correlation"`

backend/modules/eventprocessing/usecase/rule_bootstrap.go

@@ -265,14 +265,6 @@ func legacyToRule(row *domain.UtmCorrelationRules) Rule {
 		names = append(names, dt.DataType)
 	}
 
-	correlation,err:=row.GetCorrelationDef()
-	if err!=nil{
-		catcher.Error("skipping invalid after events of rule, %s",err,map[string]any{
-			"rule":row.RuleName,
-			"afterEvents":row.AfterEventsDef,
-			"correlation":row.CorrelationDef,
-		})
-	}
 
 	return Rule{
 		Name:          row.RuleName,
@@ -284,7 +276,7 @@ func legacyToRule(row *domain.UtmCorrelationRules) Rule {
 		Impact:        Impact{Confidentiality: row.RuleConfidentiality, Integrity: row.RuleIntegrity, Availability: row.RuleAvailability},
 		Where:         rawToWhere(toRaw(row.RuleDefinitionDef)),
 		References:    rawToAnySlice(toRaw(row.RuleReferencesDef)),
-		Correlation:   rawToAny(toRaw(correlation)),
+		Correlation:   rawToAny(toRaw(row.AfterEventsDef)),
 		GroupBy:       rawToStrSlice(toRaw(row.RuleGroupByDef)),
 		DeduplicateBy: rawToStrSlice(toRaw(row.DeduplicateByDef)),
 	}