Skip to content

Commit d003679

Browse files
fix(rule_management): fixed empty after event form on rule update
1 parent 1ac2988 commit d003679

4 files changed

Lines changed: 13 additions & 1 deletion

File tree

frontend/src/app/rule-management/app-rule/components/add-after-event/add-after-event.component.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,7 @@
5959
(change)="onFieldChange($event, j)"
6060
formControlName="field"
6161
[items]="fields"
62+
[addTag]="addField"
6263
bindLabel="name"
6364
bindValue="name"
6465
class="w-100"

frontend/src/app/rule-management/app-rule/components/add-after-event/add-after-event.component.ts

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,6 +129,13 @@ export class AddAfterEventComponent implements OnInit {
129129

130130
getOperatorByField(fieldName: string) {
131131
const field = this.fields.find(f => f.name === fieldName);
132-
return this.getOperators(field);
132+
//if the field doesnt appear on field list, it must be an added field ( so we'll treat it like a STRING)
133+
return this.getOperators(field || {name:fieldName,type:ElasticDataTypesEnum.STRING});
133134
}
135+
136+
addField(name:string){
137+
return {name,type:ElasticDataTypesEnum.STRING};
138+
}
139+
140+
134141
}

frontend/src/app/rule-management/app-rule/components/add-rule/add-rule.component.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,10 @@ export class AddRuleComponent implements OnInit, OnDestroy {
182182
});
183183
// this.savedVariables = rule ? rule.definition.ruleVariables : [];
184184

185+
if(!rule || rule.afterEvents.length == 0){
185186
this.addAfterEvent();
187+
}
188+
186189
}
187190

188191

frontend/src/app/rule-management/app-rule/components/deduplicate-fields/deduplicate-fields.component.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ export class DeduplicateFieldsComponent implements OnInit {
3838
}
3939

4040
addTag(name: string) {
41+
alert(name)
4142
return { name };
4243
}
4344
}

0 commit comments

Comments
 (0)