feat[updater](): disable log sender after send logs - exlude backend down errors

Kbayero · Kbayero · commit e8faeef8035d · 2025-09-10T11:05:38.000-04:00
diff --git a/installer/updater/backend.go b/installer/updater/backend.go
@@ -5,11 +5,32 @@ import (
 	"encoding/json"
 	"fmt"
 	"net/http"
+	"strings"
 
 	"github.com/utmstack/UTMStack/installer/config"
 	"github.com/utmstack/UTMStack/installer/utils"
 )
 
+// IsBackendMaintenanceError checks if the error is due to backend being unavailable (maintenance or down)
+func IsBackendMaintenanceError(err error) bool {
+	if err == nil {
+		return false
+	}
+	errStr := err.Error()
+	// Check for common signs of backend being unavailable
+	return (strings.Contains(errStr, "<!DOCTYPE html") || 
+		strings.Contains(errStr, "<html>") ||
+		strings.Contains(errStr, "invalid character '<'") ||
+		strings.Contains(errStr, "UTMStack - Maintenance") ||
+		strings.Contains(errStr, "currently under maintenance") ||
+		strings.Contains(errStr, "502 Bad Gateway") ||
+		strings.Contains(errStr, "503 Service Unavailable") ||
+		strings.Contains(errStr, "504 Gateway Timeout")) ||
+		(strings.Contains(errStr, "status code: 502") || 
+		 strings.Contains(errStr, "status code: 503") ||
+		 strings.Contains(errStr, "status code: 504"))
+}
+
 func getConfigFromBackend(id uint) ([]ConfigBackend, error) {
 	transCfg := &http.Transport{
 		TLSClientConfig: &tls.Config{InsecureSkipVerify: true},
diff --git a/installer/updater/logprocessor.go b/installer/updater/logprocessor.go
@@ -35,7 +35,9 @@ func SyncSystemLogs() {
 
 		active, err := isLogSenderEnabled()
 		if err != nil {
-			config.Logger().ErrorF("Error getting log sender config: %v", err)
+			if !IsBackendMaintenanceError(err) {
+				config.Logger().ErrorF("Error getting log sender config: %v", err)
+			}
 		}
 
 		if !config.Updating && active {
@@ -51,9 +53,37 @@ func SyncSystemLogs() {
 	}
 }
 
+func disableLogSender() error {
+	backConf, err := getConfigFromBackend(9)
+	if err != nil {
+		if IsBackendMaintenanceError(err) {
+			return nil
+		}
+		return err
+	}
+	for i, c := range backConf {
+		if c.ConfParamShort == "utmstack.intance.send.logs" {
+			backConf[i].ConfParamValue = "false"
+		}
+	}
+
+	err = updateConfigInBackend(backConf, 9)
+	if err != nil {
+		if IsBackendMaintenanceError(err) {
+			return nil
+		}
+		return fmt.Errorf("error disabling log sender in backend: %v", err)
+	}
+
+	return nil
+}
+
 func isLogSenderEnabled() (bool, error) {
 	backConf, err := getConfigFromBackend(9)
 	if err != nil {
+		if IsBackendMaintenanceError(err) {
+			return false, nil
+		}
 		return false, err
 	}
 
@@ -92,6 +122,11 @@ func CollectAndShipSwarmLogs() error {
 		_ = os.Remove(archiveName)
 	}
 
+	err = disableLogSender()
+	if err != nil {
+		return fmt.Errorf("error disabling log sender: %v", err)
+	}
+
 	return nil
 }
 
diff --git a/installer/updater/window.go b/installer/updater/window.go
@@ -13,7 +13,11 @@ func UpdateWindowConfig() {
 	for {
 		window, err := getWindowMaintaince()
 		if err != nil {
-			config.Logger().ErrorF("Error getting maintenance window config: %v", err)
+			// Only log error if it's not a maintenance error
+			if !IsBackendMaintenanceError(err) {
+				config.Logger().ErrorF("Error getting maintenance window config: %v", err)
+			}
+			// If backend is in maintenance, just skip this iteration silently
 		}
 
 		if window != "" {
