Large keys seem to crash Valkey-admin

[madolson]

If you create a single large item, and then try to click on it, there is a chance that it will just hang and crash:

Script to fill the node:

cat > /tmp/create_large_hash.sh << 'EOF'
#!/bin/bash
echo "Creating hash with 5 million items..."
echo "This will take a few minutes..."

# Use pipeline for better performance
for i in $(seq 0 49); do
  echo "Batch $((i+1))/50 (100k items)..."
  (
    for j in $(seq 1 100000); do
      field_num=$((i * 100000 + j))
      echo "HSET large_hash field_${field_num} value_${field_num}"
    done
  ) | valkey-cli -a testing --pipe 2>/dev/null
done

echo "Done! Checking hash size..."
valkey-cli -a testing HLEN large_hash 2>/dev/null
EOF
chmod +x /tmp/create_large_hash.sh
/tmp/create_large_hash.sh

It seems like we are doing an HGETALL.

Sad_Valkey_admin_low.mov

[Amitgb14]

Issue are easily reproducible and yes HGETALL cause this crash, recommended to use HSCAN or skip HGETALL for hash dataset.

[ArgusLi]

This issue is by and large resolved by #231. By setting max key size to 2KB, the command retrieving the key is not as important, as blocking commands for a 2KB key does not lead to a significant performance decrease.

However, we are working on replacing key fetching commands as well, starting with Hash and Set commands which have been replaced in #232.