From 4de3f8736d1f28f86e8f329c9b3bc0b80f67e491 Mon Sep 17 00:00:00 2001 From: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Date: Mon, 13 Apr 2026 17:57:45 +0000 Subject: [PATCH 1/4] chore: add measurable impact verification to PR and issue templates Co-Authored-By: Stanislau --- .github/ISSUE_TEMPLATE/bug_report.yml | 14 +++++++++++++ .github/ISSUE_TEMPLATE/feature_request.yml | 14 +++++++++++++ .github/ISSUE_TEMPLATE/task.yml | 14 +++++++++++++ .github/pull_request_template.md | 23 ++++++++++++++++++++++ 4 files changed, 65 insertions(+) diff --git a/.github/ISSUE_TEMPLATE/bug_report.yml b/.github/ISSUE_TEMPLATE/bug_report.yml index 7f10d85..ee5ef60 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.yml +++ b/.github/ISSUE_TEMPLATE/bug_report.yml @@ -70,6 +70,20 @@ body: validations: required: false + - type: textarea + id: impact + attributes: + label: Measurable impact of the fix + description: | + How will we verify the bug is fixed? Provide at least one measurable criterion and a command or method to check it. + Example: "Exit code of `bun run cli -- query --question '...'`: before 1 → after 0" + placeholder: | + | Metric | Before (broken) | After (fixed) | How to measure | + |--------|-----------------|---------------|----------------| + | | | | | + validations: + required: true + - type: textarea id: context attributes: diff --git a/.github/ISSUE_TEMPLATE/feature_request.yml b/.github/ISSUE_TEMPLATE/feature_request.yml index eb1b7ee..622ee52 100644 --- a/.github/ISSUE_TEMPLATE/feature_request.yml +++ b/.github/ISSUE_TEMPLATE/feature_request.yml @@ -41,6 +41,20 @@ body: validations: required: true + - type: textarea + id: impact + attributes: + label: Measurable impact + description: | + How will we know this feature works? List at least one metric with a before/after target and a command or method to measure it. + Example: "MCP tool count: before 8 → after 10. Measure: count tools in `src/mcp/tools.ts`" + placeholder: | + | Metric | Before | After (target) | How to measure | + |--------|--------|----------------|----------------| + | | | | | + validations: + required: true + - type: textarea id: alternatives attributes: diff --git a/.github/ISSUE_TEMPLATE/task.yml b/.github/ISSUE_TEMPLATE/task.yml index 007adef..93dbfb2 100644 --- a/.github/ISSUE_TEMPLATE/task.yml +++ b/.github/ISSUE_TEMPLATE/task.yml @@ -59,6 +59,20 @@ body: validations: required: false + - type: textarea + id: impact + attributes: + label: Measurable impact + description: | + How will we verify the impact of this task? List at least one metric with a before/after target and a reproducible measurement command. + Example: "LOC in compiler.ts: before 1509 → after ≤300. Measure: `wc -l src/runtime/compiler.ts`" + placeholder: | + | Metric | Before | After (target) | How to measure | + |--------|--------|----------------|----------------| + | | | | | + validations: + required: true + - type: dropdown id: agent_delegable attributes: diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 74b11a9..fbaeb6d 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -18,6 +18,29 @@ +## Impact verification + + + +| Metric | Before | After | How to measure | +|--------|--------|-------|----------------| +| | | | | + + + ## Validation - [ ] `bun run lint` passes locally From 387896956b18ba1e120507d1ca036713d4a53a4f Mon Sep 17 00:00:00 2001 From: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Date: Mon, 13 Apr 2026 18:00:13 +0000 Subject: [PATCH 2/4] fix: update template examples with accurate codebase metrics Co-Authored-By: Stanislau --- .github/ISSUE_TEMPLATE/feature_request.yml | 2 +- .github/ISSUE_TEMPLATE/task.yml | 2 +- .github/pull_request_template.md | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/feature_request.yml b/.github/ISSUE_TEMPLATE/feature_request.yml index 622ee52..1f422b7 100644 --- a/.github/ISSUE_TEMPLATE/feature_request.yml +++ b/.github/ISSUE_TEMPLATE/feature_request.yml @@ -47,7 +47,7 @@ body: label: Measurable impact description: | How will we know this feature works? List at least one metric with a before/after target and a command or method to measure it. - Example: "MCP tool count: before 8 → after 10. Measure: count tools in `src/mcp/tools.ts`" + Example: "MCP tool count: before 10 → after 12. Measure: `grep -c createTool src/mcp/tools.ts`" placeholder: | | Metric | Before | After (target) | How to measure | |--------|--------|----------------|----------------| diff --git a/.github/ISSUE_TEMPLATE/task.yml b/.github/ISSUE_TEMPLATE/task.yml index 93dbfb2..91e02c6 100644 --- a/.github/ISSUE_TEMPLATE/task.yml +++ b/.github/ISSUE_TEMPLATE/task.yml @@ -65,7 +65,7 @@ body: label: Measurable impact description: | How will we verify the impact of this task? List at least one metric with a before/after target and a reproducible measurement command. - Example: "LOC in compiler.ts: before 1509 → after ≤300. Measure: `wc -l src/runtime/compiler.ts`" + Example: "LOC in query-engine.ts: before 1614 → after ≤1200. Measure: `wc -l src/runtime/query-engine.ts`" placeholder: | | Metric | Before | After (target) | How to measure | |--------|--------|----------------|----------------| diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index fbaeb6d..ed40e37 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -24,7 +24,7 @@ | Metric | Before | After | How to measure | |--------|--------|-------|----------------| -| | | | | +| | | | | | | | | +| | | | |