From 6216f3ef69ec62737902cb5c7670de11f68218c1 Mon Sep 17 00:00:00 2001 From: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Date: Mon, 13 Apr 2026 19:05:43 +0000 Subject: [PATCH 1/2] chore: add required measurable impact verification to issue and PR templates Co-Authored-By: Stanislau --- .github/ISSUE_TEMPLATE/bug_report.yml | 15 +++++++++++++++ .github/ISSUE_TEMPLATE/feature_request.yml | 15 +++++++++++++++ .github/ISSUE_TEMPLATE/task.yml | 15 +++++++++++++++ .github/pull_request_template.md | 9 +++++++++ 4 files changed, 54 insertions(+) diff --git a/.github/ISSUE_TEMPLATE/bug_report.yml b/.github/ISSUE_TEMPLATE/bug_report.yml index 7f10d85..15ac75a 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.yml +++ b/.github/ISSUE_TEMPLATE/bug_report.yml @@ -70,6 +70,21 @@ body: validations: required: false + - type: textarea + id: impact + attributes: + label: Measurable impact verification + description: | + How will we verify the fix works and measure its impact? Provide a table with concrete metrics. + Every metric must be quantifiable — no vague criteria like "works better" or "improved". + placeholder: | + | Metric | Before (broken) | After (target) | How to measure | + |--------|-----------------|----------------|----------------| + | Error on query X | throws TypeError | returns valid answer | `bun run cli -- query --question "X"` | + | Test pass rate | 38/39 (1 failure) | 39/39 | `bun run test` | + validations: + required: true + - type: textarea id: context attributes: diff --git a/.github/ISSUE_TEMPLATE/feature_request.yml b/.github/ISSUE_TEMPLATE/feature_request.yml index eb1b7ee..eefd91e 100644 --- a/.github/ISSUE_TEMPLATE/feature_request.yml +++ b/.github/ISSUE_TEMPLATE/feature_request.yml @@ -41,6 +41,21 @@ body: validations: required: true + - type: textarea + id: impact + attributes: + label: Measurable impact verification + description: | + How will we verify the feature works and measure its impact? Provide a table with concrete metrics. + Every metric must be quantifiable — no vague criteria like "works better" or "improved". + placeholder: | + | Metric | Before | After (target) | How to measure | + |--------|--------|----------------|----------------| + | New MCP tools available | 0 | 2 | `grep -c createTool src/mcp/tools.ts` | + | Test coverage for feature | 0 tests | ≥5 tests | `bun run test` | + validations: + required: true + - type: textarea id: alternatives attributes: diff --git a/.github/ISSUE_TEMPLATE/task.yml b/.github/ISSUE_TEMPLATE/task.yml index 007adef..32c8909 100644 --- a/.github/ISSUE_TEMPLATE/task.yml +++ b/.github/ISSUE_TEMPLATE/task.yml @@ -59,6 +59,21 @@ body: validations: required: false + - type: textarea + id: impact + attributes: + label: Measurable impact verification + description: | + How will we verify the task is complete and measure its impact? Provide a table with concrete metrics. + Every metric must be quantifiable — no vague criteria like "works better" or "improved". + placeholder: | + | Metric | Before | After (target) | How to measure | + |--------|--------|----------------|----------------| + | LOC in target file | 1614 | ≤400 | `wc -l src/runtime/target.ts` | + | Existing test pass rate | all pass | all pass | `bun run test` | + validations: + required: true + - type: dropdown id: agent_delegable attributes: diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 74b11a9..e7d9ea6 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -18,6 +18,15 @@ +## Measurable impact verification + + + +| Metric | Before | After (target) | How to measure | +|--------|--------|----------------|----------------| +| | | | | + ## Validation - [ ] `bun run lint` passes locally From adbd24e0841c0627f7e6abb4c348735b8a36df8a Mon Sep 17 00:00:00 2001 From: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Date: Mon, 13 Apr 2026 19:11:37 +0000 Subject: [PATCH 2/2] fix: correct placeholder example in feature request template per Copilot review Co-Authored-By: Stanislau --- .github/ISSUE_TEMPLATE/feature_request.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/feature_request.yml b/.github/ISSUE_TEMPLATE/feature_request.yml index eefd91e..66d4d77 100644 --- a/.github/ISSUE_TEMPLATE/feature_request.yml +++ b/.github/ISSUE_TEMPLATE/feature_request.yml @@ -51,8 +51,8 @@ body: placeholder: | | Metric | Before | After (target) | How to measure | |--------|--------|----------------|----------------| - | New MCP tools available | 0 | 2 | `grep -c createTool src/mcp/tools.ts` | - | Test coverage for feature | 0 tests | ≥5 tests | `bun run test` | + | Total MCP tool definitions | 10 | 12 | `grep -c createTool src/mcp/tools.ts` | + | Feature test cases added | 0 | ≥5 | `grep -Ec '\b(it|test)\(' tests/feature.test.ts` | validations: required: true