Skip to content

Adding Endpoint for Zone Details in vinyldns-cli#109

Merged
arpit4ever merged 19 commits into
vinyldns:mainfrom
ssranjani06:zoneDetailsPR
Dec 23, 2025
Merged

Adding Endpoint for Zone Details in vinyldns-cli#109
arpit4ever merged 19 commits into
vinyldns:mainfrom
ssranjani06:zoneDetailsPR

Conversation

@ssranjani06
Copy link
Copy Markdown
Collaborator

A user has brought up a shortcoming of the VinylDNS CLI: If you have the ID of a private zone (from the output of another Vinyl CLI command), and you are not part of the zone's admin group, there is no CLI command to retrieve the zone name. Running vinyldns zone --zone-id ${ZONE_ID} will return a 403 user cannot access zone error. While this is valid, since viewing the contents of private zones is restricted to zone owners, accessing the general zone info is permitted. The API endpoint for that would be GET /zones/{zone_id}/details.

curl --aws-sigv4 "aws:amz:us-east-1:execute-api" --user "${VINYLDNS_ACCESS_KEY}:${VINYLDNS_SECRET_KEY}" "${VINYLDNS_HOST}/zones/d7e433df-ad84-4fbe-9f52-3b2f3665412a/details"
{"zone":{"name":"dummy.","email":"testing@test.com","status":"Active","adminGroupId":"9945e0c5-41dd-42e9-a053-3f4dacf006c3","adminGroupName":"dummy-group"}}

Currently, the VinylDNS CLI does not offer a command for this API.

@snyk-io
Copy link
Copy Markdown

snyk-io Bot commented Oct 27, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@ssranjani06 ssranjani06 self-assigned this Dec 3, 2025
Comment thread src/zones_helpers.go
Comment thread src/cli.go Outdated
Copy link
Copy Markdown
Member

@nspadaccino nspadaccino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple comments requesting changes

Copy link
Copy Markdown

@arpit4ever arpit4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments.

Comment thread go.mod Outdated
Comment thread src/cli.go Outdated
Copy link
Copy Markdown
Member

@nspadaccino nspadaccino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown

@arpit4ever arpit4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arpit4ever arpit4ever merged commit f9d1709 into vinyldns:main Dec 23, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants