Working

[fidelix]

Is it working?
When do you expect to have some instructions about how to use it?

Thanks!

As far as I know it's working (I haven't used it in a long time).

I'll whip up some docs when I've got a few moments spare - hopefully in the next week or so.

[fidelix]

Thanks, simpl.
In the meantime, can you leave a configuration example here? Might help someone who's desperate about this.

Hope this helps. Have a look in the source for other similar options (note GeoIP and POST aren't yet supported). I may well add them at some point, but I have no idea when.

# this config uses first the GET argument 'lang', then the cookie 'lang' and then the Accept-Lang HTTP header
# to set the language of the page, from a list of English, French and German.

set_lang_method  get cookie accept_lang;  # sets the lang based on these in order (see ngx_http_set_lang_methods in source) 
lang_cookie  lang;  # stores the lang in cookie 'lang'
lang_get_var  lang;  # sets the lang based on this URL argument
lang_list  en fr de;  # chooses the language of the page in this order (based on e.g. accept_lang)

[wolph]

Perhaps you would like to merge in my changes? My version has some docs and a few added features and bugfixes.

https://github.com/WoLpH/ngx_http_set_lang

[fidelix]

Right now I'm using ngx_http_set_lang from @wolph for a project, and it's working well.
Merging this effort might be a good idea ^^. Count with me for testing.

@wolph - I had a quick look at your changes. Yes, I'll merge most of them. However, the implementation of ngx_http_set_lang_from_default doesn't look right to me, though. Firstly, it seems you're returning the last language in the list, not the first one. Secondly (as an efficiency issue, should we actually want the last element in the list, not the first), you shouldn't do a loop to get the last element in a list, you should use pointer addition - i.e.

lang = ((ngx_str_t *) conf->langs->elts) + (conf->langs->nelts - 1) ;

Just deleting lines 448, 451 and 452 in your version of ngx_http_set_lang_module.c will give the correct version, I believe, unless I'm having a mental breakdown :-).

Also, it would probably be better to remove the info about POST and GeoIP for now from the docs (and I'll do the same on mine too). Neither of them have been implemented yet, and it's probably best not to confuse the end users.

After making the above edit, send me a pull request if you like.

Thanks.

[wolph]

Haha, yeah... that code isn't as pretty as it should be. That's what you get when you change some code, refactor some stuff and forget to do one last check. The current solution with the while loop is quite silly. I did more things in the loop previously.

The definition of first element seems to differ though. When you have "set_lang en nl;" or something, I would expect "en" to be the first language (which it is with the current patch).

Either way, I have applied your patch.