fix(platform): avoid macro-prone platform factory names

Author: GaspardKirira

include/vix/ui/platform/Platform.hpp

@@ -103,42 +103,45 @@ namespace vix::ui
      *
      * @return Web platform.
      */
-    [[nodiscard]] static Platform web() noexcept;
+    [[nodiscard]] static Platform web_platform_descriptor() noexcept;
 
     /**
      * @brief Create a Linux platform descriptor.
      *
+     * The name intentionally avoids `linux` because some toolchains expose
+     * it as a preprocessor macro.
+     *
      * @return Linux platform.
      */
-    [[nodiscard]] static Platform linux() noexcept;
+    [[nodiscard]] static Platform linux_platform() noexcept;
 
     /**
      * @brief Create a Windows platform descriptor.
      *
      * @return Windows platform.
      */
-    [[nodiscard]] static Platform windows() noexcept;
+    [[nodiscard]] static Platform windows_platform() noexcept;
 
     /**
      * @brief Create a macOS platform descriptor.
      *
      * @return macOS platform.
      */
-    [[nodiscard]] static Platform macos() noexcept;
+    [[nodiscard]] static Platform macos_platform() noexcept;
 
     /**
      * @brief Create an Android platform descriptor.
      *
      * @return Android platform.
      */
-    [[nodiscard]] static Platform android() noexcept;
+    [[nodiscard]] static Platform android_platform() noexcept;
 
     /**
      * @brief Create an iOS platform descriptor.
      *
      * @return iOS platform.
      */
-    [[nodiscard]] static Platform ios() noexcept;
+    [[nodiscard]] static Platform ios_platform() noexcept;
 
     /**
      * @brief Get the concrete platform kind.

src/platform/Platform.cpp

@@ -112,32 +112,32 @@ namespace vix::ui
 #endif
   }
 
-  Platform Platform::web() noexcept
+  Platform Platform::web_platform_descriptor() noexcept
   {
     return Platform(PlatformKind::Web);
   }
 
-  Platform Platform::linux() noexcept
+  Platform Platform::linux_platform() noexcept
   {
     return Platform(PlatformKind::Linux);
   }
 
-  Platform Platform::windows() noexcept
+  Platform Platform::windows_platform() noexcept
   {
     return Platform(PlatformKind::Windows);
   }
 
-  Platform Platform::macos() noexcept
+  Platform Platform::macos_platform() noexcept
   {
     return Platform(PlatformKind::MacOS);
   }
 
-  Platform Platform::android() noexcept
+  Platform Platform::android_platform() noexcept
   {
     return Platform(PlatformKind::Android);
   }
 
-  Platform Platform::ios() noexcept
+  Platform Platform::ios_platform() noexcept
   {
     return Platform(PlatformKind::IOS);
   }

tests/shell/app_shell_test.cpp

@@ -47,9 +47,9 @@ static void test_platform_family_to_string()
 
 static void test_platform_desktop()
 {
-  Platform linux = Platform::linux();
-  Platform windows = Platform::windows();
-  Platform macos = Platform::macos();
+  Platform linux = Platform::linux_platform();
+  Platform windows = Platform::windows_platform();
+  Platform macos = Platform::macos_platform();
 
   assert(linux.known());
   assert(windows.known());
@@ -70,8 +70,8 @@ static void test_platform_desktop()
 
 static void test_platform_mobile()
 {
-  Platform android = Platform::android();
-  Platform ios = Platform::ios();
+  Platform android = Platform::android_platform();
+  Platform ios = Platform::ios_platform();
 
   assert(android.known());
   assert(ios.known());
@@ -88,7 +88,7 @@ static void test_platform_mobile()
 
 static void test_platform_web()
 {
-  Platform web = Platform::web();
+  Platform web = Platform::web_platform_descriptor();
 
   assert(web.known());
   assert(web.web_platform());
@@ -152,7 +152,7 @@ static void test_shell_config_setters()
       .set_url("http://localhost:3000")
       .set_host("0.0.0.0")
       .set_port(9090)
-      .set_platform(Platform::web())
+      .set_platform(Platform::web_platform_descriptor())
       .set_width(1280)
       .set_height(720)
       .set_resizable(false)
@@ -454,7 +454,7 @@ static void test_app_shell_restart()
 static void test_app_shell_platform()
 {
   ShellConfig config;
-  config.set_platform(Platform::web());
+  config.set_platform(Platform::web_platform_descriptor());
 
   AppShell shell(config);