Nokken-Poole allows for missing icpsr key when getting start idpts

[lukesonnet]

The following lines allow for start values for icpsrs that don't have ideal points in the payload. However, this should not be handled by pynominate but by whatever is generating the payload for pynominate.

pynominate/pynominate/nokken_poole.py

Lines 61 to 66 in 6a5b8a5

	dat['start'] = [
	(
	str(x['icpsr']) in payload['idpt']
	and payload['idpt'][str(x['icpsr'])]
	) or [0.0, 0.0]

I'm going to remove these lines so that it matches nominate.py, which will throw a key error if it can't find the right icpsr.

[lukesonnet]

The function that we actually use is member_congress_votes, but that seems to be an old function. I'll switch it to use the above lines and delete member_congress_votes.

The problem here is that we construct icpsr_chamber_congress to get objects by icpsr-chamber-congress. This is an object where each key is a string with those three objects separated by underscores. This means we never preserve the type of the icpsr in the payload, which can be either string or int, as long as its the same throughout the payload.

I think the solution is to change the way we build icpsr_chamber_congress so that we can still accommodate payloads with either int or string icpsrs, and then rely on key errors when someone abuses that flexibility.