Is STATIC_DATA_UNREF_AFTER_TRANSFER fully supported?

[xiaoxin0214]

I noticed that the DataVariance enum includes:

STATIC_DATA_UNREF_AFTER_TRANSFER = 1,  /** unref this vsg::Data after the data has been transferred to the GPU memory .*/

However, in the current implementation of:

bool vsg::createBufferAndTransferData(Context& context, const BufferInfoList& bufferInfoList, VkBufferUsageFlags usage, VkSharingMode sharingMode)

the unref logic is only applied when transferTask is nullptr:

if (data->properties.dataVariance == STATIC_DATA_UNREF_AFTER_TRANSFER)
{
    bufferInfo->data.reset();
}

I couldn’t find any equivalent unref handling when transferTask is not nullptr.
Am I missing something, or is STATIC_DATA_UNREF_AFTER_TRANSFER not fully supported currently?

Thanks!

[robertosfield]

I haven't checked the TransferTask code yet, as I've been investigating another issue, but I expect this is simply an oversight in TransferTask.cpp and should be straight forward to fix by appling similar code. Once I've resolve this other issue I'll have a look.

However, you are welcome to try your had an adding the required code to TransferTask.cpp and if you get it working reliable submit a PR so I can review and merge if appropriate.