room support

[martynsmith]

Hi,

We spoke a while back about room support, and I'm quite keen to implement it (then make a pull request).

It's going to be tricky to match the Javascript implementation calling convention exactly, so do you have any preferences about how it should work (I figure it's worth asking before I get too involved) :-)

Thanks,

Martyn

[vti]

Do you have a code example?

[martynsmith]

No, I have nothing so far but I noticed that the Javascript API did things
like:

io.sockets.in("myRoom", "message")

and

socket.broadcast.to("myRoom", "message")

Because broadcast is already a method (in your implementation) I'm not
really quite sure how the room support should be added?

I'm happy to just make some stuff up, and then fire a pull request for us
to talk about?

On Sun, Jan 8, 2012 at 10:02 PM, Viacheslav Tykhanovskyi <
reply@reply.github.com

wrote:

Do you have a code example?

---

Reply to this email directly or view it on GitHub:
#15 (comment)

[vti]

You have to save all the rooms somewhere. I guess it should be a Pool object. And this way you already have access to pool from 'broadcast' and 'sockets' objects. Those are just wrappers around Pool.

[bluet]

Expecting the function for a while.
Currently I'm trying to add a messsage send/recv and private chat (two client room) function in my project, and expecting the room support in PocketIO.
Any news? :-)

[vti]

If you write a patch it'll be very much appreciated :)

[bluet]

I thought martynsmith has done that already? No?

[martynsmith]

Yeah, I just hadn't gotten around to making a pull request etc,

I can try do that sometime soon :-)

[bluet]

Awesome!!