fix: make userContext mandatory in browsingContext.CreateResult#1122
Closed
juliandescottes wants to merge 1 commit into
Closed
fix: make userContext mandatory in browsingContext.CreateResult#1122juliandescottes wants to merge 1 commit into
juliandescottes wants to merge 1 commit into
Conversation
Contributor
Author
|
Ok I see that this seems to be another follow up of #1046 which not only added userContext to events, but also to the return value of browsingContext.create. I will close in favor of #1071, I guess we can make it mandatory at the same time as the rest (in the future we should add a note in the spec when we make fields temporarily optional, that would save time ...) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The algorithm for browsingContext.create reads as follows:
Nothing here can lead userContext to be missing so I don't see why the property should be optional?
Preview | Diff