Where to check for ECMA maximum safe number for WebDriver perform actions parameter?

[PotatoCP]

In WPT perform_actions/invalid.py, we are expected to check if the parameter value for the webdriver actions must be in boundary of ECMA safe integer.

One example is https://github.com/web-platform-tests/wpt/blob/master/webdriver/tests/classic/perform_actions/invalid.py#L237-L250

I can't find in spec where to check for this safe number. Is the spec not complete or is it implied somewhere and I didn't catch it? Thanks

[whimboo]

The duration of a pause is an Integer as defined in WebDriver at https://w3c.github.io/webdriver/#dfn-integer. As you can see there is a Number reference that points to https://262.ecma-international.org/5.1/#sec-4.3.19. And a Number object has a MAX_VALUE as defined at https://262.ecma-international.org/5.1/#sec-15.7.3.2.

[PotatoCP]

The duration of a pause is an Integer as defined in WebDriver at https://w3c.github.io/webdriver/#dfn-integer. As you can see there is a Number reference that points to https://262.ecma-international.org/5.1/#sec-4.3.19. And a Number object has a MAX_VALUE as defined at https://262.ecma-international.org/5.1/#sec-15.7.3.2.

Thanks for the reply.

As defined in https://262.ecma-international.org/5.1/#sec-15.7.3.2

The value of Number.MAX_VALUE is the largest positive finite value of the Number type, which is approximately 1.7976931348623157 × 10^308.

This is wayyy above the MAX_VAL in the invalid.py, which is 9007199254740991 ($2^{53} - 1$)

https://github.com/web-platform-tests/wpt/blob/d0a21a80fa45b6727d0f647c4a58f3d5d8bbfbc2/webdriver/tests/classic/perform_actions/invalid.py#L10

Instead, the test refer to Maximum Safe Integer

[whimboo]

Err, yes. That was my failure. As said the pause duration is an Integer so your updated reference to Maximum Safe Integer will apply for sure.

[PotatoCP]

Ah, but then we should put somewhere in the spec to make sure that action parameter is Safe Integer. Should it be when processing the actions?