Skip to content

Reject reserved-internal contributor PRs#476

Merged
vkodithala merged 2 commits into
mainfrom
oz-agent/reserved-internal-pr-rejection
Jun 5, 2026
Merged

Reject reserved-internal contributor PRs#476
vkodithala merged 2 commits into
mainfrom
oz-agent/reserved-internal-pr-rejection

Conversation

@vkodithala

Copy link
Copy Markdown
Contributor

Summary

  • Add warp:reserved-internal handling to the external contributor PR issue-state gate.
  • Block linked issues marked warp:reserved-internal even if they also have a ready label.
  • Reuse the existing enforcement comment + REQUEST_CHANGES review path with a contributor-facing explanation.

Testing

  • /workspace/oz-for-oss/.venv/bin/python -m pytest /workspace/oz-for-oss/tests/test_pr_issue_state_enforcement.py
  • python3 -m py_compile /workspace/oz-for-oss/core/workflows/review_pr.py /workspace/oz-for-oss/tests/test_pr_issue_state_enforcement.py
  • git -C /workspace/oz-for-oss --no-pager diff --check

Conversation: https://staging.warp.dev/conversation/58f0a306-923a-4e2b-8e62-a1f9f577878b
Run: https://oz.staging.warp.dev/runs/019e935e-d239-7e49-8a3d-292a140284e2

Co-Authored-By: Oz oz-agent@warp.dev
This PR was generated with Oz.

@vkodithala vkodithala requested a review from peicodes June 4, 2026 20:31

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@vkodithala vkodithala marked this pull request as ready for review June 4, 2026 20:32
@oz-for-oss

oz-for-oss Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

@vkodithala

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@oz-for-oss oz-for-oss Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

This PR adds warp:reserved-internal handling to the external-contributor PR issue-state gate and covers the primary ready-plus-reserved rejection path in tests.

Concerns

  • The reserved-internal failure message tells contributors to look for either ready label, but this gate only accepts the required label for the current PR type; code PRs linked to ready-to-spec issues would still be rejected.

Verdict

Found: 0 critical, 1 important, 0 suggestions

Request changes

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

Comment on lines +313 to +317
sections.append(
"**Next step:** please look for another issue marked "
"`ready-to-spec` or `ready-to-implement`. If you think this label "
"was applied by mistake, mention `@oss-maintainers` on the issue."
)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [IMPORTANT] For code PRs, ready-to-spec still fails this gate; point contributors at the computed required_label so the next-step instruction matches the PR type.

Suggested change
sections.append(
"**Next step:** please look for another issue marked "
"`ready-to-spec` or `ready-to-implement`. If you think this label "
"was applied by mistake, mention `@oss-maintainers` on the issue."
)
sections.append(
f"**Next step:** please look for another issue marked `{required_label}`. "
"If you think this label was applied by mistake, mention "
"`@oss-maintainers` on the issue."
)

@vkodithala vkodithala merged commit 117b84e into main Jun 5, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants