Reject reserved-internal contributor PRs#476
Conversation
Co-Authored-By: Oz <oz-agent@warp.dev>
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This PR adds warp:reserved-internal handling to the external-contributor PR issue-state gate and covers the primary ready-plus-reserved rejection path in tests.
Concerns
- The reserved-internal failure message tells contributors to look for either ready label, but this gate only accepts the required label for the current PR type; code PRs linked to
ready-to-specissues would still be rejected.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
| sections.append( | ||
| "**Next step:** please look for another issue marked " | ||
| "`ready-to-spec` or `ready-to-implement`. If you think this label " | ||
| "was applied by mistake, mention `@oss-maintainers` on the issue." | ||
| ) |
There was a problem hiding this comment.
ready-to-spec still fails this gate; point contributors at the computed required_label so the next-step instruction matches the PR type.
| sections.append( | |
| "**Next step:** please look for another issue marked " | |
| "`ready-to-spec` or `ready-to-implement`. If you think this label " | |
| "was applied by mistake, mention `@oss-maintainers` on the issue." | |
| ) | |
| sections.append( | |
| f"**Next step:** please look for another issue marked `{required_label}`. " | |
| "If you think this label was applied by mistake, mention " | |
| "`@oss-maintainers` on the issue." | |
| ) |

Summary
warp:reserved-internalhandling to the external contributor PR issue-state gate.warp:reserved-internaleven if they also have a ready label.REQUEST_CHANGESreview path with a contributor-facing explanation.Testing
/workspace/oz-for-oss/.venv/bin/python -m pytest /workspace/oz-for-oss/tests/test_pr_issue_state_enforcement.pypython3 -m py_compile /workspace/oz-for-oss/core/workflows/review_pr.py /workspace/oz-for-oss/tests/test_pr_issue_state_enforcement.pygit -C /workspace/oz-for-oss --no-pager diff --checkConversation: https://staging.warp.dev/conversation/58f0a306-923a-4e2b-8e62-a1f9f577878b
Run: https://oz.staging.warp.dev/runs/019e935e-d239-7e49-8a3d-292a140284e2
Co-Authored-By: Oz oz-agent@warp.dev
This PR was generated with Oz.