fix: allowlist slack feedback bot for issue triage#477
Conversation
Co-Authored-By: Oz <oz-agent@warp.dev>
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR allowlists the internal Slack feedback GitHub App bot to route issues.opened events through issue triage while preserving the existing bot-author drop for other automation accounts. It also adds regression coverage for the allowlisted login and case-insensitive matching.
Concerns
- No blocking concerns found.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
Co-Authored-By: Oz <oz-agent@warp.dev>
…YAML skip - Move duplicated bot-detection logic (_actor_login, _actor_is_bot, _needs_triage_bot_author_allowlist) from api/webhook.py into core/routing.py as the shared needs_triage_bot_author_allowlist helper, eliminating drift risk between pre-routing and routing. - Extract load_triage_bot_author_allowlist(repo_handle, fallback_workspace) into oz/workflow_config.py so the webhook loader closure is a thin call-through. The helper is independently testable with an optional repo_text_fetcher parameter. - Add LoadTriageBotAuthorAllowlistTest covering: consuming repo config present (uses it), repo config missing (falls back to bundled config), and repo config malformed (raises RuntimeError). - Add test_rejects_malformed_yaml to TriageWorkflowConfigTest for explicit malformed-config coverage. - Remove the PyYAML try/except skip guard from test_workflow_config.py since PyYAML is a runtime dependency in requirements.txt and should fail loudly when missing. Co-Authored-By: Oz <oz-agent@warp.dev>
3 participants
Summary
Organizations should be able to allowlist specific trusted bot accounts.
Some of Warp's GitHub issues are automatically created from Slack feedback channels. Those messages are authored by the
warp-dev-github-integrationbot. Oz-for-OSS currently skips bot-authored issues, which means those messages aren't processed.This PR:
triage.bot_author_allowlistto.github/oz/config.ymlso repositories can opt specific automation accounts back intoissues.openedtriage.warp-dev-github-integration[bot]and document the new field.Config resolution note: Oz resolves
.github/oz/config.ymlfrom the consuming repository first and falls back to the bundled config when absent. The two configs are not merged — consuming repositories that provide their ownconfig.ymlmust includetriage.bot_author_allowlistthemselves if they want bot-authored issues to reach triage.Co-Authored-By: lucieleblanc lucieleblanc@users.noreply.github.com
Co-Authored-By: Oz oz-agent@warp.dev
Conversation: https://staging.warp.dev/conversation/34058c1c-12b1-474f-bb17-0c9edf44fc40
Run: https://oz.staging.warp.dev/runs/019e98d8-7314-7add-b3c1-a2ce08def13a
This PR was generated with Oz.