test: run seeding only when needed

Frederik Ring · Frederik Ring · commit 294624f3dba0 · 2023-07-03T10:02:00.000+02:00
diff --git a/tests/Jobs/PlatformStatsSummaryJobTest.php b/tests/Jobs/PlatformStatsSummaryJobTest.php
@@ -30,7 +30,6 @@ protected function setUp(): void {
         for($n = 0; $n < $this->numWikis; $n++ ) {
             DB::connection('mysql')->getPdo()->exec("DROP DATABASE IF EXISTS {$this->db_name}{$n};");
         }
-        $this->seedWikis();
     }
 
     protected function tearDown(): void {
@@ -63,6 +62,7 @@ private function seedWikis() {
     }
     public function testQueryGetsStats()
     {
+        $this->seedWikis();
         $mockJob = $this->createMock(Job::class);
         $mockJob->expects($this->never())->method('fail');
 
@@ -74,6 +74,7 @@ public function testQueryGetsStats()
 
     public function testGroupings()
     {
+        $this->seedWikis();
         $mockJob = $this->createMock(Job::class);
         $mockJob->expects($this->never())->method('fail');
 

Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,6 @@ protected function setUp(): void {`
`30`	`30`	`for($n = 0; $n < $this->numWikis; $n++ ) {`
`31`	`31`	`DB::connection('mysql')->getPdo()->exec("DROP DATABASE IF EXISTS {$this->db_name}{$n};");`
`32`	`32`	`}`
`33`		`- $this->seedWikis();`
`34`	`33`	`}`
`35`	`34`
`36`	`35`	`protected function tearDown(): void {`
`@@ -63,6 +62,7 @@ private function seedWikis() {`
`63`	`62`	`}`
`64`	`63`	`public function testQueryGetsStats()`
`65`	`64`	`{`
	`65`	`+ $this->seedWikis();`
`66`	`66`	`$mockJob = $this->createMock(Job::class);`
`67`	`67`	`$mockJob->expects($this->never())->method('fail');`
`68`	`68`
`@@ -74,6 +74,7 @@ public function testQueryGetsStats()`
`74`	`74`
`75`	`75`	`public function testGroupings()`
`76`	`76`	`{`
	`77`	`+ $this->seedWikis();`
`77`	`78`	`$mockJob = $this->createMock(Job::class);`
`78`	`79`	`$mockJob->expects($this->never())->method('fail');`
`79`	`80`