Add case insensitivity to email search + test cases (#1042)

Bug: T415017

Author: rosalieper

app/Console/Commands/User/CheckUserEmailExist.php

@@ -16,7 +16,7 @@ public function handle(WikiUserEmailChecker $emailChecker): int {
         foreach ($emails as $email) {
             $found = false;
 
-            if (User::whereEmail($email)->exists()) {
+            if (User::whereEmailInsensitive($email)->exists()) {
                 $this->line("FOUND: {$email} in apidb.users");
                 $found = true;
             }

app/Services/WikiUserEmailChecker.php

@@ -51,7 +51,7 @@ private function emailExists(PDO $pdo, string $dbName, string $table, string $em
         $stmt = $pdo->prepare("
             SELECT 1
             FROM {$dbName}.{$table}
-            WHERE user_email = :email
+            WHERE LOWER(CONVERT(user_email USING utf8mb4)) = LOWER(:email)
             LIMIT 1
         ");
 

app/User.php

@@ -121,4 +121,8 @@ public function sendEmailVerificationNotification() {
     public function getEmailForVerification() {
         return $this->email;
     }
+
+    public function scopeWhereEmailInsensitive($query, string $email) {
+        return $query->whereRaw('LOWER(email) = ?', [strtolower($email)]);
+    }
 }

tests/Commands/User/CheckUserEmailExistTest.php

@@ -8,6 +8,10 @@
 use Tests\TestCase;
 
 class CheckUserEmailExistTest extends TestCase {
+    protected function tearDown(): void {
+        User::query()->delete();
+    }
+
     public function testItFindsEmailInApiUsersTable() {
         User::factory()->create([
             'email' => 'user@example.com',
@@ -51,4 +55,13 @@ public function testEmailFoundInWikiDb() {
             ->expectsOutput('FOUND: test@example.com in mwdb_test.mwdb_test_user')
             ->assertExitCode(0);
     }
+
+    public function testCaseInsensitive() {
+        User::factory()->create([
+            'email' => 'Test@Example.com',
+        ]);
+        $exists = User::whereEmailInsensitive('tEsT@eXaMpLe.CoM')->exists();
+
+        $this->assertTrue($exists);
+    }
 }

tests/Services/WikiUserEmailCheckerTest.php

@@ -16,6 +16,7 @@ class WikiUserEmailCheckerTest extends TestCase {
         ['prefix' => 'db_1', 'name' => 'mwdb_1', 'emails' => ['user1@email.localhost', 'user2@email.localhost']],
         ['prefix' => 'db_2', 'name' => 'mwdb_2', 'emails' => ['user1@email.localhost']],
         ['prefix' => 'db_3', 'name' => 'mwdb_3', 'emails' => []],
+        ['prefix' => 'db_4', 'name' => 'mwdb_4', 'emails' => ['UsEr4@EmAiL.lOcAlHoSt']],
     ];
 
     protected function setUp(): void {
@@ -62,4 +63,12 @@ public function testEmailFoundInMultipleDatabases(): void {
             $checker->findEmail('user1@email.localhost')
         );
     }
+
+    public function testWikiUserEmailCheckerIsCaseInsensitive(): void {
+        $checker = new WikiUserEmailChecker($this->db);
+        $this->assertEquals(
+            ['mwdb_4.db_4_user'],
+            $checker->findEmail('uSer4@eMAil.localhost')
+        );
+    }
 }