Skip to content

[upstream PR 941] docs(skills): redact secrets in remember skill #919

@wbugitlab1

Description

@wbugitlab1

Source repository: rohitg00/agentmemory
Source pull request number: 941
Source URL: intentionally omitted to avoid GitHub cross-references
Title: docs(skills): redact secrets in remember skill
Author: caioribeiroclw-pixel
State: open
Draft: no
Merged: no
Head: caioribeiroclw-pixel/agentmemory:caio/remember-redact-secrets @ b555cb4
Base: main @ f6f9e3c
Labels: (none)
Changed files: 0
Commits: 0
Created: 2026-06-16T01:03:32Z
Updated: 2026-06-16T01:06:30Z
Closed: (not closed)
Merged at: (not merged)

Original PR body:

Summary

  • update the remember skill to preserve meaning while redacting credentials/secrets
  • add a workflow sanitization step before memory_save
  • add an example for storing a security-sensitive operational note without persisting the raw secret

Why

This addresses #911's W007 finding: the previous wording asked agents to preserve the user's phrasing, which can cause raw API keys, tokens, passwords, cookies, private keys, or connection strings to be saved into long-term memory.

Verification

  • git diff --check
  • npm run skills:check not run locally because this fresh shallow clone does not have node_modules installed

Summary by CodeRabbit

  • Documentation
    • Added a worked example demonstrating secure storage of security-sensitive information with the remember skill, including explicit guidance to avoid storing raw secrets
    • Enhanced skill documentation with refined guidance on converting inputs into long-term memory while preserving meaning and redacting sensitive values
    • Expanded anti-patterns section with clearer examples of what not to store and how to properly phrase redacted content

Local branch:
Fork PR:
Fork decision:
Verification:
Notes:

Metadata

Metadata

Assignees

No one assigned

    Labels

    decision-candidateFork decision has not been madeupstream-openUpstream pull request is openupstream-prTracks an upstream pull request

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions