Skip to content

[wdspec] align navigation tests with spec#50527

Merged
foolip merged 3 commits into
masterfrom
sadym/navigation-wait-none
Feb 11, 2025
Merged

[wdspec] align navigation tests with spec#50527
foolip merged 3 commits into
masterfrom
sadym/navigation-wait-none

Conversation

@sadym-chromium
Copy link
Copy Markdown
Contributor

@sadym-chromium sadym-chromium commented Feb 6, 2025

Align WebDriver BiDi spec tests with the breaking change in navigation wait logic: w3c/webdriver-bidi#855.

@sadym-chromium sadym-chromium requested a review from OrKoN February 6, 2025 14:02
sadym-chromium added a commit to GoogleChromeLabs/chromium-bidi that referenced this pull request Feb 6, 2025
@sadym-chromium
roll WPT to web-platform-tests/wpt#50527
72c9061
@sadym-chromium sadym-chromium force-pushed the sadym/navigation-wait-none branch from 1bf7cc8 to 262012f Compare February 6, 2025 14:04
sadym-chromium added a commit to GoogleChromeLabs/chromium-bidi that referenced this pull request Feb 6, 2025
@sadym-chromium
roll WPT to web-platform-tests/wpt#50527
80d6c37
@sadym-chromium
[wdspec] align navigation tests with spec
7f03281 
Align WebDriver BiDi spec tests with the breaking change in navigation wait logic: w3c/webdriver-bidi#855.
@sadym-chromium sadym-chromium force-pushed the sadym/navigation-wait-none branch from 262012f to 7f03281 Compare February 6, 2025 14:07
sadym-chromium added a commit to GoogleChromeLabs/chromium-bidi that referenced this pull request Feb 6, 2025
@sadym-chromium
roll WPT to web-platform-tests/wpt#50527
508e2c1
sadym-chromium added a commit to GoogleChromeLabs/chromium-bidi that referenced this pull request Feb 6, 2025
@sadym-chromium
Revert "roll WPT to web-platform-tests/wpt#50527"
523af90 
This reverts commit 508e2c1.
sadym-chromium added a commit to GoogleChromeLabs/chromium-bidi that referenced this pull request Feb 6, 2025
@sadym-chromium
roll WPT to web-platform-tests/wpt#50527
ca7d42a
OrKoN
OrKoN reviewed Feb 6, 2025
View reviewed changes
Comment thread webdriver/tests/bidi/network/fetch_error/fetch_error.py
@OrKoN
Copy link
Copy Markdown
Contributor

OrKoN commented Feb 6, 2025

it looks like Firefox stability job indicates some flakiness (not sure if it is on tests or on the implementation).

@sadym-chromium
Copy link
Copy Markdown
Contributor Author

sadym-chromium commented Feb 6, 2025

it looks like Firefox stability job indicates some flakiness (not sure if it is on tests or on the implementation).

The flakes are due to the fact the wait condition none should wait for navigation to be committed and the current URL to be updated. Firefox implementation does not wait for it, which makes the url sometimes to be updated and sometimes not.

@sadym-chromium
Copy link
Copy Markdown
Contributor Author

sadym-chromium commented Feb 6, 2025

it looks like Firefox stability job indicates some flakiness (not sure if it is on tests or on the implementation).

The flakes are due to the fact the wait condition none should wait for navigation to be committed and the current URL to be updated. Firefox implementation does not wait for it, which makes the url sometimes to be updated and sometimes not.

UPD: actually the problem not in the URL, and I cannot get the full test report, but I guess the problem is in the fact that navigation with wait "nont" sometimes finishes and sometimes not before the assertion: https://github.com/web-platform-tests/wpt/blob/7f032811326e4eb82a80fd55c26f5451d4ffb068/webdriver/tests/bidi/browsing_context/navigate/navigate.py#L174C5-L174C39. I added assertion messages.

OrKoN
OrKoN approved these changes Feb 6, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@OrKoN OrKoN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sadym-chromium
Copy link
Copy Markdown
Contributor Author

sadym-chromium commented Feb 6, 2025

@whimboo could you please take a look?

sadym-chromium added a commit to GoogleChromeLabs/chromium-bidi that referenced this pull request Feb 7, 2025
@sadym-chromium
Revert "roll WPT to web-platform-tests/wpt#50527"
429fe29 
This reverts commit ca7d42a.
@sadym-chromium sadym-chromium mentioned this pull request Feb 7, 2025
Merged
whimboo
whimboo reviewed Feb 7, 2025
View reviewed changes
Comment thread webdriver/tests/bidi/browsing_context/navigation_started/navigation_started.py
@sadym-chromium sadym-chromium force-pushed the sadym/navigation-wait-none branch from 49257d9 to b7987da Compare February 10, 2025 10:08
sadym-chromium added a commit to GoogleChromeLabs/chromium-bidi that referenced this pull request Feb 10, 2025
@sadym-chromium
roll WPT to web-platform-tests/wpt#50527
b8c2c50
sadym-chromium added a commit to GoogleChromeLabs/chromium-bidi that referenced this pull request Feb 10, 2025
@sadym-chromium
Revert "roll WPT to web-platform-tests/wpt#50527"
1f8feab 
This reverts commit b8c2c50.
sadym-chromium added a commit to GoogleChromeLabs/chromium-bidi that referenced this pull request Feb 10, 2025
@sadym-chromium
feat: wait none waits for navigation to be committed (#3086)
b8f30b1 
Refactor NavigationTracker will be in a follow-up. 

Tested with web-platform-tests/wpt#50527.
@sadym-chromium
Copy link
Copy Markdown
Contributor Author

sadym-chromium commented Feb 11, 2025

@foolip can you please merge the PR, as the flakes in the new tests are expected due to their nature?

@foolip
Copy link
Copy Markdown
Member

foolip commented Feb 11, 2025

Admin merging since the flaky results in Firefox are accounted for in #50527 (comment).

@foolip foolip merged commit e8db5e0 into master Feb 11, 2025
@foolip foolip deleted the sadym/navigation-wait-none branch February 11, 2025 12:24
@sadym-chromium
Copy link
Copy Markdown
Contributor Author

sadym-chromium commented Feb 12, 2025

GoogleChromeLabs/chromium-bidi#2982

@sadym-chromium sadym-chromium mentioned this pull request Feb 12, 2025
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@whimboo whimboo whimboo approved these changes

@OrKoN OrKoN OrKoN approved these changes

@AutomatedTester AutomatedTester Awaiting requested review from AutomatedTester

@jgraham jgraham Awaiting requested review from jgraham

@juliandescottes juliandescottes Awaiting requested review from juliandescottes

@shs96c shs96c Awaiting requested review from shs96c

Assignees

@OrKoN OrKoN

Labels

webdriver-bidi wg-s_browser-tools-testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sadym-chromium @OrKoN @foolip @whimboo @wpt-pr-bot