Skip to content

webdriver: Improve error reporting for Cookie Addition #58773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
servo-wpt-sync merged 1 commit into from
Mar 26, 2026
Merged

webdriver: Improve error reporting for Cookie Addition #58773

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions webdriver/tests/classic/add_cookie/add.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,3 +305,17 @@ def test_add_cookie_with_invalid_samesite_type(session, url, same_site):

response = add_cookie(session, new_cookie)
assert_error(response, "invalid argument")


@pytest.mark.parametrize("expiry", [2 ** 53, -1, 0.5])
def test_add_cookie_with_invalid_expiry(session, url, expiry):
new_cookie = {
"name": "hello",
"value": "world",
"expiry": expiry
}

session.url = url("/common/blank.html")

response = add_cookie(session, new_cookie)
assert_error(response, "invalid argument")
Loading