fix(plugin): isolate ESLint instance per webpack config in non-thread…#287
Open
AhNosNimes wants to merge 1 commit intowebpack:masterfrom
Open
fix(plugin): isolate ESLint instance per webpack config in non-thread…#287AhNosNimes wants to merge 1 commit intowebpack:masterfrom
AhNosNimes wants to merge 1 commit intowebpack:masterfrom
Conversation
…ed mode Avoid reusing global ESLint instances across multiple webpack configurations. This fixes incorrect `cwd` and context resolution due to shared state between configurations. Threaded mode remains broken due to fundamental architectural flaws and requires a complete rewrite to be compatible. BREAKING CHANGE: threaded mode is broken and now explicitly unsupported fixes webpack#286
|
alexander-akait
requested changes
Jun 20, 2025
Member
alexander-akait
left a comment
alexander-akait
left a comment
There was a problem hiding this comment.
Please add a test case, thank you
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello
Avoid reusing global ESLint instances across multiple webpack configurations. This change corrects issues with incorrect cwd and context resolution caused by shared state between configurations. Note: Threaded mode remains broken due to fundamental architectural flaws and would require a full rewrite to function correctly.
Fixes #286
This PR contains a:
Motivation / Use-Case
This fix addresses the use case of multiple webpack configurations where the previous implementation shares the same incorrect eslint instance.
Breaking Changes
Threaded mode is currently broken and now considered unsupported.
Additional Info
This PR is not meant to be merged as-is. It serves as a proof of concept or inspiration.
The threaded mode is fundamentally flawed: setup is invoked multiple times for the same worker, and most operations are incorrectly executed on the main thread instead of worker threads.
Fixing this would require a complete architectural rewrite, which I am not undertaking, as I do not use threaded mode myself.
The current implementation leads to redundant and duplicated work, making it non-viable in practice.
Have a nice day