Dockerfile healthchecks should use env variables

[i-am-jmn]

Dockerfile in images/ use hard-coded port numbers. They should use the environment variables provided by the user.

[webysther]

Dockerfile in images/ use hard-coded port numbers. They should use the environment variables provided by the user.

This break something? The port of healthcheck is not only used internally?

[i-am-jmn]

This will break. Look at supavisor Dockerfile. The environment variable control the port.

[webysther]

This will break. Look at supavisor Dockerfile. The environment variable control the port.

Can you give a reproduction steps?

[webysther]

Anyway, if you change the port, just do that:

  supavisor:
    <<: *common
    image: ghcr.io/webysther/supabase-supavisor:2.7.4
    container_name: supabase-pooler
    ports:
      - ${POSTGRES_PORT}:5432
      - 6543:6543
    healthcheck:
      test:
        [
          "CMD",
          "curl",
          "-sSfL",
          "--head",
          "-o",
          "/dev/null",
          "http://127.0.0.1:4000/api/health"
        ]
    depends_on:
      db:
        condition: service_healthy
      analytics:
        condition: service_healthy

Another thing is using the plain docker-compose.yml, create another one and use extends.

[i-am-jmn]

You have a PORT environment variable.
Set it to something else.
The healthcheck will still ping 4000.

[i-am-jmn]

I'm not talking about compose or containers, but plain images there.

[webysther]

You have a PORT environment variable. Set it to something else. The healthcheck will still ping 4000.

Oh! This is a dumb dotenv from supabase, I have no ideia if this is used: https://github.com/supabase/supabase/blob/master/docker/docker-compose.yml#L529

The main ideia was just remove from the final user because no one use this in reality, if someone needs to change this, only this two values need to be changed, TBH, I think no one will want to do this because the route is internal.