More tests on writing

Author: EnricoMi

tests/test_fromfile.py

@@ -5,6 +5,7 @@
 from unittest import skipIf
 from junitparser import (
     TestCase,
+    TestSuite,
     Skipped,
     Failure,
     JUnitXmlError,

tests/test_general.py

@@ -124,6 +124,7 @@ def test_fromstring(self):
         <testcase name="testname2">
         </testcase></testsuite></testsuites>"""
         result = JUnitXml.fromstring(text)
+        assert isinstance(result, JUnitXml)
         assert len(result) == 2
         assert result.time == 0
 
@@ -132,6 +133,7 @@ def test_fromstring_no_testsuites(self):
         <testcase name="testname1">
         </testcase></testsuite>"""
         result = JUnitXml.fromstring(text)
+        assert isinstance(result, JUnitXml)
         assert len(result) == 1
         assert result.time == 0
 

tests/test_write.py

@@ -129,6 +129,43 @@ def test_write_nonascii():
     assert xmlfile.getvalue().decode("utf-8") == get_expected_xml("用例1")
 
 
+def test_write_no_testsuites():
+    # Has to be a binary string to include xml declarations.
+    text = b"""<?xml version="1.0" encoding="UTF-8"?>
+<testsuite name="JUnitXmlReporter.constructor">
+   <testcase classname="JUnitXmlReporter.constructor" name="should default path to an empty string" time="0.006"/>
+</testsuite>"""
+    xml = JUnitXml.fromstring(text)
+    assert isinstance(xml, JUnitXml)
+    suite = next(iter(xml))
+    assert isinstance(suite, TestSuite)
+    case = next(iter(suite))
+    assert isinstance(case, TestCase)
+    assert len(case.result) == 0
+
+    # writing this JUnitXml object contains a root <testsuites> element
+    xmlfile = BytesIO()
+    xml.write(xmlfile)
+    assert xmlfile.getvalue().decode("utf-8") == (
+        "<?xml version='1.0' encoding='UTF-8'?>\n"
+        '<testsuites><testsuite name="JUnitXmlReporter.constructor">\n'
+        '   <testcase classname="JUnitXmlReporter.constructor" name="should default '
+        'path to an empty string" time="0.006"/>\n'
+        '</testsuite></testsuites>'
+    )
+
+    # writing the inner testsuite reproduces the input string
+    xmlfile = BytesIO()
+    suite.write(xmlfile)
+    assert xmlfile.getvalue().decode("utf-8") == (
+        "<?xml version='1.0' encoding='UTF-8'?>\n"
+        '<testsuite name="JUnitXmlReporter.constructor">\n'
+        '   <testcase classname="JUnitXmlReporter.constructor" name="should default '
+        'path to an empty string" time="0.006"/>\n'
+        '</testsuite>'
+    )
+
+
 def test_read_written_xml():
     suite1 = TestSuite()
     suite1.name = "suite1"