From c69539e8f2714560a28ef8a2094627bbebe84983 Mon Sep 17 00:00:00 2001 From: vojtasmrcek Date: Mon, 27 Aug 2018 10:41:16 +0200 Subject: [PATCH 1/4] Remove passcode lock from the app --- WordPress/build.gradle | 3 -- WordPress/src/main/AndroidManifest.xml | 13 ------- .../java/org/wordpress/android/WordPress.java | 23 +---------- .../android/ui/ActivityLauncher.java | 3 -- .../ui/photopicker/PhotoPickerActivity.java | 3 -- .../android/ui/posts/EditPostActivity.java | 7 ---- .../android/ui/prefs/AppSettingsActivity.java | 38 +------------------ .../ui/prefs/SiteSettingsTimezoneDialog.java | 2 +- .../ui/reader/ReaderPostDetailFragment.java | 7 ---- .../wordpress/android/util/WPMediaUtils.java | 5 --- WordPress/src/main/res/xml/app_settings.xml | 21 ---------- 11 files changed, 3 insertions(+), 122 deletions(-) diff --git a/WordPress/build.gradle b/WordPress/build.gradle index 6eef3e212d39..b86877350a80 100644 --- a/WordPress/build.gradle +++ b/WordPress/build.gradle @@ -162,9 +162,6 @@ dependencies { androidTestImplementation 'com.squareup.okhttp:mockwebserver:2.7.5' androidTestImplementation 'com.squareup.okio:okio:1.13.0' - // Provided by the WordPress-Android Repository - implementation 'org.wordpress:passcodelock:1.5.1' - // Dagger implementation 'com.google.dagger:dagger:2.11' kapt 'com.google.dagger:dagger-compiler:2.11' diff --git a/WordPress/src/main/AndroidManifest.xml b/WordPress/src/main/AndroidManifest.xml index ec0d758f56d6..ed6d7ee26b7b 100644 --- a/WordPress/src/main/AndroidManifest.xml +++ b/WordPress/src/main/AndroidManifest.xml @@ -486,19 +486,6 @@ android:name=".ui.notifications.NotificationsDetailActivity" android:theme="@style/CalypsoTheme" /> - - - - properties = new HashMap<>(1); - properties.put("pin_lock_enabled", AppLockManager.getInstance().getAppLock() != null - && AppLockManager.getInstance().getAppLock().isPasswordLocked()); - AnalyticsTracker.track(Stat.APPLICATION_OPENED, properties); + AnalyticsTracker.track(Stat.APPLICATION_OPENED); if (NetworkUtils.isNetworkAvailable(mContext)) { // Refresh account informations and Notifications if (mAccountStore.hasAccessToken()) { diff --git a/WordPress/src/main/java/org/wordpress/android/ui/ActivityLauncher.java b/WordPress/src/main/java/org/wordpress/android/ui/ActivityLauncher.java index e25ccdf8d65f..fb00db771f3d 100644 --- a/WordPress/src/main/java/org/wordpress/android/ui/ActivityLauncher.java +++ b/WordPress/src/main/java/org/wordpress/android/ui/ActivityLauncher.java @@ -64,7 +64,6 @@ import org.wordpress.android.util.ToastUtils; import org.wordpress.android.util.UrlUtils; import org.wordpress.android.util.WPActivityUtils; -import org.wordpress.passcodelock.AppLockManager; import java.util.ArrayList; import java.util.HashMap; @@ -563,7 +562,6 @@ public static void openUrlExternal(Context context, @NonNull String url) { WPActivityUtils.disableComponent(context, ReaderPostPagerActivity.class); context.startActivity(intent); - AppLockManager.getInstance().setExtendedTimeout(); } catch (ActivityNotFoundException e) { ToastUtils.showToast(context, context.getString(R.string.cant_open_url), ToastUtils.Duration.LONG); AppLog.e(AppLog.T.UTILS, "No default app available on the device to open the link: " + url, e); @@ -578,7 +576,6 @@ public static void openUrlExternal(Context context, @NonNull String url) { } else { Intent chooser = Intent.createChooser(intent, context.getString(R.string.error_please_choose_browser)); context.startActivity(chooser); - AppLockManager.getInstance().setExtendedTimeout(); } } finally { // re-enable deeplinking diff --git a/WordPress/src/main/java/org/wordpress/android/ui/photopicker/PhotoPickerActivity.java b/WordPress/src/main/java/org/wordpress/android/ui/photopicker/PhotoPickerActivity.java index 948885800988..90079e1c64cb 100644 --- a/WordPress/src/main/java/org/wordpress/android/ui/photopicker/PhotoPickerActivity.java +++ b/WordPress/src/main/java/org/wordpress/android/ui/photopicker/PhotoPickerActivity.java @@ -39,7 +39,6 @@ import org.wordpress.android.util.NetworkUtils; import org.wordpress.android.util.ToastUtils; import org.wordpress.android.util.WPMediaUtils; -import org.wordpress.passcodelock.AppLockManager; import java.io.File; import java.util.ArrayList; @@ -238,14 +237,12 @@ private void launchCamera() { @Override public void onMediaCapturePathReady(String mediaCapturePath) { mMediaCapturePath = mediaCapturePath; - AppLockManager.getInstance().setExtendedTimeout(); } }); } private void launchPictureLibrary() { WPMediaUtils.launchPictureLibrary(this, false); - AppLockManager.getInstance().setExtendedTimeout(); } private void launchWPMediaLibrary() { diff --git a/WordPress/src/main/java/org/wordpress/android/ui/posts/EditPostActivity.java b/WordPress/src/main/java/org/wordpress/android/ui/posts/EditPostActivity.java index 65f836cd7baf..ee6dff5f91c5 100644 --- a/WordPress/src/main/java/org/wordpress/android/ui/posts/EditPostActivity.java +++ b/WordPress/src/main/java/org/wordpress/android/ui/posts/EditPostActivity.java @@ -162,7 +162,6 @@ import org.wordpress.android.widgets.WPViewPager; import org.wordpress.aztec.AztecExceptionHandler; import org.wordpress.aztec.util.AztecLog; -import org.wordpress.passcodelock.AppLockManager; import java.io.File; import java.io.FileOutputStream; @@ -1290,17 +1289,14 @@ private void onUploadProgress(MediaModel media, float progress) { private void launchPictureLibrary() { WPMediaUtils.launchPictureLibrary(this, true); - AppLockManager.getInstance().setExtendedTimeout(); } private void launchVideoLibrary() { WPMediaUtils.launchVideoLibrary(this, true); - AppLockManager.getInstance().setExtendedTimeout(); } private void launchVideoCamera() { WPMediaUtils.launchVideoCamera(this); - AppLockManager.getInstance().setExtendedTimeout(); } private void showErrorAndFinish(int errorMessageId) { @@ -2122,7 +2118,6 @@ private void launchCamera() { @Override public void onMediaCapturePathReady(String mediaCapturePath) { mMediaCapturePath = mediaCapturePath; - AppLockManager.getInstance().setExtendedTimeout(); } }); } @@ -3190,8 +3185,6 @@ public void run() { refreshBlogMedia(); } }); - } else { - AppLockManager.getInstance().setExtendedTimeout(); } } diff --git a/WordPress/src/main/java/org/wordpress/android/ui/prefs/AppSettingsActivity.java b/WordPress/src/main/java/org/wordpress/android/ui/prefs/AppSettingsActivity.java index 55ed42595911..63917e0761f9 100644 --- a/WordPress/src/main/java/org/wordpress/android/ui/prefs/AppSettingsActivity.java +++ b/WordPress/src/main/java/org/wordpress/android/ui/prefs/AppSettingsActivity.java @@ -3,24 +3,17 @@ import android.app.FragmentManager; import android.content.Context; import android.os.Bundle; -import android.preference.Preference; -import android.preference.SwitchPreference; import android.support.v7.app.ActionBar; import android.support.v7.app.AppCompatActivity; import android.view.MenuItem; import org.wordpress.android.R; -import org.wordpress.android.push.GCMMessageService; import org.wordpress.android.util.LocaleManager; -import org.wordpress.passcodelock.AppLockManager; -import org.wordpress.passcodelock.PasscodePreferenceFragment; public class AppSettingsActivity extends AppCompatActivity { private static final String KEY_APP_SETTINGS_FRAGMENT = "app-settings-fragment"; - private static final String KEY_PASSCODE_FRAGMENT = "passcode-fragment"; private AppSettingsFragment mAppSettingsFragment; - private PasscodePreferenceFragment mPasscodePreferenceFragment; @Override protected void attachBaseContext(Context newBase) { @@ -39,44 +32,15 @@ public void onCreate(Bundle savedInstanceState) { FragmentManager fragmentManager = getFragmentManager(); mAppSettingsFragment = (AppSettingsFragment) fragmentManager.findFragmentByTag(KEY_APP_SETTINGS_FRAGMENT); - mPasscodePreferenceFragment = - (PasscodePreferenceFragment) fragmentManager.findFragmentByTag(KEY_PASSCODE_FRAGMENT); - if (mAppSettingsFragment == null || mPasscodePreferenceFragment == null) { - Bundle passcodeArgs = new Bundle(); - passcodeArgs.putBoolean(PasscodePreferenceFragment.KEY_SHOULD_INFLATE, false); + if (mAppSettingsFragment == null) { mAppSettingsFragment = new AppSettingsFragment(); - mPasscodePreferenceFragment = new PasscodePreferenceFragment(); - mPasscodePreferenceFragment.setArguments(passcodeArgs); fragmentManager.beginTransaction() - .replace(android.R.id.content, mPasscodePreferenceFragment, KEY_PASSCODE_FRAGMENT) .add(android.R.id.content, mAppSettingsFragment, KEY_APP_SETTINGS_FRAGMENT) .commit(); } } - @Override - public void onStart() { - super.onStart(); - - Preference togglePref = - mAppSettingsFragment.findPreference(getString(org.wordpress.passcodelock.R.string - .pref_key_passcode_toggle)); - Preference changePref = - mAppSettingsFragment.findPreference(getString(org.wordpress.passcodelock.R.string - .pref_key_change_passcode)); - - if (togglePref != null && changePref != null) { - mPasscodePreferenceFragment.setPreferences(togglePref, changePref); - ((SwitchPreference) togglePref).setChecked( - AppLockManager.getInstance().getAppLock().isPasswordLocked()); - - // here they've changed the PIN lock settings, so let's rebuild notifications if they have - // quick actions - GCMMessageService.rebuildAndUpdateNotifsOnSystemBarForRemainingNote(this); - } - } - @Override public boolean onOptionsItemSelected(final MenuItem item) { switch (item.getItemId()) { diff --git a/WordPress/src/main/java/org/wordpress/android/ui/prefs/SiteSettingsTimezoneDialog.java b/WordPress/src/main/java/org/wordpress/android/ui/prefs/SiteSettingsTimezoneDialog.java index 0567ee917b19..774fafc94902 100644 --- a/WordPress/src/main/java/org/wordpress/android/ui/prefs/SiteSettingsTimezoneDialog.java +++ b/WordPress/src/main/java/org/wordpress/android/ui/prefs/SiteSettingsTimezoneDialog.java @@ -324,7 +324,7 @@ public View getView(int position, View convertView, ViewGroup parent) { boolean isSelected = mSelectedTimezone != null && mSelectedTimezone.equals(mFilteredTimezones.get(position).mValue); - int colorRes = isSelected ? R.color.list_row_selected : R.color.transparent; + int colorRes = isSelected ? R.color.color_control_activated : R.color.transparent; holder.mTxtLabel.setBackgroundColor(getResources().getColor(colorRes)); holder.mTxtLabel.setText(mFilteredTimezones.get(position).mLabel); diff --git a/WordPress/src/main/java/org/wordpress/android/ui/reader/ReaderPostDetailFragment.java b/WordPress/src/main/java/org/wordpress/android/ui/reader/ReaderPostDetailFragment.java index bad0bdf9838f..183cb785dad2 100644 --- a/WordPress/src/main/java/org/wordpress/android/ui/reader/ReaderPostDetailFragment.java +++ b/WordPress/src/main/java/org/wordpress/android/ui/reader/ReaderPostDetailFragment.java @@ -85,7 +85,6 @@ import org.wordpress.android.widgets.WPScrollView; import org.wordpress.android.widgets.WPScrollView.ScrollDirectionListener; import org.wordpress.android.widgets.WPTextView; -import org.wordpress.passcodelock.AppLockManager; import java.util.EnumSet; @@ -1168,12 +1167,6 @@ protected void onPostExecute(Boolean result) { case COMMENT_JUMP: case COMMENT_REPLY: case COMMENT_LIKE: - if (AppLockManager.getInstance().isAppLockFeatureEnabled()) { - // passcode screen was launched already (when ReaderPostPagerActivity got resumed) so reset - // the timeout to let the passcode screen come up for the ReaderCommentListActivity. - // See https://github.com/wordpress-mobile/WordPress-Android/issues/4887 - AppLockManager.getInstance().getAppLock().forcePasswordLock(); - } ReaderActivityLauncher.showReaderComments(getActivity(), mPost.blogId, mPost.postId, mDirectOperation, mCommentId, mInterceptedUri); getActivity().finish(); diff --git a/WordPress/src/main/java/org/wordpress/android/util/WPMediaUtils.java b/WordPress/src/main/java/org/wordpress/android/util/WPMediaUtils.java index 28a981bec2e9..0731ce12d292 100644 --- a/WordPress/src/main/java/org/wordpress/android/util/WPMediaUtils.java +++ b/WordPress/src/main/java/org/wordpress/android/util/WPMediaUtils.java @@ -26,7 +26,6 @@ import org.wordpress.android.ui.RequestCodes; import org.wordpress.android.ui.prefs.AppPrefs; import org.wordpress.android.util.AppLog.T; -import org.wordpress.passcodelock.AppLockManager; import java.io.File; import java.io.IOException; @@ -221,7 +220,6 @@ public void onClick(DialogInterface dialog, int whichButton) { } public static void launchVideoLibrary(Activity activity, boolean multiSelect) { - AppLockManager.getInstance().setExtendedTimeout(); activity.startActivityForResult(prepareVideoLibraryIntent(activity, multiSelect), RequestCodes.VIDEO_LIBRARY); } @@ -238,7 +236,6 @@ private static Intent prepareVideoLibraryIntent(Context context, boolean multiSe } public static void launchVideoCamera(Activity activity) { - AppLockManager.getInstance().setExtendedTimeout(); activity.startActivityForResult(prepareVideoCameraIntent(), RequestCodes.TAKE_VIDEO); } @@ -247,7 +244,6 @@ private static Intent prepareVideoCameraIntent() { } public static void launchPictureLibrary(Activity activity, boolean multiSelect) { - AppLockManager.getInstance().setExtendedTimeout(); activity.startActivityForResult( preparePictureLibraryIntent(activity.getString(R.string.pick_photo), multiSelect), RequestCodes.PICTURE_LIBRARY); @@ -273,7 +269,6 @@ private static Intent prepareGalleryIntent(String title) { public static void launchCamera(Activity activity, String applicationId, LaunchCameraCallback callback) { Intent intent = prepareLaunchCamera(activity, applicationId, callback); if (intent != null) { - AppLockManager.getInstance().setExtendedTimeout(); activity.startActivityForResult(intent, RequestCodes.TAKE_PHOTO); } } diff --git a/WordPress/src/main/res/xml/app_settings.xml b/WordPress/src/main/res/xml/app_settings.xml index ccb2164e9e16..44a45023b41c 100644 --- a/WordPress/src/main/res/xml/app_settings.xml +++ b/WordPress/src/main/res/xml/app_settings.xml @@ -121,27 +121,6 @@ - - - - - - - - - Date: Mon, 27 Aug 2018 15:34:59 +0200 Subject: [PATCH 2/4] Remove unused resources + fix checkstyle issue --- WordPress/src/main/java/org/wordpress/android/WordPress.java | 1 - WordPress/src/main/res/drawable/passcode_logo.xml | 4 ---- WordPress/src/main/res/values/key_strings.xml | 2 -- 3 files changed, 7 deletions(-) delete mode 100644 WordPress/src/main/res/drawable/passcode_logo.xml diff --git a/WordPress/src/main/java/org/wordpress/android/WordPress.java b/WordPress/src/main/java/org/wordpress/android/WordPress.java index bba0302684d3..d5d98f1fcf93 100644 --- a/WordPress/src/main/java/org/wordpress/android/WordPress.java +++ b/WordPress/src/main/java/org/wordpress/android/WordPress.java @@ -524,7 +524,6 @@ public void onAccountChanged(OnAccountChanged event) { // Analytics resets AnalyticsTracker.endSession(false); AnalyticsTracker.clearAllData(); - } if (!event.isError() && mAccountStore.hasAccessToken()) { diff --git a/WordPress/src/main/res/drawable/passcode_logo.xml b/WordPress/src/main/res/drawable/passcode_logo.xml deleted file mode 100644 index bd38776ffed2..000000000000 --- a/WordPress/src/main/res/drawable/passcode_logo.xml +++ /dev/null @@ -1,4 +0,0 @@ - - - - diff --git a/WordPress/src/main/res/values/key_strings.xml b/WordPress/src/main/res/values/key_strings.xml index 5bbb128d83b6..4e77bcbd66b2 100644 --- a/WordPress/src/main/res/values/key_strings.xml +++ b/WordPress/src/main/res/values/key_strings.xml @@ -13,8 +13,6 @@ wp_pref_root wp_pref_root - wp_passcode_lock_category - wp_pref_passlock_enabled wp_pref_privacy_settings wp_pref_send_usage_stats wp_pref_device_settings From de8738a6e25b931554e69ddb76d1708b0311aac6 Mon Sep 17 00:00:00 2001 From: vojtasmrcek Date: Mon, 27 Aug 2018 16:16:56 +0200 Subject: [PATCH 3/4] Remove unused colors and strings --- WordPress/src/main/res/values/colors.xml | 4 ---- WordPress/src/main/res/values/strings.xml | 15 --------------- 2 files changed, 19 deletions(-) diff --git a/WordPress/src/main/res/values/colors.xml b/WordPress/src/main/res/values/colors.xml index fd3cfd595fb2..d8d76b717410 100644 --- a/WordPress/src/main/res/values/colors.xml +++ b/WordPress/src/main/res/values/colors.xml @@ -168,10 +168,6 @@ #D8E3EA - @color/color_primary - @color/white - @color/white - #d0d5d9 diff --git a/WordPress/src/main/res/values/strings.xml b/WordPress/src/main/res/values/strings.xml index d4c7c622ec55..2a225cb0f068 100644 --- a/WordPress/src/main/res/values/strings.xml +++ b/WordPress/src/main/res/values/strings.xml @@ -32,7 +32,6 @@ Release notes License Help and Support - WordPress Passcode Notification settings My site Me @@ -1361,20 +1360,6 @@ Error downloading image Related post preview image - - Manage PIN lock - Enter your old PIN - Re-enter your PIN - Change PIN - PIN set - Wrong PIN - PIN lock - Turn PIN lock off - Turn PIN lock on - Enter your PIN - - - From b299cf2710ffa6e7e20d02a729fdbe69d69218cb Mon Sep 17 00:00:00 2001 From: vojtasmrcek Date: Mon, 27 Aug 2018 16:55:44 +0200 Subject: [PATCH 4/4] Remove unused drawables --- WordPress/src/main/res/anim/cycle_5.xml | 17 ----------------- WordPress/src/main/res/anim/shake.xml | 20 -------------------- WordPress/src/main/res/anim/slide_up.xml | 6 ------ 3 files changed, 43 deletions(-) delete mode 100644 WordPress/src/main/res/anim/cycle_5.xml delete mode 100644 WordPress/src/main/res/anim/shake.xml delete mode 100644 WordPress/src/main/res/anim/slide_up.xml diff --git a/WordPress/src/main/res/anim/cycle_5.xml b/WordPress/src/main/res/anim/cycle_5.xml deleted file mode 100644 index 4dfe175d7754..000000000000 --- a/WordPress/src/main/res/anim/cycle_5.xml +++ /dev/null @@ -1,17 +0,0 @@ - - - - diff --git a/WordPress/src/main/res/anim/shake.xml b/WordPress/src/main/res/anim/shake.xml deleted file mode 100644 index 628940fcaacb..000000000000 --- a/WordPress/src/main/res/anim/shake.xml +++ /dev/null @@ -1,20 +0,0 @@ - - - - diff --git a/WordPress/src/main/res/anim/slide_up.xml b/WordPress/src/main/res/anim/slide_up.xml deleted file mode 100644 index 7c6821e29c91..000000000000 --- a/WordPress/src/main/res/anim/slide_up.xml +++ /dev/null @@ -1,6 +0,0 @@ - -