Gen lockfile#36
Open
LevitatingBusinessMan wants to merge 3 commits into
Open
Conversation
LevitatingBusinessMan
force-pushed
the
gen-lockfile
branch
from
7d13595 to
6d3e41d
Compare
ZibanPirate
suggested changes
Nov 17, 2024
ZibanPirate
left a comment
ZibanPirate
left a comment
There was a problem hiding this comment.
can we get this merged @wraithan? changes seem good, and this feature makes sense I think
ZibanPirate
suggested changes
Nov 17, 2024
|
|
||
| if !&conf.ignore_lockfile { | ||
| Command::new("cargo") | ||
| .args(&["generate-lockfile", "--offline", "--manifest-path", &conf.manifest.to_string_lossy()]) |
There was a problem hiding this comment.
i found this command change more than just the current crate version
let's instead change it to cargo build it seems safer
Suggested change
| .args(&["generate-lockfile", "--offline", "--manifest-path", &conf.manifest.to_string_lossy()]) | |
| .args(&["build"]) |
Comment on lines
+70
to
+72
| Arg::with_name("ignore-lockfile") | ||
| .long("ignore-lockfile") | ||
| .help("Don't update the lockfile") |
There was a problem hiding this comment.
following the other suggestion and to not introduce a breaking change, let's change this flag to:
Suggested change
| Arg::with_name("ignore-lockfile") | |
| .long("ignore-lockfile") | |
| .help("Don't update the lockfile") | |
| Arg::with_name("build") | |
| .long("build") | |
| .help("Run cargo build after version change to generate Cargo.lock") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #24