From cff328fa74be68b6ef3b388a8a0f8d53a53b1175 Mon Sep 17 00:00:00 2001 From: Jon Harmon Date: Mon, 11 May 2026 05:52:27 -0500 Subject: [PATCH] Update news & comments --- NEWS.md | 2 ++ cran-comments.md | 39 +++++++++++++++++++++++++++------------ 2 files changed, 29 insertions(+), 12 deletions(-) diff --git a/NEWS.md b/NEWS.md index c135fd26..6072b53b 100644 --- a/NEWS.md +++ b/NEWS.md @@ -1,5 +1,7 @@ # tibblify (development version) +* Fixed type mismatch in C code (#323). + # tibblify 0.4.0 ## Breaking changes diff --git a/cran-comments.md b/cran-comments.md index f2b467f2..be29feef 100644 --- a/cran-comments.md +++ b/cran-comments.md @@ -3,17 +3,32 @@ 0 errors | 0 warnings | 1 note ``` - Maintainer: 'Jon Harmon ' - - New submission - - Package was archived on CRAN - - CRAN repository db overrides: - X-CRAN-Comment: Archived on 2025-12-18 as issues were not corrected - despite reminders. +Check: compiled code +Result: NOTE + File ‘tibblify/libs/tibblify.so’: + Found non-API calls to R: ‘PRENV’, ‘PRVALUE’, ‘R_PromiseExpr’, + ‘Rf_allocSExp’, ‘Rf_findVarInFrame3’, ‘SETLENGTH’, + ‘SET_GROWABLE_BIT’, ‘SET_PRCODE’, ‘SET_PRENV’, ‘SET_PRVALUE’, + ‘SET_TRUELENGTH’ + + Compiled code should not call non-API entry points in R. + + See ‘Writing portable packages’ in the ‘Writing R Extensions’ manual, + and section ‘Moving into C API compliance’ for issues with the use of + non-API entry points. +Flavors: r-oldrel-macos-arm64, r-oldrel-macos-x86_64 ``` -* This package was archived on 2025-12-18. Maintainer was transferred from @mgirlich (maximilian.girlich@outlook.com) to @jonthegeek (jonthegeek@gmail.com) on 2025-12-20. -* All errors and notes from the archived version have been addressed. -* The license of this package has also been updated from GPL-3 to MIT, with agreement from all code copyright holders in this PR: https://github.com/wranglezone/tibblify/pull/226 +* This NOTE is inherited from rlang, and does not appear in any other currently tested flavors. +* This submission addresses LTO warnings: + +``` +init.c:42:6: warning: type of ‘tibblify_init_utils’ does not match original declaration [-Wlto-type-mismatch] + 42 | void tibblify_init_utils(SEXP ns, SEXP vctrs_ns); + | ^ +utils.c:123:6: note: type mismatch in parameter 2 + 123 | void tibblify_init_utils(SEXP ns) { + | ^ +utils.c:123:6: note: type ‘void’ should match type ‘struct SEXPREC *’ +utils.c:123:6: note: ‘tibblify_init_utils’ was previously declared here +```