From 96f6a513328d23f036b8a83dc8dfd09beed77dcf Mon Sep 17 00:00:00 2001 From: AqeelMuhammad Date: Fri, 12 Jun 2026 14:39:56 +0530 Subject: [PATCH 1/4] feat: add imagePullSecrets.name to reference existing registry secrets Adds an optional imagePullSecrets.name field to all distributed charts (acp, tm, ugw, km), all-in-one chart, and all resource pattern default values files. When set, the chart skips creating a new dockerconfigjson Secret and references the named secret directly, allowing users to use pre-existing or externally-managed image pull secrets (e.g. sealed secrets, cloud-provider secrets). When name is empty the existing username/password credential-based behaviour is unchanged. Closes #17320 --- all-in-one/default_openshift_values.yaml | 1 + all-in-one/default_values.yaml | 1 + all-in-one/templates/am/instance-1/wso2am-deployment.yaml | 4 ++++ all-in-one/templates/am/instance-2/wso2am-deployment.yaml | 4 ++++ .../templates/secrets/wso2am-secret-docker-registry.yaml | 2 +- all-in-one/values.yaml | 2 ++ .../control-plane/instance-1/wso2am-cp-deployment.yaml | 4 ++++ .../control-plane/instance-2/wso2am-cp-deployment.yaml | 4 ++++ .../templates/secrets/wso2am-secret-docker-registry.yaml | 2 +- distributed/control-plane/values.yaml | 2 ++ .../gateway/templates/gateway/wso2am-gateway-deployment.yaml | 4 ++++ .../templates/secrets/wso2am-secret-docker-registry.yaml | 2 +- distributed/gateway/values.yaml | 2 ++ .../templates/key-manager/wso2am-km-deployment.yaml | 4 ++++ .../templates/secrets/wso2am-secret-docker-registry.yaml | 2 +- distributed/key-manager/values.yaml | 2 ++ .../templates/secrets/wso2am-secret-docker-registry.yaml | 2 +- .../traffic-manager/instance-1/wso2am-tm-deployment.yaml | 4 ++++ .../traffic-manager/instance-2/wso2am-tm-deployment.yaml | 4 ++++ distributed/traffic-manager/values.yaml | 2 ++ resources/am-pattern-0-all-in-one/default_values.yaml | 1 + resources/am-pattern-1-all-in-one-HA/default_values.yaml | 1 + resources/am-pattern-2-all-in-one_GW/default_gw_values.yaml | 1 + resources/am-pattern-2-all-in-one_GW/default_values.yaml | 1 + resources/am-pattern-3-ACP_TM_GW/default_acp_values.yaml | 1 + resources/am-pattern-3-ACP_TM_GW/default_gw_values.yaml | 1 + resources/am-pattern-3-ACP_TM_GW/default_tm_values.yaml | 1 + resources/am-pattern-4-ACP_TM_GW_KM/default_acp_values.yaml | 1 + resources/am-pattern-4-ACP_TM_GW_KM/default_gw_values.yaml | 1 + resources/am-pattern-4-ACP_TM_GW_KM/default_km_values.yaml | 1 + resources/am-pattern-4-ACP_TM_GW_KM/default_tm_values.yaml | 1 + .../am-pattern-5-all-in-one_GW_KM/default_gw_values.yaml | 1 + .../am-pattern-5-all-in-one_GW_KM/default_km_values.yaml | 1 + resources/am-pattern-5-all-in-one_GW_KM/default_values.yaml | 1 + 34 files changed, 63 insertions(+), 5 deletions(-) diff --git a/all-in-one/default_openshift_values.yaml b/all-in-one/default_openshift_values.yaml index 5af6ba6b..8ca1eb5e 100644 --- a/all-in-one/default_openshift_values.yaml +++ b/all-in-one/default_openshift_values.yaml @@ -662,6 +662,7 @@ wso2: # Specify image pull secrets for private registries imagePullSecrets: enabled: false + name: "" username: "" password: "" # -- Registry containing the image diff --git a/all-in-one/default_values.yaml b/all-in-one/default_values.yaml index 54d81d24..ca052e2b 100644 --- a/all-in-one/default_values.yaml +++ b/all-in-one/default_values.yaml @@ -760,6 +760,7 @@ wso2: # Specify image pull secrets for private registries imagePullSecrets: enabled: false + name: "" username: "" password: "" # -- Registry containing the image diff --git a/all-in-one/templates/am/instance-1/wso2am-deployment.yaml b/all-in-one/templates/am/instance-1/wso2am-deployment.yaml index d3cb940a..958197ab 100644 --- a/all-in-one/templates/am/instance-1/wso2am-deployment.yaml +++ b/all-in-one/templates/am/instance-1/wso2am-deployment.yaml @@ -66,8 +66,12 @@ spec: {{- end }} {{- if and .Values.wso2.deployment.image.imagePullSecrets.enabled }} imagePullSecrets: + {{- if .Values.wso2.deployment.image.imagePullSecrets.name }} + - name: {{ .Values.wso2.deployment.image.imagePullSecrets.name }} + {{- else }} - name: {{ template "am-all-in-one.fullname" . }}-docker-registry-auth {{- end }} + {{- end }} containers: - name: wso2am {{- if .Values.wso2.deployment.image.digest }} diff --git a/all-in-one/templates/am/instance-2/wso2am-deployment.yaml b/all-in-one/templates/am/instance-2/wso2am-deployment.yaml index 9e4ac9fc..37e6b6c4 100644 --- a/all-in-one/templates/am/instance-2/wso2am-deployment.yaml +++ b/all-in-one/templates/am/instance-2/wso2am-deployment.yaml @@ -67,8 +67,12 @@ spec: {{- end }} {{- if and .Values.wso2.deployment.image.imagePullSecrets.enabled }} imagePullSecrets: + {{- if .Values.wso2.deployment.image.imagePullSecrets.name }} + - name: {{ .Values.wso2.deployment.image.imagePullSecrets.name }} + {{- else }} - name: {{ template "am-all-in-one.fullname" . }}-docker-registry-auth {{- end }} + {{- end }} containers: - name: wso2am {{- if .Values.wso2.deployment.image.digest }} diff --git a/all-in-one/templates/secrets/wso2am-secret-docker-registry.yaml b/all-in-one/templates/secrets/wso2am-secret-docker-registry.yaml index 63b5d3d9..10c7d3ff 100644 --- a/all-in-one/templates/secrets/wso2am-secret-docker-registry.yaml +++ b/all-in-one/templates/secrets/wso2am-secret-docker-registry.yaml @@ -1,4 +1,4 @@ -{{- if and .Values.wso2.deployment.image.imagePullSecrets.enabled }} +{{- if and .Values.wso2.deployment.image.imagePullSecrets.enabled (not .Values.wso2.deployment.image.imagePullSecrets.name) }} # ------------------------------------------------------------------------------------- # # Copyright (c) 2025, WSO2 LLC. (http://www.wso2.com). All Rights Reserved. diff --git a/all-in-one/values.yaml b/all-in-one/values.yaml index 8a96f2cc..1cc04aad 100644 --- a/all-in-one/values.yaml +++ b/all-in-one/values.yaml @@ -870,6 +870,8 @@ wso2: # Specify image pull secrets for private registries imagePullSecrets: enabled: false + # -- Name of an existing image pull secret in the namespace. If set, this secret is used directly and no new secret is created. + name: "" username: "" password: "" # -- Registry containing the image diff --git a/distributed/control-plane/templates/control-plane/instance-1/wso2am-cp-deployment.yaml b/distributed/control-plane/templates/control-plane/instance-1/wso2am-cp-deployment.yaml index 8fd74da9..90171358 100644 --- a/distributed/control-plane/templates/control-plane/instance-1/wso2am-cp-deployment.yaml +++ b/distributed/control-plane/templates/control-plane/instance-1/wso2am-cp-deployment.yaml @@ -69,8 +69,12 @@ spec: {{- end }} {{- if and .Values.wso2.deployment.image.imagePullSecrets.enabled }} imagePullSecrets: + {{- if .Values.wso2.deployment.image.imagePullSecrets.name }} + - name: {{ .Values.wso2.deployment.image.imagePullSecrets.name }} + {{- else }} - name: {{ template "apim-helm-cp.fullname" . }}-docker-registry-auth {{- end }} + {{- end }} containers: - name: wso2am-control-plane {{- if .Values.wso2.deployment.image.digest }} diff --git a/distributed/control-plane/templates/control-plane/instance-2/wso2am-cp-deployment.yaml b/distributed/control-plane/templates/control-plane/instance-2/wso2am-cp-deployment.yaml index 77cab2d3..c2ab9864 100644 --- a/distributed/control-plane/templates/control-plane/instance-2/wso2am-cp-deployment.yaml +++ b/distributed/control-plane/templates/control-plane/instance-2/wso2am-cp-deployment.yaml @@ -70,8 +70,12 @@ spec: {{- end }} {{- if and .Values.wso2.deployment.image.imagePullSecrets.enabled }} imagePullSecrets: + {{- if .Values.wso2.deployment.image.imagePullSecrets.name }} + - name: {{ .Values.wso2.deployment.image.imagePullSecrets.name }} + {{- else }} - name: {{ template "apim-helm-cp.fullname" . }}-docker-registry-auth {{- end }} + {{- end }} containers: - name: wso2am-control-plane {{- if .Values.wso2.deployment.image.digest }} diff --git a/distributed/control-plane/templates/secrets/wso2am-secret-docker-registry.yaml b/distributed/control-plane/templates/secrets/wso2am-secret-docker-registry.yaml index c7c3dba9..68a4b6b7 100644 --- a/distributed/control-plane/templates/secrets/wso2am-secret-docker-registry.yaml +++ b/distributed/control-plane/templates/secrets/wso2am-secret-docker-registry.yaml @@ -1,4 +1,4 @@ -{{- if and .Values.wso2.deployment.image.imagePullSecrets.enabled }} +{{- if and .Values.wso2.deployment.image.imagePullSecrets.enabled (not .Values.wso2.deployment.image.imagePullSecrets.name) }} # ------------------------------------------------------------------------------------- # # Copyright (c) 2025, WSO2 LLC. (http://www.wso2.com). All Rights Reserved. diff --git a/distributed/control-plane/values.yaml b/distributed/control-plane/values.yaml index 23a3f57d..0008e012 100644 --- a/distributed/control-plane/values.yaml +++ b/distributed/control-plane/values.yaml @@ -645,6 +645,8 @@ wso2: # Specify image pull secrets for private registries imagePullSecrets: enabled: false + # -- Name of an existing image pull secret in the namespace. If set, this secret is used directly and no new secret is created. + name: "" username: "" password: "" # -- Container registry hostname diff --git a/distributed/gateway/templates/gateway/wso2am-gateway-deployment.yaml b/distributed/gateway/templates/gateway/wso2am-gateway-deployment.yaml index 47f1ac4f..70c0a4a9 100644 --- a/distributed/gateway/templates/gateway/wso2am-gateway-deployment.yaml +++ b/distributed/gateway/templates/gateway/wso2am-gateway-deployment.yaml @@ -70,8 +70,12 @@ spec: {{- end }} {{- if and .Values.wso2.deployment.image.imagePullSecrets.enabled }} imagePullSecrets: + {{- if .Values.wso2.deployment.image.imagePullSecrets.name }} + - name: {{ .Values.wso2.deployment.image.imagePullSecrets.name }} + {{- else }} - name: {{ template "apim-helm-gw.fullname" . }}-docker-registry-auth {{- end }} + {{- end }} containers: - name: wso2am-gateway {{- if .Values.wso2.deployment.image.digest }} diff --git a/distributed/gateway/templates/secrets/wso2am-secret-docker-registry.yaml b/distributed/gateway/templates/secrets/wso2am-secret-docker-registry.yaml index 8675f39b..f2674cea 100644 --- a/distributed/gateway/templates/secrets/wso2am-secret-docker-registry.yaml +++ b/distributed/gateway/templates/secrets/wso2am-secret-docker-registry.yaml @@ -1,4 +1,4 @@ -{{- if and .Values.wso2.deployment.image.imagePullSecrets.enabled }} +{{- if and .Values.wso2.deployment.image.imagePullSecrets.enabled (not .Values.wso2.deployment.image.imagePullSecrets.name) }} # ------------------------------------------------------------------------------------- # # Copyright (c) 2025, WSO2 LLC. (http://www.wso2.com). All Rights Reserved. diff --git a/distributed/gateway/values.yaml b/distributed/gateway/values.yaml index 771c6487..1b409894 100644 --- a/distributed/gateway/values.yaml +++ b/distributed/gateway/values.yaml @@ -570,6 +570,8 @@ wso2: # Specify image pull secrets for private registries imagePullSecrets: enabled: false + # -- Name of an existing image pull secret in the namespace. If set, this secret is used directly and no new secret is created. + name: "" username: "" password: "" # -- Container registry hostname diff --git a/distributed/key-manager/templates/key-manager/wso2am-km-deployment.yaml b/distributed/key-manager/templates/key-manager/wso2am-km-deployment.yaml index e08615f5..fe88df80 100644 --- a/distributed/key-manager/templates/key-manager/wso2am-km-deployment.yaml +++ b/distributed/key-manager/templates/key-manager/wso2am-km-deployment.yaml @@ -74,8 +74,12 @@ spec: {{- end }} {{- if and .Values.wso2.deployment.image.imagePullSecrets.enabled }} imagePullSecrets: + {{- if .Values.wso2.deployment.image.imagePullSecrets.name }} + - name: {{ .Values.wso2.deployment.image.imagePullSecrets.name }} + {{- else }} - name: {{ template "apim-helm-km.fullname" . }}-docker-registry-auth {{- end }} + {{- end }} containers: - name: wso2am-km {{- if .Values.wso2.deployment.image.digest }} diff --git a/distributed/key-manager/templates/secrets/wso2am-secret-docker-registry.yaml b/distributed/key-manager/templates/secrets/wso2am-secret-docker-registry.yaml index 04f178e7..752c5825 100644 --- a/distributed/key-manager/templates/secrets/wso2am-secret-docker-registry.yaml +++ b/distributed/key-manager/templates/secrets/wso2am-secret-docker-registry.yaml @@ -1,4 +1,4 @@ -{{- if and .Values.wso2.deployment.image.imagePullSecrets.enabled }} +{{- if and .Values.wso2.deployment.image.imagePullSecrets.enabled (not .Values.wso2.deployment.image.imagePullSecrets.name) }} # ------------------------------------------------------------------------------------- # # Copyright (c) 2025, WSO2 LLC. (http://www.wso2.com). All Rights Reserved. diff --git a/distributed/key-manager/values.yaml b/distributed/key-manager/values.yaml index eea5ddca..8c6175d8 100644 --- a/distributed/key-manager/values.yaml +++ b/distributed/key-manager/values.yaml @@ -413,6 +413,8 @@ wso2: # Specify image pull secrets for private registries imagePullSecrets: enabled: false + # -- Name of an existing image pull secret in the namespace. If set, this secret is used directly and no new secret is created. + name: "" username: "" password: "" # -- Container registry hostname diff --git a/distributed/traffic-manager/templates/secrets/wso2am-secret-docker-registry.yaml b/distributed/traffic-manager/templates/secrets/wso2am-secret-docker-registry.yaml index 0dde7214..10763870 100644 --- a/distributed/traffic-manager/templates/secrets/wso2am-secret-docker-registry.yaml +++ b/distributed/traffic-manager/templates/secrets/wso2am-secret-docker-registry.yaml @@ -1,4 +1,4 @@ -{{- if and .Values.wso2.deployment.image.imagePullSecrets.enabled }} +{{- if and .Values.wso2.deployment.image.imagePullSecrets.enabled (not .Values.wso2.deployment.image.imagePullSecrets.name) }} # ------------------------------------------------------------------------------------- # # Copyright (c) 2025, WSO2 LLC. (http://www.wso2.com). All Rights Reserved. diff --git a/distributed/traffic-manager/templates/traffic-manager/instance-1/wso2am-tm-deployment.yaml b/distributed/traffic-manager/templates/traffic-manager/instance-1/wso2am-tm-deployment.yaml index 6d9046dc..342cfd54 100644 --- a/distributed/traffic-manager/templates/traffic-manager/instance-1/wso2am-tm-deployment.yaml +++ b/distributed/traffic-manager/templates/traffic-manager/instance-1/wso2am-tm-deployment.yaml @@ -72,8 +72,12 @@ spec: {{- end }} {{- if and .Values.wso2.deployment.image.imagePullSecrets.enabled }} imagePullSecrets: + {{- if .Values.wso2.deployment.image.imagePullSecrets.name }} + - name: {{ .Values.wso2.deployment.image.imagePullSecrets.name }} + {{- else }} - name: {{ template "apim-helm-tm.fullname" . }}-docker-registry-auth {{- end }} + {{- end }} containers: - name: wso2am-traffic-manager {{- if .Values.wso2.deployment.image.digest }} diff --git a/distributed/traffic-manager/templates/traffic-manager/instance-2/wso2am-tm-deployment.yaml b/distributed/traffic-manager/templates/traffic-manager/instance-2/wso2am-tm-deployment.yaml index 91108a23..17d81bca 100644 --- a/distributed/traffic-manager/templates/traffic-manager/instance-2/wso2am-tm-deployment.yaml +++ b/distributed/traffic-manager/templates/traffic-manager/instance-2/wso2am-tm-deployment.yaml @@ -73,8 +73,12 @@ spec: {{- end }} {{- if and .Values.wso2.deployment.image.imagePullSecrets.enabled }} imagePullSecrets: + {{- if .Values.wso2.deployment.image.imagePullSecrets.name }} + - name: {{ .Values.wso2.deployment.image.imagePullSecrets.name }} + {{- else }} - name: {{ template "apim-helm-tm.fullname" . }}-docker-registry-auth {{- end }} + {{- end }} containers: - name: wso2am-traffic-manager {{- if .Values.wso2.deployment.image.digest }} diff --git a/distributed/traffic-manager/values.yaml b/distributed/traffic-manager/values.yaml index 0bc85bee..e362d429 100644 --- a/distributed/traffic-manager/values.yaml +++ b/distributed/traffic-manager/values.yaml @@ -321,6 +321,8 @@ wso2: # Specify image pull secrets for private registries imagePullSecrets: enabled: false + # -- Name of an existing image pull secret in the namespace. If set, this secret is used directly and no new secret is created. + name: "" username: "" password: "" # -- Container registry hostname diff --git a/resources/am-pattern-0-all-in-one/default_values.yaml b/resources/am-pattern-0-all-in-one/default_values.yaml index e1e9aa79..038b575a 100644 --- a/resources/am-pattern-0-all-in-one/default_values.yaml +++ b/resources/am-pattern-0-all-in-one/default_values.yaml @@ -691,6 +691,7 @@ wso2: # Specify image pull secrets for private registries imagePullSecrets: enabled: false + name: "" username: "" password: "" # -- Registry containing the image diff --git a/resources/am-pattern-1-all-in-one-HA/default_values.yaml b/resources/am-pattern-1-all-in-one-HA/default_values.yaml index 826ac681..11f28e7d 100644 --- a/resources/am-pattern-1-all-in-one-HA/default_values.yaml +++ b/resources/am-pattern-1-all-in-one-HA/default_values.yaml @@ -710,6 +710,7 @@ wso2: # Specify image pull secrets for private registries imagePullSecrets: enabled: false + name: "" username: "" password: "" # -- Container registry hostname diff --git a/resources/am-pattern-2-all-in-one_GW/default_gw_values.yaml b/resources/am-pattern-2-all-in-one_GW/default_gw_values.yaml index 71837c6f..b235e163 100644 --- a/resources/am-pattern-2-all-in-one_GW/default_gw_values.yaml +++ b/resources/am-pattern-2-all-in-one_GW/default_gw_values.yaml @@ -451,6 +451,7 @@ wso2: # Specify image pull secrets for private registries imagePullSecrets: enabled: false + name: "" username: "" password: "" # -- Container registry hostname diff --git a/resources/am-pattern-2-all-in-one_GW/default_values.yaml b/resources/am-pattern-2-all-in-one_GW/default_values.yaml index 860c3acf..f1be9fc7 100644 --- a/resources/am-pattern-2-all-in-one_GW/default_values.yaml +++ b/resources/am-pattern-2-all-in-one_GW/default_values.yaml @@ -684,6 +684,7 @@ wso2: # Specify image pull secrets for private registries imagePullSecrets: enabled: false + name: "" username: "" password: "" # -- Registry containing the image diff --git a/resources/am-pattern-3-ACP_TM_GW/default_acp_values.yaml b/resources/am-pattern-3-ACP_TM_GW/default_acp_values.yaml index 5e50e685..eee95ce4 100644 --- a/resources/am-pattern-3-ACP_TM_GW/default_acp_values.yaml +++ b/resources/am-pattern-3-ACP_TM_GW/default_acp_values.yaml @@ -503,6 +503,7 @@ wso2: # Specify image pull secrets for private registries imagePullSecrets: enabled: false + name: "" username: "" password: "" # -- Container registry hostname diff --git a/resources/am-pattern-3-ACP_TM_GW/default_gw_values.yaml b/resources/am-pattern-3-ACP_TM_GW/default_gw_values.yaml index e3b92b47..dd191b54 100644 --- a/resources/am-pattern-3-ACP_TM_GW/default_gw_values.yaml +++ b/resources/am-pattern-3-ACP_TM_GW/default_gw_values.yaml @@ -453,6 +453,7 @@ wso2: # Specify image pull secrets for private registries imagePullSecrets: enabled: false + name: "" username: "" password: "" # -- Container registry hostname diff --git a/resources/am-pattern-3-ACP_TM_GW/default_tm_values.yaml b/resources/am-pattern-3-ACP_TM_GW/default_tm_values.yaml index 795d59f6..c11c6d48 100644 --- a/resources/am-pattern-3-ACP_TM_GW/default_tm_values.yaml +++ b/resources/am-pattern-3-ACP_TM_GW/default_tm_values.yaml @@ -249,6 +249,7 @@ wso2: # Specify image pull secrets for private registries imagePullSecrets: enabled: false + name: "" username: "" password: "" # -- Container registry hostname diff --git a/resources/am-pattern-4-ACP_TM_GW_KM/default_acp_values.yaml b/resources/am-pattern-4-ACP_TM_GW_KM/default_acp_values.yaml index 4003981d..c6669590 100644 --- a/resources/am-pattern-4-ACP_TM_GW_KM/default_acp_values.yaml +++ b/resources/am-pattern-4-ACP_TM_GW_KM/default_acp_values.yaml @@ -503,6 +503,7 @@ wso2: # Specify image pull secrets for private registries imagePullSecrets: enabled: false + name: "" username: "" password: "" # -- Container registry hostname diff --git a/resources/am-pattern-4-ACP_TM_GW_KM/default_gw_values.yaml b/resources/am-pattern-4-ACP_TM_GW_KM/default_gw_values.yaml index c51e4359..bf9ea867 100644 --- a/resources/am-pattern-4-ACP_TM_GW_KM/default_gw_values.yaml +++ b/resources/am-pattern-4-ACP_TM_GW_KM/default_gw_values.yaml @@ -453,6 +453,7 @@ wso2: # Specify image pull secrets for private registries imagePullSecrets: enabled: false + name: "" username: "" password: "" # -- Container registry hostname diff --git a/resources/am-pattern-4-ACP_TM_GW_KM/default_km_values.yaml b/resources/am-pattern-4-ACP_TM_GW_KM/default_km_values.yaml index d4fec477..4e03a1ba 100644 --- a/resources/am-pattern-4-ACP_TM_GW_KM/default_km_values.yaml +++ b/resources/am-pattern-4-ACP_TM_GW_KM/default_km_values.yaml @@ -335,6 +335,7 @@ wso2: # Specify image pull secrets for private registries imagePullSecrets: enabled: false + name: "" username: "" password: "" # -- Container registry hostname diff --git a/resources/am-pattern-4-ACP_TM_GW_KM/default_tm_values.yaml b/resources/am-pattern-4-ACP_TM_GW_KM/default_tm_values.yaml index 244ea42d..8b1f4444 100644 --- a/resources/am-pattern-4-ACP_TM_GW_KM/default_tm_values.yaml +++ b/resources/am-pattern-4-ACP_TM_GW_KM/default_tm_values.yaml @@ -249,6 +249,7 @@ wso2: # Specify image pull secrets for private registries imagePullSecrets: enabled: false + name: "" username: "" password: "" # -- Container registry hostname diff --git a/resources/am-pattern-5-all-in-one_GW_KM/default_gw_values.yaml b/resources/am-pattern-5-all-in-one_GW_KM/default_gw_values.yaml index 9cb9481c..3ed27e4f 100644 --- a/resources/am-pattern-5-all-in-one_GW_KM/default_gw_values.yaml +++ b/resources/am-pattern-5-all-in-one_GW_KM/default_gw_values.yaml @@ -451,6 +451,7 @@ wso2: # Specify image pull secrets for private registries imagePullSecrets: enabled: false + name: "" username: "" password: "" # -- Container registry hostname diff --git a/resources/am-pattern-5-all-in-one_GW_KM/default_km_values.yaml b/resources/am-pattern-5-all-in-one_GW_KM/default_km_values.yaml index b1414007..bfff171a 100644 --- a/resources/am-pattern-5-all-in-one_GW_KM/default_km_values.yaml +++ b/resources/am-pattern-5-all-in-one_GW_KM/default_km_values.yaml @@ -335,6 +335,7 @@ wso2: # Specify image pull secrets for private registries imagePullSecrets: enabled: false + name: "" username: "" password: "" # -- Container registry hostname diff --git a/resources/am-pattern-5-all-in-one_GW_KM/default_values.yaml b/resources/am-pattern-5-all-in-one_GW_KM/default_values.yaml index 7486d013..7a5d9f75 100644 --- a/resources/am-pattern-5-all-in-one_GW_KM/default_values.yaml +++ b/resources/am-pattern-5-all-in-one_GW_KM/default_values.yaml @@ -692,6 +692,7 @@ wso2: # Specify image pull secrets for private registries imagePullSecrets: enabled: false + name: "" username: "" password: "" # -- Registry containing the image From 10de22935830a028229ae170b19e05d653c233fe Mon Sep 17 00:00:00 2001 From: AqeelMuhammad Date: Fri, 12 Jun 2026 14:48:07 +0530 Subject: [PATCH 2/4] docs: regenerate helm-docs for distributed charts Co-Authored-By: Claude Sonnet 4.6 --- distributed/control-plane/README.md | 3 ++- distributed/gateway/README.md | 3 ++- distributed/key-manager/README.md | 3 ++- distributed/traffic-manager/README.md | 3 ++- 4 files changed, 8 insertions(+), 4 deletions(-) diff --git a/distributed/control-plane/README.md b/distributed/control-plane/README.md index 03e0b44d..6589588a 100644 --- a/distributed/control-plane/README.md +++ b/distributed/control-plane/README.md @@ -246,7 +246,8 @@ A Helm chart for the deployment of WSO2 API Management API Control Plane profile | wso2.deployment.highAvailability | bool | `true` | Enable high availability for traffic manager. If this is enabled, two traffic manager instances will be deployed. This is not relavant to HA in Kubernetes. Multiple replicas of the same instance will not count as HA for TM. | | wso2.deployment.image.digest | string | `""` | Docker image digest | | wso2.deployment.image.imagePullPolicy | string | `"Always"` | Refer to the Kubernetes documentation on updating images (https://kubernetes.io/docs/concepts/containers/images/#updating-images) | -| wso2.deployment.image.imagePullSecrets | object | `{"enabled":false,"password":"","username":""}` | Container registry credentials. Specify image pull secrets for private registries | +| wso2.deployment.image.imagePullSecrets | object | `{"enabled":false,"name":"","password":"","username":""}` | Container registry credentials. Specify image pull secrets for private registries | +| wso2.deployment.image.imagePullSecrets.name | string | `""` | Name of an existing image pull secret in the namespace. If set, this secret is used directly and no new secret is created. | | wso2.deployment.image.registry | string | `""` | Container registry hostname | | wso2.deployment.image.repository | string | `""` | Azure ACR repository name consisting the image | | wso2.deployment.image.tag | string | `""` | Docker image tag | diff --git a/distributed/gateway/README.md b/distributed/gateway/README.md index 6cf97dc2..f8a2acad 100644 --- a/distributed/gateway/README.md +++ b/distributed/gateway/README.md @@ -220,7 +220,8 @@ A Helm chart for the deployment of WSO2 API Management Universal Gateway profile | wso2.deployment.envs | object | `{}` | Environment variables for the deployment Example: envs: MY_CUSTOM_VAR: "my-value" ANOTHER_VAR: "another-value" | | wso2.deployment.image.digest | string | `""` | Docker image digest | | wso2.deployment.image.imagePullPolicy | string | `"Always"` | Refer to the Kubernetes documentation on updating images (https://kubernetes.io/docs/concepts/containers/images/#updating-images) | -| wso2.deployment.image.imagePullSecrets | object | `{"enabled":false,"password":"","username":""}` | Container registry credentials. Specify image pull secrets for private registries | +| wso2.deployment.image.imagePullSecrets | object | `{"enabled":false,"name":"","password":"","username":""}` | Container registry credentials. Specify image pull secrets for private registries | +| wso2.deployment.image.imagePullSecrets.name | string | `""` | Name of an existing image pull secret in the namespace. If set, this secret is used directly and no new secret is created. | | wso2.deployment.image.registry | string | `""` | Container registry hostname | | wso2.deployment.image.repository | string | `""` | Azure ACR repository name consisting the image | | wso2.deployment.image.tag | string | `""` | Docker image tag | diff --git a/distributed/key-manager/README.md b/distributed/key-manager/README.md index a7052b82..2e212515 100644 --- a/distributed/key-manager/README.md +++ b/distributed/key-manager/README.md @@ -156,7 +156,8 @@ A Helm chart for the deployment of WSO2 API Manager all-in-one distribution. | wso2.deployment.highAvailability | bool | `false` | Enable high availability for key manager. If this is enabled, two key manager replicas will be deployed. | | wso2.deployment.image.digest | string | `""` | Docker image digest | | wso2.deployment.image.imagePullPolicy | string | `"Always"` | Refer to the Kubernetes documentation on updating images (https://kubernetes.io/docs/concepts/containers/images/#updating-images) | -| wso2.deployment.image.imagePullSecrets | object | `{"enabled":false,"password":"","username":""}` | Container registry credentials. Specify image pull secrets for private registries | +| wso2.deployment.image.imagePullSecrets | object | `{"enabled":false,"name":"","password":"","username":""}` | Container registry credentials. Specify image pull secrets for private registries | +| wso2.deployment.image.imagePullSecrets.name | string | `""` | Name of an existing image pull secret in the namespace. If set, this secret is used directly and no new secret is created. | | wso2.deployment.image.registry | string | `""` | Container registry hostname | | wso2.deployment.image.repository | string | `""` | Azure ACR repository name consisting the image | | wso2.deployment.image.tag | string | `""` | Docker image tag | diff --git a/distributed/traffic-manager/README.md b/distributed/traffic-manager/README.md index 36981a00..d4edcec2 100644 --- a/distributed/traffic-manager/README.md +++ b/distributed/traffic-manager/README.md @@ -115,7 +115,8 @@ A Helm chart for the deployment of WSO2 API Management Traffic Manager profile | wso2.deployment.highAvailability | bool | `true` | Enable high availability for traffic manager. If this is enabled, two traffic manager instances will be deployed. This is not relavant to HA in Kubernetes. Multiple replicas of the same instance will not count as HA for TM. | | wso2.deployment.image.digest | string | `""` | Docker image digest | | wso2.deployment.image.imagePullPolicy | string | `"Always"` | Refer to the Kubernetes documentation on updating images (https://kubernetes.io/docs/concepts/containers/images/#updating-images) | -| wso2.deployment.image.imagePullSecrets | object | `{"enabled":false,"password":"","username":""}` | Container registry credentials. Specify image pull secrets for private registries | +| wso2.deployment.image.imagePullSecrets | object | `{"enabled":false,"name":"","password":"","username":""}` | Container registry credentials. Specify image pull secrets for private registries | +| wso2.deployment.image.imagePullSecrets.name | string | `""` | Name of an existing image pull secret in the namespace. If set, this secret is used directly and no new secret is created. | | wso2.deployment.image.registry | string | `""` | Container registry hostname | | wso2.deployment.image.repository | string | `""` | Azure ACR repository name consisting the image | | wso2.deployment.image.tag | string | `""` | Docker image tag | From 4335c3f29056524ddbae4c399da51102316387c7 Mon Sep 17 00:00:00 2001 From: AqeelMuhammad Date: Fri, 12 Jun 2026 14:50:14 +0530 Subject: [PATCH 3/4] docs: regenerate helm-docs for all-in-one chart Co-Authored-By: Claude Sonnet 4.6 --- all-in-one/README.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/all-in-one/README.md b/all-in-one/README.md index a3e1ec78..9b45cbe4 100644 --- a/all-in-one/README.md +++ b/all-in-one/README.md @@ -377,7 +377,8 @@ A Helm chart for the deployment of WSO2 API Manager all-in-one distribution. | wso2.deployment.highAvailability | bool | `false` | | | wso2.deployment.image.digest | string | `""` | Docker image digest | | wso2.deployment.image.imagePullPolicy | string | `"Always"` | Refer to the Kubernetes documentation on updating images (https://kubernetes.io/docs/concepts/containers/images/#updating-images) | -| wso2.deployment.image.imagePullSecrets | object | `{"enabled":false,"password":"","username":""}` | Container registry credentials. Specify image pull secrets for private registries | +| wso2.deployment.image.imagePullSecrets | object | `{"enabled":false,"name":"","password":"","username":""}` | Container registry credentials. Specify image pull secrets for private registries | +| wso2.deployment.image.imagePullSecrets.name | string | `""` | Name of an existing image pull secret in the namespace. If set, this secret is used directly and no new secret is created. | | wso2.deployment.image.registry | string | `""` | Registry containing the image | | wso2.deployment.image.repository | string | `""` | Repository name consisting the image | | wso2.deployment.image.tag | string | `""` | Docker image tag | From f0b2a0fd5d88799b4ce99151582fc8bf6f6557f7 Mon Sep 17 00:00:00 2001 From: AqeelMuhammad Date: Fri, 12 Jun 2026 15:03:28 +0530 Subject: [PATCH 4/4] docs: add inline comment for imagePullSecrets.name in default_values files Co-Authored-By: Claude Sonnet 4.6 --- all-in-one/default_openshift_values.yaml | 1 + all-in-one/default_values.yaml | 1 + resources/am-pattern-0-all-in-one/default_values.yaml | 1 + resources/am-pattern-1-all-in-one-HA/default_values.yaml | 1 + resources/am-pattern-2-all-in-one_GW/default_gw_values.yaml | 1 + resources/am-pattern-2-all-in-one_GW/default_values.yaml | 1 + resources/am-pattern-3-ACP_TM_GW/default_acp_values.yaml | 1 + resources/am-pattern-3-ACP_TM_GW/default_gw_values.yaml | 1 + resources/am-pattern-3-ACP_TM_GW/default_tm_values.yaml | 1 + resources/am-pattern-4-ACP_TM_GW_KM/default_acp_values.yaml | 1 + resources/am-pattern-4-ACP_TM_GW_KM/default_gw_values.yaml | 1 + resources/am-pattern-4-ACP_TM_GW_KM/default_km_values.yaml | 1 + resources/am-pattern-4-ACP_TM_GW_KM/default_tm_values.yaml | 1 + resources/am-pattern-5-all-in-one_GW_KM/default_gw_values.yaml | 1 + resources/am-pattern-5-all-in-one_GW_KM/default_km_values.yaml | 1 + resources/am-pattern-5-all-in-one_GW_KM/default_values.yaml | 1 + 16 files changed, 16 insertions(+) diff --git a/all-in-one/default_openshift_values.yaml b/all-in-one/default_openshift_values.yaml index 8ca1eb5e..2d367c13 100644 --- a/all-in-one/default_openshift_values.yaml +++ b/all-in-one/default_openshift_values.yaml @@ -662,6 +662,7 @@ wso2: # Specify image pull secrets for private registries imagePullSecrets: enabled: false + # -- Name of an existing image pull secret in the namespace. If set, this secret is used directly and no new secret is created from username/password credentials. name: "" username: "" password: "" diff --git a/all-in-one/default_values.yaml b/all-in-one/default_values.yaml index ca052e2b..4d202447 100644 --- a/all-in-one/default_values.yaml +++ b/all-in-one/default_values.yaml @@ -760,6 +760,7 @@ wso2: # Specify image pull secrets for private registries imagePullSecrets: enabled: false + # -- Name of an existing image pull secret in the namespace. If set, this secret is used directly and no new secret is created from username/password credentials. name: "" username: "" password: "" diff --git a/resources/am-pattern-0-all-in-one/default_values.yaml b/resources/am-pattern-0-all-in-one/default_values.yaml index 038b575a..0f4d3e91 100644 --- a/resources/am-pattern-0-all-in-one/default_values.yaml +++ b/resources/am-pattern-0-all-in-one/default_values.yaml @@ -691,6 +691,7 @@ wso2: # Specify image pull secrets for private registries imagePullSecrets: enabled: false + # -- Name of an existing image pull secret in the namespace. If set, this secret is used directly and no new secret is created from username/password credentials. name: "" username: "" password: "" diff --git a/resources/am-pattern-1-all-in-one-HA/default_values.yaml b/resources/am-pattern-1-all-in-one-HA/default_values.yaml index 11f28e7d..4308bdbf 100644 --- a/resources/am-pattern-1-all-in-one-HA/default_values.yaml +++ b/resources/am-pattern-1-all-in-one-HA/default_values.yaml @@ -710,6 +710,7 @@ wso2: # Specify image pull secrets for private registries imagePullSecrets: enabled: false + # -- Name of an existing image pull secret in the namespace. If set, this secret is used directly and no new secret is created from username/password credentials. name: "" username: "" password: "" diff --git a/resources/am-pattern-2-all-in-one_GW/default_gw_values.yaml b/resources/am-pattern-2-all-in-one_GW/default_gw_values.yaml index b235e163..2f40fd18 100644 --- a/resources/am-pattern-2-all-in-one_GW/default_gw_values.yaml +++ b/resources/am-pattern-2-all-in-one_GW/default_gw_values.yaml @@ -451,6 +451,7 @@ wso2: # Specify image pull secrets for private registries imagePullSecrets: enabled: false + # -- Name of an existing image pull secret in the namespace. If set, this secret is used directly and no new secret is created from username/password credentials. name: "" username: "" password: "" diff --git a/resources/am-pattern-2-all-in-one_GW/default_values.yaml b/resources/am-pattern-2-all-in-one_GW/default_values.yaml index f1be9fc7..06a73ace 100644 --- a/resources/am-pattern-2-all-in-one_GW/default_values.yaml +++ b/resources/am-pattern-2-all-in-one_GW/default_values.yaml @@ -684,6 +684,7 @@ wso2: # Specify image pull secrets for private registries imagePullSecrets: enabled: false + # -- Name of an existing image pull secret in the namespace. If set, this secret is used directly and no new secret is created from username/password credentials. name: "" username: "" password: "" diff --git a/resources/am-pattern-3-ACP_TM_GW/default_acp_values.yaml b/resources/am-pattern-3-ACP_TM_GW/default_acp_values.yaml index eee95ce4..e7fe5aec 100644 --- a/resources/am-pattern-3-ACP_TM_GW/default_acp_values.yaml +++ b/resources/am-pattern-3-ACP_TM_GW/default_acp_values.yaml @@ -503,6 +503,7 @@ wso2: # Specify image pull secrets for private registries imagePullSecrets: enabled: false + # -- Name of an existing image pull secret in the namespace. If set, this secret is used directly and no new secret is created from username/password credentials. name: "" username: "" password: "" diff --git a/resources/am-pattern-3-ACP_TM_GW/default_gw_values.yaml b/resources/am-pattern-3-ACP_TM_GW/default_gw_values.yaml index dd191b54..7d213453 100644 --- a/resources/am-pattern-3-ACP_TM_GW/default_gw_values.yaml +++ b/resources/am-pattern-3-ACP_TM_GW/default_gw_values.yaml @@ -453,6 +453,7 @@ wso2: # Specify image pull secrets for private registries imagePullSecrets: enabled: false + # -- Name of an existing image pull secret in the namespace. If set, this secret is used directly and no new secret is created from username/password credentials. name: "" username: "" password: "" diff --git a/resources/am-pattern-3-ACP_TM_GW/default_tm_values.yaml b/resources/am-pattern-3-ACP_TM_GW/default_tm_values.yaml index c11c6d48..7816e229 100644 --- a/resources/am-pattern-3-ACP_TM_GW/default_tm_values.yaml +++ b/resources/am-pattern-3-ACP_TM_GW/default_tm_values.yaml @@ -249,6 +249,7 @@ wso2: # Specify image pull secrets for private registries imagePullSecrets: enabled: false + # -- Name of an existing image pull secret in the namespace. If set, this secret is used directly and no new secret is created from username/password credentials. name: "" username: "" password: "" diff --git a/resources/am-pattern-4-ACP_TM_GW_KM/default_acp_values.yaml b/resources/am-pattern-4-ACP_TM_GW_KM/default_acp_values.yaml index c6669590..9a2944b7 100644 --- a/resources/am-pattern-4-ACP_TM_GW_KM/default_acp_values.yaml +++ b/resources/am-pattern-4-ACP_TM_GW_KM/default_acp_values.yaml @@ -503,6 +503,7 @@ wso2: # Specify image pull secrets for private registries imagePullSecrets: enabled: false + # -- Name of an existing image pull secret in the namespace. If set, this secret is used directly and no new secret is created from username/password credentials. name: "" username: "" password: "" diff --git a/resources/am-pattern-4-ACP_TM_GW_KM/default_gw_values.yaml b/resources/am-pattern-4-ACP_TM_GW_KM/default_gw_values.yaml index bf9ea867..480ea67a 100644 --- a/resources/am-pattern-4-ACP_TM_GW_KM/default_gw_values.yaml +++ b/resources/am-pattern-4-ACP_TM_GW_KM/default_gw_values.yaml @@ -453,6 +453,7 @@ wso2: # Specify image pull secrets for private registries imagePullSecrets: enabled: false + # -- Name of an existing image pull secret in the namespace. If set, this secret is used directly and no new secret is created from username/password credentials. name: "" username: "" password: "" diff --git a/resources/am-pattern-4-ACP_TM_GW_KM/default_km_values.yaml b/resources/am-pattern-4-ACP_TM_GW_KM/default_km_values.yaml index 4e03a1ba..b4f07335 100644 --- a/resources/am-pattern-4-ACP_TM_GW_KM/default_km_values.yaml +++ b/resources/am-pattern-4-ACP_TM_GW_KM/default_km_values.yaml @@ -335,6 +335,7 @@ wso2: # Specify image pull secrets for private registries imagePullSecrets: enabled: false + # -- Name of an existing image pull secret in the namespace. If set, this secret is used directly and no new secret is created from username/password credentials. name: "" username: "" password: "" diff --git a/resources/am-pattern-4-ACP_TM_GW_KM/default_tm_values.yaml b/resources/am-pattern-4-ACP_TM_GW_KM/default_tm_values.yaml index 8b1f4444..47a23c20 100644 --- a/resources/am-pattern-4-ACP_TM_GW_KM/default_tm_values.yaml +++ b/resources/am-pattern-4-ACP_TM_GW_KM/default_tm_values.yaml @@ -249,6 +249,7 @@ wso2: # Specify image pull secrets for private registries imagePullSecrets: enabled: false + # -- Name of an existing image pull secret in the namespace. If set, this secret is used directly and no new secret is created from username/password credentials. name: "" username: "" password: "" diff --git a/resources/am-pattern-5-all-in-one_GW_KM/default_gw_values.yaml b/resources/am-pattern-5-all-in-one_GW_KM/default_gw_values.yaml index 3ed27e4f..b148fd66 100644 --- a/resources/am-pattern-5-all-in-one_GW_KM/default_gw_values.yaml +++ b/resources/am-pattern-5-all-in-one_GW_KM/default_gw_values.yaml @@ -451,6 +451,7 @@ wso2: # Specify image pull secrets for private registries imagePullSecrets: enabled: false + # -- Name of an existing image pull secret in the namespace. If set, this secret is used directly and no new secret is created from username/password credentials. name: "" username: "" password: "" diff --git a/resources/am-pattern-5-all-in-one_GW_KM/default_km_values.yaml b/resources/am-pattern-5-all-in-one_GW_KM/default_km_values.yaml index bfff171a..caa445f2 100644 --- a/resources/am-pattern-5-all-in-one_GW_KM/default_km_values.yaml +++ b/resources/am-pattern-5-all-in-one_GW_KM/default_km_values.yaml @@ -335,6 +335,7 @@ wso2: # Specify image pull secrets for private registries imagePullSecrets: enabled: false + # -- Name of an existing image pull secret in the namespace. If set, this secret is used directly and no new secret is created from username/password credentials. name: "" username: "" password: "" diff --git a/resources/am-pattern-5-all-in-one_GW_KM/default_values.yaml b/resources/am-pattern-5-all-in-one_GW_KM/default_values.yaml index 7a5d9f75..1f6198c1 100644 --- a/resources/am-pattern-5-all-in-one_GW_KM/default_values.yaml +++ b/resources/am-pattern-5-all-in-one_GW_KM/default_values.yaml @@ -692,6 +692,7 @@ wso2: # Specify image pull secrets for private registries imagePullSecrets: enabled: false + # -- Name of an existing image pull secret in the namespace. If set, this secret is used directly and no new secret is created from username/password credentials. name: "" username: "" password: ""