-
Notifications
You must be signed in to change notification settings - Fork 42
Open
Description
👋 was poking around in this package's internals and noticed that components returned by createI13nNode seemingly accept an i13n prop in addition to i13nModel:
react-i13n/src/core/createI13nNode.jsx
Lines 41 to 54 in aa16b94
| const I13nComponentWrapper = (props) => { | |
| const { | |
| // i13n props | |
| bindClickEvent, | |
| follow, | |
| i13n, | |
| i13nModel, | |
| isLeafNode, | |
| scanLinks, | |
| shouldFollowLink, | |
| children, | |
| ...restProps | |
| } = props; |
From what I can tell, this is only used to construct i13nProps which is eventually passed to CoreComponent. However, it's seemingly unused in there:
react-i13n/src/components/core/CoreComponent.jsx
Lines 22 to 32 in aa16b94
| const CoreComponent = (props) => { | |
| const { | |
| bindClickEvent, | |
| componentIsFunction, | |
| children, | |
| follow, | |
| i13nModel, | |
| scanLinks = {}, | |
| shouldFollowLink, | |
| viewport, | |
| } = props; |
Out of curiosity, is this prop supported / does it functionally do anything? It's not mentioned on the docs for createI13nNode, so I assume it's leftover. If that's the case, I'm happy to take a stab at cleaning it up :)
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels