Skip to content

Commit ac1061e

Browse files
authored
Styling, tweaks, cleanup (#618)
* Reduces repo-information-api call data size by 90% with compression and limiting output * Cleans up the CSS a bunch * UI's cleaner * Timers are better implemented in JS * move from Makefile to justfile * moar linting
1 parent affd689 commit ac1061e

46 files changed

Lines changed: 425 additions & 510 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.github/workflows/codeql-analysis.yml.disabled

Lines changed: 0 additions & 70 deletions
This file was deleted.

.github/workflows/mypy.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,13 @@ jobs:
1212
runs-on: ubuntu-latest
1313
steps:
1414
- uses: actions/checkout@v6
15+
- uses: extractions/setup-just@v3
1516
- name: Install uv
1617
uses: astral-sh/setup-uv@v7
1718
with:
1819
activate-environment: "true"
1920
github-token: ${{ github.token }}
21+
- uses: extractions/setup-just@v3
2022
- name: Running type checking
2123
run: |
22-
make types
24+
just lint

.github/workflows/pylint.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,12 @@ jobs:
1212
runs-on: ubuntu-latest
1313
steps:
1414
- uses: actions/checkout@v6
15+
- uses: extractions/setup-just@v3
1516
- name: Install uv
1617
uses: astral-sh/setup-uv@v7
1718
with:
1819
activate-environment: "true"
1920
github-token: ${{ github.token }}
20-
- name: Running ruff
21+
- name: Running ruff checks
2122
run: |
22-
uv run ruff check $(basename $(pwd)) tests
23+
just format

.github/workflows/pytest.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,12 @@ jobs:
1212
runs-on: ubuntu-latest
1313
steps:
1414
- uses: actions/checkout@v6
15+
- uses: extractions/setup-just@v3
1516
- name: Install uv
1617
uses: astral-sh/setup-uv@v7
1718
with:
1819
activate-environment: "true"
1920
github-token: ${{ github.token }}
2021
- name: Running pytest
2122
run: |
22-
uv run python -m pytest -m 'not network'
23+
just test -m 'not\ network'

CLAUDE.md renamed to AGENTS.md

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -6,14 +6,16 @@ This file provides guidance to Claude Code (claude.ai/code) when working with co
66

77
github_linter is a Python tool for auditing GitHub repositories at scale. It scans repositories for common configuration issues, missing files, and standardization opportunities across multiple repos.
88

9+
**MANDATORY** You are not finished with a task until running `just check` passes without warnings or errors.
10+
911
## Development Commands
1012

1113
### Testing and Linting
1214

13-
- Run all precommit checks: `make precommit`
14-
- Run linting: `make ruff`
15-
- Run type checking: `make types`
16-
- Run tests: `make test`
15+
- Run all precommit checks: `just check`
16+
- Run linting: `just ruff`
17+
- Run type checking: `just lint`
18+
- Run tests: `just test`
1719
- Run single test: `uv run pytest tests/test_<module>.py::<test_name>`
1820

1921
### Running the CLI
@@ -26,13 +28,12 @@ github_linter is a Python tool for auditing GitHub repositories at scale. It sca
2628

2729
### Web Interface
2830

29-
- Start web server: `uv run github-linter-web`
30-
- Or use the script: `./run_web.sh`
31+
- Start web server: `./run_web.sh`
3132

3233
### Docker
3334

34-
- Build container: `make docker_build`
35-
- Run web server in container: `make docker_run`
35+
- Build container: `just docker_build`
36+
- Run web server in container: `just docker_run`
3637

3738
## Architecture
3839

Makefile

Lines changed: 0 additions & 43 deletions
This file was deleted.

README.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -127,3 +127,9 @@ docker run --rm -it \
127127
ghcr.io/yaleman/github_linter:latest \
128128
python -m github_linter.web
129129
```
130+
131+
## Thanks
132+
133+
* [Vue.js](http://vuejs.org) used in the UI
134+
* [Pico](https://picocss.com) CSS framework.
135+

biome.json

Lines changed: 38 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,38 @@
1+
{
2+
"$schema": "https://biomejs.dev/schemas/2.3.11/schema.json",
3+
"files": {
4+
"includes": [
5+
"github_linter/**/*.js",
6+
"github_linter/**/*.css",
7+
"!!.venv/",
8+
"!!**/pico.min.css"
9+
]
10+
},
11+
"linter": {
12+
"enabled": true,
13+
"rules": {
14+
"recommended": true
15+
}
16+
},
17+
"formatter": {
18+
"enabled": true,
19+
"indentStyle": "space",
20+
"indentWidth": 2
21+
},
22+
"javascript": {
23+
"formatter": {
24+
"lineWidth": 80
25+
}
26+
},
27+
"overrides": [
28+
{
29+
"includes": ["*.vue"],
30+
"linter": {
31+
"enabled": true
32+
},
33+
"formatter": {
34+
"enabled": true
35+
}
36+
}
37+
]
38+
}

github_linter/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -282,7 +282,7 @@ def filter_by_repo(repo_list: List[Repository], repo_filters: List[str]) -> List
282282
return retval
283283

284284

285-
class RepoSearchString(pydantic.BaseModel): # pylint: disable=no-member
285+
class RepoSearchString(pydantic.BaseModel):
286286
"""Result of running generate_repo_search_string"""
287287

288288
needs_post_filtering: bool

github_linter/__main__.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@
3333
@click.option("--check", "-k", multiple=True, help="Filter by check name, eg check_example")
3434
@click.option("--list-repos", is_flag=True, default=False, help="List repos and exit")
3535
@click.option("--debug", "-d", is_flag=True, default=False, help="Enable debug logging")
36-
# pylint: disable=too-many-arguments,too-many-locals
3736
def cli(
3837
repo: Optional[Tuple[str]] = None,
3938
owner: Optional[Tuple[str]] = None,

0 commit comments

Comments
 (0)