Skip to content

Hub internals: narrow options forwarded to getModelFile #83

@ysdede

Description

@ysdede

Context

Follow-up from PR #77 review triage.

src/hub.js passes { ...options, progress } to getModelFile(...), while getModelFile currently uses only revision, subfolder, and progress.

Why

  • Current behavior works, but broad forwarding creates avoidable coupling
  • Future getModelFile option additions could change behavior unintentionally

Proposed change

  • Pass only file-download relevant keys (revision, subfolder, progress) from getParakeetModel
  • Keep user-visible behavior unchanged

Scope

  • Core internal cleanup only (no API signature change)

Linked PR

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions