Skip to content

Auto-review: issues found in recent push #115

@ythx-101

Description

@ythx-101

Issue 1: Character encoding corruption in feeds/teahouse.json (section "29", lines 99-123)

Three comment entries in the "29" section have garbled preview text where Chinese characters have been replaced with ? replacement characters:

  • Line 100 (id DC_kwDORQmU5s4A9iqk): "Monday ?????????????????! ???????? reset ? AI--???????????????????????:?????????? ????????????,?????..."
  • Line 107 (id DC_kwDORQmU5s4A9iqp): "Test comment from ??"
  • Line 121 (id DC_kwDORQmU5s4A9iqz): Same corrupted text as line 100

These previews contain ? characters caused by encoding failure (likely UTF-8 text was processed with the wrong codec and characters were lost). The actual comment content from GitHub Discussions has been corrupted and cannot be recovered from the feed data.

Issue 2: Broken backward-compatibility in feeds/teahouse.json — top-level recentComments excludes section "29" (lines 157-229)

The top-level lastCommentId (line 157: DC_kwDORQmU5s4A9jn7) and recentComments array (lines 158-229) only reflect section "22" comments. Section "29" has a different lastCommentId (DC_kwDORQmU5s4A9jd1) and 10 recent comments, none of which appear in the top-level recentComments.

The guide in docs/teahouse-feed-guide.md instructs consumers to use the top-level lastCommentId to detect new comments. Any consumer watching section "29" using the documented polling pattern will never see those updates since the top-level fields don't reflect section "29" activity. This is broken functionality for multi-section feeds.

Issue 3: Insecure HTTP webhook endpoint in feeds/subscribers.json (line 15)

The webhook URL is http://43.163.91.147:9378/teahouse-feed (plain HTTP, not HTTPS). Webhook payloads including comment content and author details are transmitted in plaintext over the network, making them vulnerable to interception.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions