From 694e6b99f8658fe05bf4357bbf72d5226e4c48a6 Mon Sep 17 00:00:00 2001 From: Sall Date: Sat, 25 Jul 2026 03:45:04 +0100 Subject: [PATCH] docs(instructions): mark Conventional Commits/trailer check as target policy ADR-0009's accepted evidence (a sweep of all 86 active repositories) found no workflow enforcing Conventional Commits or the disallowed-trailer rule on any default branch. This instructions file stated both as enforced in the present tense, which ADR-0009 itself now flags as a drift worth fixing. --- .github/instructions/testing.instructions.md | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/.github/instructions/testing.instructions.md b/.github/instructions/testing.instructions.md index 69ddf4274..e42523e58 100644 --- a/.github/instructions/testing.instructions.md +++ b/.github/instructions/testing.instructions.md @@ -11,12 +11,12 @@ definitions come from `decisions/0007-release-publication-flow.md`. ## Identify the class first -| Class | Repos | What it is | -| ----- | --------------------------------------- | -------------------------------- | -| 1 | `wiki`, `src`, `zd` | Continuously deployed artifact | -| 2 | `zunit`, `zsh-lint`, packaged `zsh` | Versioned tool/package | -| 3 | `zi`, most plugins/annexes | Git-consumed source | -| 4 | `.github` | Meta/infrastructure | +| Class | Repos | What it is | +| ----- | ----------------------------------- | ------------------------------ | +| 1 | `wiki`, `src`, `zd` | Continuously deployed artifact | +| 2 | `zunit`, `zsh-lint`, packaged `zsh` | Versioned tool/package | +| 3 | `zi`, most plugins/annexes | Git-consumed source | +| 4 | `.github` | Meta/infrastructure | ## Baseline (every repo) @@ -24,7 +24,11 @@ definitions come from `decisions/0007-release-publication-flow.md`. least-privilege `permissions:`, `concurrency:` on push/PR, no-emoji workflow/ job `name:` (ADR-0005), kebab-case filenames. - Zsh sources pass `zsh -n` and `zcompile`. -- Conventional Commits (ADR-0003) and the disallowed-trailer check are enforced. +- Conventional Commits (ADR-0003) and the disallowed-trailer rule are target + policy: follow them by habit when authoring commits and PR titles. A sweep + of all 86 active repositories found no workflow enforcing either one on a + default branch (see `decisions/0009-testing-ci-strategy.md` and issue + #454), so do not assume CI will catch a violation. ## By class