Wrong PredictedPing equation

[hexengraf]

I was revising the ping code in my own fork and noticed your predicted ping equation is different from Deaod's repo. Yours is:

PredictedPing = (2.0*PredictedPing + (Level.TimeSeconds - PingSendTime))/PingTweenTime;

While the original was:

PredictedPing = (2.0*PredictedPing + (Level.TimeSeconds - PingSendTime))/3.0;

The 3.0 there was very intentional, it gives 1/3 of weight to the new ping and 2/3 of weight to the old ping, it is an exponential moving average.
PingTweenTime should not be used in this equation, imagine what will happen if someone changes it to 1 or values below 1.

[zenakuten]

A lot of this stuff was made configurable at request. Players wanted to be able to tweak these without coding changes.

[zenakuten]

i can remove that one if it doesn't make sense.

[hexengraf]

It makes sense for the part inside the Tick function, where it controls the frequency of pings.
The PredictedPing should use 3.0 as a const in the equation.

[hexengraf]

Or you could rewrite the equation to create a config that controls the weight distribution between current ping and last average ping.