The Issues
- The tests use many fixtures that inherit one another - it's a very powerful setup but not easy to understand at first glance.
conftest.py files are sometimes 3 folders deep, and individual tests declare their own fixtures
- Objects such as
accounts are being imported that could instead be retrieved as fixtures
- Test file organization could be improved
How to Fix
The ultimate goal is to make the test suite understandable even to someone who has never seen ZAP before, so it can be linked to from the Brownie docs as an example of what is possible.
The Issues
conftest.pyfiles are sometimes 3 folders deep, and individual tests declare their own fixturesaccountsare being imported that could instead be retrieved as fixturesHow to Fix
tests/conftest.pyexplaining what each fixture doesconftest.pyfiles at most 1 subfolder beyondtestsREADME.mdfiles to make tests easier to navigateThe ultimate goal is to make the test suite understandable even to someone who has never seen ZAP before, so it can be linked to from the Brownie docs as an example of what is possible.