Skip to content

Commit 04f6224

Browse files
committed
docs: address Copilot review feedback on PR #53
- Add `update-branch: false` to the update-pull-request YAML example so the documented parameter appears in the example block - Note that fallback-as-pull-request=true causes pull-requests: write to be requested by default - Remove undocumented `pull-request-repo` alternative from SEC-005 guidance; keep the `allowed-repos` path which is the only supported configuration
1 parent 763ae56 commit 04f6224

2 files changed

Lines changed: 3 additions & 2 deletions

File tree

skills/aw-author/references/production-gotchas.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -405,7 +405,7 @@ This was a cosmetic/log-noise issue only — workflow functionality was not impa
405405
When using `dispatch-workflow` or `call-workflow` safe-outputs that include a `target-repo` override, gh-aw enforces **SEC-005 allowlist validation** (as of 2026-04-20, PR #27242).
406406

407407
**What this means:**
408-
- The target repository must appear in `allowed-repos` on the dispatch/call-workflow safe-output config block, **or** the workflow must use `pull-request-repo` configuration to permit the target.
408+
- The target repository must appear in `allowed-repos` on the `dispatch-workflow` or `call-workflow` safe-output config block.
409409
- Workflows that hard-code a `target-repo` without a matching `allowed-repos` entry will now fail at runtime with a validation error.
410410

411411
**How to fix:**

skills/aw-author/references/safe-outputs.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -250,6 +250,7 @@ safe-outputs:
250250
body: true
251251
footer: true
252252
target: "triggering"
253+
update-branch: false
253254
max: 1
254255
```
255256

@@ -311,7 +312,7 @@ safe-outputs:
311312
| `allowed-files` | list | — | Glob patterns forming a strict allowlist of files eligible for push |
312313
| `excluded-files` | list | — | Glob patterns for files to exclude via git pathspecs (stripped before commit) |
313314
| `patch-format` | string | `"am"` | Transport format: `"am"` (git format-patch) or `"bundle"` (git bundle, preserves merge topology) |
314-
| `fallback-as-pull-request` | boolean | `true` | Create fallback PR when push fails due to diverged/non-fast-forward branch; set `false` to disable |
315+
| `fallback-as-pull-request` | boolean | `true` | Create fallback PR when push fails due to diverged/non-fast-forward branch; because this defaults to `true`, `pull-requests: write` is requested by default; set `false` to disable |
315316
| `allow-workflows` | boolean | `false` | Add `workflows: write` to the App token (requires `safe-outputs.github-app`) |
316317
| `github-token-for-extra-empty-commit` | string | — | Token for empty commit to trigger CI (PAT or `"app"`) |
317318
| `max` | integer | `1` | Maximum pushes per run |

0 commit comments

Comments
 (0)