Mentions incorrectly matching periods at the end of sentences

[adammcmaster]

I'm not sure if there's a good way to fix this, but in the mentions regex:

https://github.com/zooniverse/Talk-Api/blob/6729cb1b43a279e8209b70a677802db6d141b1cb/app/models/concerns/comment/mentioning.rb#L16

This will also match periods which happen to follow the username but aren't actually part of the username. Report from Talk here.

E.g. if someone says This is a sentence ending with @user.name. it doesn't seem to correctly parse the username. If we fix that, we'd also break mentions for users with trailing periods in their names, but I'd guess that's pretty rare so it's probably the better option.

[marten]

There's nobody with a dot at the end. There are people called . and - though. :(

[camallen]

Noting that modifying the final match regex ( @([\w\-\.]+) ) to match the trailing period yet still capturing the login will make this work. I'll have a look