Skip to content

Consolidate file-conflict UI into one minimal header bar#391

Merged
PaulHorn merged 1 commit into
mainfrom
file-dif
Jun 15, 2026
Merged

Consolidate file-conflict UI into one minimal header bar#391
PaulHorn merged 1 commit into
mainfrom
file-dif

Conversation

@PaulHorn

Copy link
Copy Markdown
Contributor

Summary

Tidies the "Changed on disk" file-conflict UI in the editor panel so it reads as one minimal header instead of two stacked bars.

  • One header bar, not two — the orange warning banner and the separate On disk vs your unsaved changes / Close diff toolbar are merged into a single strip styled to match the window chrome (same --node-chrome-bg treatment as the markdown header). Dropped the loud orange tint; the warning icon is the only color accent.
  • Diff-aware bar — the label adapts (Changed on disk…On disk vs your unsaved changes) and View diff toggles to Close diff in place. The diff overlay no longer renders its own header row.
  • Minimal buttons — ghost-style (transparent until hover); Keep both uses the app's subtle warning accent instead of a solid orange fill.
  • Slimmer diff right edge — removed the wide diff overview ruler and switched to thin 8px scrollbars.

Test plan

  • npx tsc --noEmit clean
  • EditorConflictBanner.test.tsx updated for the new showDiff / onCloseDiff props, plus a new test for the View↔Close diff toggle — all passing

…r bar

Merge the orange "Changed on disk" warning banner and the separate
"On disk vs your unsaved changes" / Close diff toolbar into a single
header strip that matches the window chrome. The bar is now diff-aware:
View diff toggles to Close diff in place, and the diff overlay no longer
renders its own header.

Also slim the diff view's right edge — drop the wide diff overview ruler
and use thin 8px scrollbars.
@PaulHorn PaulHorn merged commit 6814299 into main Jun 15, 2026
3 checks passed
@PaulHorn PaulHorn deleted the file-dif branch June 15, 2026 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant