fix: contain watcher EMFILE runtime crashes#395
Merged
Conversation
6048e32 to
426c559
Compare
426c559 to
179d052
Compare
Contributor
|
ran the tests + typecheck locally, all green. handlers are code-agnostic so ENOSPC (the inotify limit you hit on linux for big repos) recovers too, just no test for it. fine to add later. merging. |
validatePath() returns path.resolve(p), so '/repo' becomes a drive-prefixed backslash path on Windows and the hardcoded POSIX event paths never matched the subscriber prefix. Derive ROOT/SRC/file paths from path.resolve/join.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #394.
This PR makes filesystem watcher failures recoverable instead of allowing them to cascade into a fatal Electron main-process
write EPIPEdialog.Changes:
file.watchsubscriptions under an existing covering watcher root to avoid duplicate full-tree chokidar watchers for the same workspace.errorevents, close the broken watcher, and allow a later watch request to recreate it.EPIPEexceptions.Validation