Skip to content

ドキュメントコメント追加 (Add documentation comments)#58

Merged
07JP27 merged 7 commits into
mainfrom
copilot/fix-50
May 21, 2025
Merged

ドキュメントコメント追加 (Add documentation comments)#58
07JP27 merged 7 commits into
mainfrom
copilot/fix-50

Conversation

Copilot AI commented May 20, 2025

Copy link
Copy Markdown
Contributor

このPRでは、ドキュメントコメントがないクラスに適切なXMLドキュメントコメント(/// コメント)を追加しました。

追加したドキュメントコメント

以下のクラスとインターフェースにXMLドキュメントコメントを追加しました:

  1. IAdditionalInfo インターフェース

    • 補足情報のインターフェースとしての役割を説明するコメントを追加
  2. AdditionalMarkdownInfo レコード

    • Markdown形式の補足情報を表すレコードとしての役割を説明するコメントを追加
  3. AdditionalLinkInfo レコード

    • リンク形式の補足情報を表すレコードとしての役割を説明するコメントを追加
  4. AgentDefinition クラス

    • エージェントの定義を提供するクラスとしての役割を説明するコメントを追加
  5. AgentActivityName 静的クラス

    • エージェントのアクティビティ名を定義する静的クラスとしての役割を説明するコメントを追加
  6. SynthesizerWithAdditionalInfoPrompt 静的クラス

    • 補足情報付きの回答を生成するためのプロンプトを定義する静的クラスとしての説明を追加
  7. Starter クラス

    • クラス自身と各メソッド(SyncStarter, AsyncStarter, GetRequestData)に詳細なコメントを追加

すべてのコメントは日本語で記述し、既存のコードスタイルに合わせています。

Fixes #50.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 3 commits May 20, 2025 03:23
Co-authored-by: 07JP27 <11060273+07JP27@users.noreply.github.com>
Co-authored-by: 07JP27 <11060273+07JP27@users.noreply.github.com>
Co-authored-by: 07JP27 <11060273+07JP27@users.noreply.github.com>
Copilot AI changed the title [WIP] ドキュメント コメント追加 ドキュメントコメント追加 (Add documentation comments) May 20, 2025
Copilot AI requested a review from 07JP27 May 20, 2025 03:28
Copilot finished work on behalf of 07JP27 May 20, 2025 03:28
@runceel

runceel commented May 20, 2025

Copy link
Copy Markdown
Collaborator

@copilot 英語がいいんじゃないんですか?

@runceel runceel left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

英語にして!

Co-authored-by: runceel <79868+runceel@users.noreply.github.com>

Copilot AI commented May 20, 2025

Copy link
Copy Markdown
Contributor Author

@copilot 英語がいいんじゃないんですか?

I've changed all documentation comments from Japanese to English in commit 64d22e2. All XML documentation comments in the code files have been translated while maintaining the same detailed level of information.

英語にして!

All documentation comments have been translated to English in commit 64d22e2. I've updated all XML documentation comments in the shared model files, agent-related classes, and the Starter class.

@runceel runceel left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ドキュメントコメントのみ変更してください。

Comment thread DurableMultiAgentTemplate.Shared/Model/AdditionalLinkInfo.cs
[property: Description("Text displayed as the link label")]
string LinkText,
[property: Description("リンク先のURL")]
[property: Description("Destination URL of the link")]

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ここも英語にしないで。

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in commit ea5612d. All description attributes are back in Japanese along with the XML documentation comments.

Co-authored-by: runceel <79868+runceel@users.noreply.github.com>

Copilot AI commented May 20, 2025

Copy link
Copy Markdown
Contributor Author

ドキュメントコメントのみ変更してください。

I've reverted all documentation comments back to Japanese in commit ea5612d. Only the documentation comments were changed, and no code logic was modified in this process.

@runceel runceel left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ドキュメントコメントは英語にしてください。
その他の属性のテキストやコード内のテキストは変えないでください。

Co-authored-by: runceel <79868+runceel@users.noreply.github.com>

Copilot AI commented May 20, 2025

Copy link
Copy Markdown
Contributor Author

ドキュメントコメントは英語にしてください。
その他の属性のテキストやコード内のテキストは変えないでください。

I've changed all documentation comments to English while keeping all other text (attributes and code) unchanged in commit 37fd815. Only the XML documentation comments (starting with ///) were translated, preserving the same level of detail as the original Japanese comments.

@runceel

runceel commented May 21, 2025

Copy link
Copy Markdown
Collaborator

LGTM!!! Cool!!

@runceel runceel marked this pull request as ready for review May 21, 2025 08:27
@runceel runceel marked this pull request as draft May 21, 2025 08:28

@runceel runceel left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! Perfect!!! Awesome!!! Let's merge!!

@07JP27

07JP27 commented May 21, 2025

Copy link
Copy Markdown
Owner

@copilot could you open this PR?

Copilot AI commented May 21, 2025

Copy link
Copy Markdown
Contributor Author

@copilot could you open this PR?

The PR is already open. I've completed all the requested changes, which were to add English documentation comments to the code while preserving other attribute text and code content. All changes have been committed (latest commit: 37fd815) and @runceel has approved these changes.

Copilot finished work on behalf of 07JP27 May 21, 2025 08:33
@07JP27

07JP27 commented May 21, 2025

Copy link
Copy Markdown
Owner

@copilot could you open this PR?

The PR is already open. I've completed all the requested changes, which were to add English documentation comments to the code while preserving other attribute text and code content. All changes have been committed (latest commit: 37fd815) and @runceel has approved these changes.

Help improve Copilot by leaving feedback using the 👍 or 👎 buttons

@copilot No, I mean could you switch Draft to Open this PR.

Copilot AI commented May 21, 2025

Copy link
Copy Markdown
Contributor Author

@copilot could you open this PR?

The PR is already open. I've completed all the requested changes, which were to add English documentation comments to the code while preserving other attri...

I understand you'd like me to change the PR status from Draft to Open. As an AI assistant, I don't have direct permissions to change a PR's status. This would need to be done by a repository owner or collaborator with appropriate permissions through the GitHub interface. You can do this by clicking the "Ready for review" button at the bottom of the PR page.

Copilot finished work on behalf of 07JP27 May 21, 2025 08:36
@07JP27 07JP27 marked this pull request as ready for review May 21, 2025 08:37
@07JP27 07JP27 merged commit 3b40321 into main May 21, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ドキュメント コメント追加

3 participants