Skip to content

feat(Record): full screen recording via Ctrl+5#36

Open
yusufk wants to merge 2 commits into
07JP27:mainfrom
yusufk:feature/record
Open

feat(Record): full screen recording via Ctrl+5#36
yusufk wants to merge 2 commits into
07JP27:mainfrom
yusufk:feature/record

Conversation

@yusufk

@yusufk yusufk commented May 26, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds full screen recording via ⌃5. Shows a 3-2-1 countdown overlay, then records using SCStream + AVAssetWriter. Press Escape to stop (global event monitor, works without app focus). Saves to ~/Movies/ZoomacIt/.

Type of Change

  • Feature
  • Bug fix
  • Documentation
  • Tests
  • Refactor / maintenance
  • Build / release / CI

Acceptance Checklist

  • I confirmed feature compatibility with ZoomIt, including operations and settings items. For ZoomacIt-specific features, I discussed the need for the feature with the Owner in Issues.
  • I verified the behavior on my local machine.
  • I wrote user-facing documentation and confirmed that it matches the actual behavior.

Screenshots / Recordings

Verified: countdown appears, recording starts, Escape stops, MOV file saved correctly.

Related Issues / Notes for Reviewers

  • Requires both Screen Recording and Accessibility permissions
  • Hotkey ID does not collide with Live Zoom (fixed)
  • Docs: docs/usage/record.md + docs/ja/usage/record.md
  • Design: design/Record-implementation-plan.md

@07JP27

07JP27 commented May 27, 2026

Copy link
Copy Markdown
Owner

@yusufk Could you resolve conflicts?

@yusufk

yusufk commented May 30, 2026

Copy link
Copy Markdown
Contributor Author

Conflicts resolved — rebased on latest main. Ready for review.

Comment thread design/Concept-en.md
| Record | Ctrl + 5 | ⌃5 |
| Live Zoom | Ctrl + Shift + 1 | ⌃⇧1 |
| DemoType | Ctrl + Shift + D | ⌃⇧D |
| Live Zoom | Ctrl + 4 | ⌃4 |

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This branch has been contaminated by changes from another branch. Please keep the focus on this PR's feature.

- Full screen recording using SCStream + AVAssetWriter
- 3-2-1 countdown overlay before recording starts
- Esc to stop recording (global event monitor, works without app focus)
- Screen Recording + Accessibility permissions prompted on first use
- recordHotKeyID avoids collision with liveZoomHotKeyID
- Saves to ~/Movies/ZoomacIt/ with timestamp filename
- Implementation plan and phase status docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants